Apply leak test to the size portion of the TimeoutAndSize tests

Author: Brian Attwell

src/main/java/io/reactivex/internal/operators/observable/ObservableReplay.java

@@ -739,7 +739,9 @@ void truncateFinal() {
         /* test */ final void collectValuesInMemory(Collection<? super T> output) {
             Node next = getHead();
             for (;;) {
-                if (next != null) {
+                if (next == null) {
+                    break;
+                } else if (next.value != null) {
                     Object o = next.value;
                     Object v = leaveTransform(o);
                     if (NotificationLite.isComplete(v) || NotificationLite.isError(v)) {
@@ -749,8 +751,6 @@ void truncateFinal() {
                     if (value != null) {
                         output.add(value);
                     }
-                } else {
-                    break;
                 }
                 next = next.get();
             }

src/test/java/io/reactivex/internal/operators/observable/ObservableReplayTest.java

@@ -12,7 +12,6 @@
  */
 
 package io.reactivex.internal.operators.observable;
-
 import static org.junit.Assert.*;
 import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
@@ -766,8 +765,7 @@ public void testTimedAndSizedTruncation() {
 
         buf.next(3);
         buf.next(4);
-        values.clear();
-        buf.collect(values);
+        collectAndAssertNoLeaks(buf, values);
         Assert.assertEquals(Arrays.asList(3, 4), values);
 
         test.advanceTimeBy(2, TimeUnit.SECONDS);
@@ -809,8 +807,7 @@ public void testTimedAndSizedTruncationError() {
 
         buf.next(3);
         buf.next(4);
-        values.clear();
-        buf.collect(values);
+        collectAndAssertNoLeaks(buf, values);
         Assert.assertEquals(Arrays.asList(3, 4), values);
 
         test.advanceTimeBy(2, TimeUnit.SECONDS);