Skip to content

Commit 8fa47d5

Browse files
committed
[#19] Updated Subrequests Axios usage and added test coverage.
1 parent 9c14e20 commit 8fa47d5

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

src/schemaBase.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class schemaBase {
4343
}
4444

4545
async getData() {
46-
const subrequest = new Subrequest({ axios: this.axios })
46+
const subrequest = new Subrequest(this.axios)
4747
for (const resource of this.resources) {
4848
subrequest.requests.push(resource.subrequest)
4949
}
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import Subrequest from '../subrequest'
2+
3+
test('Subrequest', async () => {
4+
// Throw error if 'axios' not provided.
5+
expect(() => { new Subrequest() }).toThrow('Axios is required.')
6+
})

src/utils/subrequest.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
import deserialze from './deserialize'
22

33
class Subrequest {
4-
constructor(config) {
5-
this.axios = config.axios
4+
constructor(axios) {
5+
if (typeof axios === 'undefined') {
6+
throw new Error('Axios is required.')
7+
}
8+
9+
this.axios = axios
610
this.requests = []
711
}
812

0 commit comments

Comments
 (0)