feat(change_detection): implement a change detector generator

Author: vsavkin

modules/benchmarks/src/change_detection/change_detection_benchmark.js

@@ -8,6 +8,7 @@ import {
   Parser,
   ChangeDetector,
   ProtoChangeDetector,
+  DynamicProtoChangeDetector,
   ChangeDispatcher,
 } from 'change_detection/change_detection';
 
@@ -102,7 +103,7 @@ function setUpChangeDetection(iterations) {
   var dispatcher = new DummyDispatcher();
   var parser = new Parser(new Lexer());
 
-  var parentProto = new ProtoChangeDetector();
+  var parentProto = new DynamicProtoChangeDetector();
   var parentCD = parentProto.instantiate(dispatcher, MapWrapper.create());
 
   var astWithSource = [
@@ -119,7 +120,7 @@ function setUpChangeDetection(iterations) {
   ];
 
   function proto(i) {
-    var pcd = new ProtoChangeDetector();
+    var pcd = new DynamicProtoChangeDetector();
     pcd.addAst(astWithSource[i % 10].ast, "memo", i, false);
     return pcd;
   }

modules/benchmarks/src/compiler/compiler_benchmark.js

@@ -3,7 +3,7 @@ import {isBlank, Type} from 'facade/lang';
 import {MapWrapper} from 'facade/collection';
 import {DirectiveMetadata} from 'core/compiler/directive_metadata';
 
-import {Parser, Lexer, ProtoRecordRange} from 'change_detection/change_detection';
+import {Parser, Lexer, ProtoRecordRange, dynamicChangeDetection} from 'change_detection/change_detection';
 
 import {Compiler, CompilerCache} from 'core/compiler/compiler';
 import {DirectiveMetadataReader} from 'core/compiler/directive_metadata_reader';
@@ -79,7 +79,7 @@ export function main() {
   setupReflector();
   var reader = new DirectiveMetadataReader();
   var cache = new CompilerCache();
-  var compiler = new Compiler(null, reader, new Parser(new Lexer()), cache);
+  var compiler = new Compiler(dynamicChangeDetection, null, reader, new Parser(new Lexer()), cache);
   var annotatedComponent = reader.read(BenchmarkComponent);
 
   var templateNoBindings = loadTemplate('templateNoBindings', count);

modules/benchmarks/src/tree/tree_benchmark.js

@@ -1,4 +1,5 @@
-import {Parser, Lexer, ChangeDetector} from 'change_detection/change_detection';
+import {Parser, Lexer, ChangeDetector, ChangeDetection, jitChangeDetection}
+  from 'change_detection/change_detection';
 
 import {bootstrap, Component, Template, TemplateConfig, ViewPort, Compiler} from 'angular/angular';
 
@@ -38,11 +39,7 @@ function setupReflector() {
       },
       template: new TemplateConfig({
           directives: [TreeComponent, NgIf],
-          inline: `
-    <span> {{data.value}}
-       <span template='ng-if data.right != null'><tree [data]='data.right'></tree></span>
-       <span template='ng-if data.left != null'><tree [data]='data.left'></tree></span>
-    </span>`
+          inline: `<span>{{data.value}}<span template='ng-if data.right != null'><tree [data]='data.right'></tree></span><span template='ng-if data.left != null'><tree [data]='data.left'></tree></span></span>`
       })
     })]
   });
@@ -59,8 +56,8 @@ function setupReflector() {
   });
 
   reflector.registerType(Compiler, {
-    'factory': (templateLoader, reader, parser, compilerCache) => new Compiler(templateLoader, reader, parser, compilerCache),
-    'parameters': [[TemplateLoader], [DirectiveMetadataReader], [Parser], [CompilerCache]],
+    'factory': (cd, templateLoader, reader, parser, compilerCache) => new Compiler(cd, templateLoader, reader, parser, compilerCache),
+    'parameters': [[ChangeDetection], [TemplateLoader], [DirectiveMetadataReader], [Parser], [CompilerCache]],
     'annotations': []
   });
 

modules/change_detection/src/abstract_change_detector.js

@@ -0,0 +1,46 @@
+import {List, ListWrapper} from 'facade/collection';
+import {ChangeDetector} from './interfaces';
+
+export class AbstractChangeDetector extends ChangeDetector {
+  children:List;
+  parent:ChangeDetector;
+
+  constructor() {
+    this.children = [];
+  }
+
+  addChild(cd:ChangeDetector) {
+    ListWrapper.push(this.children, cd);
+    cd.parent = this;
+  }
+
+  removeChild(cd:ChangeDetector) {
+    ListWrapper.remove(this.children, cd);
+  }
+
+  remove() {
+    this.parent.removeChild(this);
+  }
+
+  detectChanges() {
+    this._detectChanges(false);
+  }
+
+  checkNoChanges() {
+    this._detectChanges(true);
+  }
+
+  _detectChanges(throwOnChange:boolean) {
+    this.detectChangesInRecords(throwOnChange);
+    this._detectChangesInChildren(throwOnChange);
+  }
+
+  detectChangesInRecords(throwOnChange:boolean){}
+
+  _detectChangesInChildren(throwOnChange:boolean) {
+    var children = this.children;
+    for(var i = 0; i < children.length; ++i) {
+      children[i]._detectChanges(throwOnChange);
+    }
+  }
+}

modules/change_detection/src/change_detection.js

@@ -5,5 +5,26 @@ export {ContextWithVariableBindings} from './parser/context_with_variable_bindin
 
 export {ExpressionChangedAfterItHasBeenChecked, ChangeDetectionError} from './exceptions';
 export {ChangeRecord, ChangeDispatcher, ChangeDetector} from './interfaces';
-export {ProtoChangeDetector} from './proto_change_detector';
-export {DynamicChangeDetector} from './dynamic_change_detector';
+export {ProtoChangeDetector, DynamicProtoChangeDetector, JitProtoChangeDetector} from './proto_change_detector';
+export {DynamicChangeDetector} from './dynamic_change_detector';
+
+import {ProtoChangeDetector, DynamicProtoChangeDetector, JitProtoChangeDetector} from './proto_change_detector';
+
+export class ChangeDetection {
+  createProtoChangeDetector(name:string){}
+}
+
+export class DynamicChangeDetection extends ChangeDetection {
+  createProtoChangeDetector(name:string):ProtoChangeDetector{
+    return new DynamicProtoChangeDetector();
+  }
+}
+
+export class JitChangeDetection extends ChangeDetection {
+  createProtoChangeDetector(name:string):ProtoChangeDetector{
+    return new JitProtoChangeDetector();
+  }
+}
+
+export var dynamicChangeDetection = new DynamicChangeDetection();
+export var jitChangeDetection = new JitChangeDetection();

modules/change_detection/src/change_detection_jit_generator.dart

@@ -0,0 +1,10 @@
+library change_detectoin.change_detection_jit_generator;
+
+class ChangeDetectorJITGenerator {
+  ChangeDetectorJITGenerator(typeName, records) {
+  }
+
+  generate() {
+    throw "Not supported in Dart";
+  }
+}