Skip to content

Commit 9f49428

Browse files
authored
[py] Fix broken test for chromedriver logging (SeleniumHQ#15579)
* [py] Fix broken test for chromedriver logging * [py] Fix problem with driver cleanup in test
1 parent 5c89e7e commit 9f49428

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

py/test/selenium/webdriver/chrome/chrome_service_tests.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,30 @@ def test_uses_chromedriver_logging(clean_driver, driver_executable) -> None:
3030
log_file = "chromedriver.log"
3131
service_args = ["--append-log"]
3232

33-
service = Service(
33+
service1 = Service(
3434
log_output=log_file,
3535
service_args=service_args,
3636
executable_path=driver_executable,
3737
)
38+
39+
service2 = Service(
40+
log_output=log_file,
41+
service_args=service_args,
42+
executable_path=driver_executable,
43+
)
44+
45+
driver1 = None
3846
driver2 = None
3947
try:
40-
driver1 = clean_driver(service=service)
48+
driver1 = clean_driver(service=service1)
4149
with open(log_file) as fp:
4250
lines = len(fp.readlines())
43-
driver2 = clean_driver(service=service)
51+
driver2 = clean_driver(service=service2)
4452
with open(log_file) as fp:
4553
assert len(fp.readlines()) >= 2 * lines
4654
finally:
47-
driver1.quit()
55+
if driver1:
56+
driver1.quit()
4857
if driver2:
4958
driver2.quit()
5059
os.remove(log_file)

0 commit comments

Comments
 (0)