[dotnet] Enable Nullable Reference Types (SeleniumHQ#15354)

* [dotnet] Enable Nullable Reference Types

* Remove nullable enable

* fix build

* Add nullable handling to `executable_assembly.bzl`

* Fix format build

* Enable nullable on .NET Standard 2.0

* fix comment formatting

* whitespace

Author: RenderMichael

dotnet/private/executable_assembly.bzl

@@ -75,6 +75,7 @@ def create_executable_assembly(ctx, extra_srcs, extra_deps):
             internals_visible_to = None,
             internals_visible_to_cs = None,
             langversion = ctx.attr.langversion,
+            nullable = ctx.attr.nullable,
             resources = ctx.files.resources,
             srcs = ctx.files.srcs + extra_srcs,
             out = ctx.attr.out,
@@ -143,6 +144,9 @@ csharp_executable = rule(
         "langversion": attr.string(
             doc = "The version string for the C# language.",
         ),
+        "nullable": attr.string(
+            doc = "Enable nullable context, or nullable warnings.",
+        ),
         "resources": attr.label_list(
             doc = "A list of files to embed in the DLL as resources.",
             allow_files = True,

dotnet/src/webdriver/Alert.cs

@@ -20,8 +20,6 @@
 using System;
 using System.Collections.Generic;
 
-#nullable enable
-
 namespace OpenQA.Selenium
 {
     /// <summary>

dotnet/src/webdriver/BUILD.bazel

@@ -37,6 +37,7 @@ csharp_library(
         "WebDriver.Common.Tests",
     ],
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",
@@ -76,6 +77,7 @@ csharp_library(
         "WebDriver.Common.Tests",
     ],
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",
@@ -103,6 +105,7 @@ csharp_library(
     out = "WebDriver.StrongNamed",
     keyfile = "//dotnet:WebDriver.snk",
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",
@@ -140,6 +143,7 @@ csharp_library(
     ],
     keyfile = "//dotnet:WebDriver.snk",
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",

dotnet/src/webdriver/BiDi/BiDi.cs

@@ -22,8 +22,6 @@
 using OpenQA.Selenium.BiDi.Communication;
 using OpenQA.Selenium.BiDi.Communication.Transport;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi;
 
 public class BiDi : IAsyncDisposable

dotnet/src/webdriver/BiDi/BiDiException.cs

@@ -19,8 +19,6 @@
 
 using System;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi;
 
 public class BiDiException : Exception

dotnet/src/webdriver/BiDi/Communication/Broker.cs

@@ -30,8 +30,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication;
 
 public class Broker : IAsyncDisposable

dotnet/src/webdriver/BiDi/Communication/Command.cs

@@ -17,8 +17,6 @@
 // under the License.
 // </copyright>
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication;
 
 public abstract class Command

dotnet/src/webdriver/BiDi/Communication/CommandOptions.cs

@@ -19,8 +19,6 @@
 
 using System;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication;
 
 public record CommandOptions

dotnet/src/webdriver/BiDi/Communication/EventHandler.cs

@@ -22,8 +22,6 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication;
 
 public abstract class EventHandler(string eventName, Type eventArgsType, IEnumerable<BrowsingContext>? contexts = null)

dotnet/src/webdriver/BiDi/Communication/Json/Converters/BrowserClientWindowConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class BrowserClientWindowConverter : JsonConverter<ClientWindow>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/BrowserUserContextConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class BrowserUserContextConverter : JsonConverter<UserContext>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/BrowsingContextConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class BrowsingContextConverter : JsonConverter<BrowsingContext>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/ChannelConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class ChannelConverter : JsonConverter<Channel>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/DateTimeOffsetConverter.cs

@@ -21,8 +21,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class DateTimeOffsetConverter : JsonConverter<DateTimeOffset>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Enumerable/GetClientWindowsResultConverter.cs

@@ -23,8 +23,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Enumerable;
 
 internal class GetClientWindowsResultConverter : JsonConverter<GetClientWindowsResult>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Enumerable/GetCookiesResultConverter.cs

@@ -23,8 +23,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Enumerable;
 
 internal class GetCookiesResultConverter : JsonConverter<GetCookiesResult>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Enumerable/GetRealmsResultConverter.cs

@@ -23,8 +23,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Enumerable;
 
 internal class GetRealmsResultConverter : JsonConverter<GetRealmsResult>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Enumerable/GetUserContextsResultConverter.cs

@@ -23,8 +23,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Enumerable;
 
 internal class GetUserContextsResultConverter : JsonConverter<GetUserContextsResult>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Enumerable/InputSourceActionsConverter.cs

@@ -23,8 +23,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Enumerable;
 
 internal class InputSourceActionsConverter : JsonConverter<SourceActions>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Enumerable/LocateNodesResultConverter.cs

@@ -24,8 +24,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Enumerable;
 
 internal class LocateNodesResultConverter : JsonConverter<LocateNodesResult>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/HandleConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class HandleConverter : JsonConverter<Handle>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/InputOriginConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class InputOriginConverter : JsonConverter<Origin>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/InterceptConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class InterceptConverter : JsonConverter<Intercept>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/InternalIdConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class InternalIdConverter : JsonConverter<InternalId>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/NavigationConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class NavigationConverter : JsonConverter<Navigation>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/EvaluateResultConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Polymorphic;
 
 // https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/LogEntryConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Polymorphic;
 
 // https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/MessageConverter.cs

@@ -21,8 +21,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Polymorphic;
 
 // https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/RealmInfoConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Polymorphic;
 
 // https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/RemoteValueConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters.Polymorphic;
 
 // https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Json/Converters/PreloadScriptConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class PreloadScriptConverter : JsonConverter<PreloadScript>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/PrintPageRangeConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class PrintPageRangeConverter : JsonConverter<PrintPageRange>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/RealmConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class RealmConverter : JsonConverter<Realm>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/RealmTypeConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class RealmTypeConverter : JsonConverter<RealmType>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/RequestConverter.cs

@@ -22,8 +22,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class RequestConverter : JsonConverter<Request>

dotnet/src/webdriver/BiDi/Communication/Json/Converters/SubscriptionConverter.cs

@@ -21,8 +21,6 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 internal class SubscriptionConverter : JsonConverter<Modules.Session.Subscription>

dotnet/src/webdriver/BiDi/Communication/Message.cs

@@ -19,8 +19,6 @@
 
 using System.Text.Json;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication;
 
 // https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Transport/ITransport.cs

@@ -21,8 +21,6 @@
 using System.Threading;
 using System;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Transport;
 
 interface ITransport : IDisposable

dotnet/src/webdriver/BiDi/Communication/Transport/WebSocketTransport.cs

@@ -25,8 +25,6 @@
 using System.Text;
 using OpenQA.Selenium.Internal.Logging;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication.Transport;
 
 class WebSocketTransport(Uri _uri) : ITransport, IDisposable

dotnet/src/webdriver/BiDi/EventArgs.cs

@@ -20,8 +20,6 @@
 using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
 using System.Text.Json.Serialization;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi;
 
 public abstract record EventArgs(BiDi BiDi)