From 47b3e2a4696c1ab99cc51f38df245380e14a8149 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Fri, 19 Nov 2021 18:01:54 +0530 Subject: [PATCH 01/20] Add files via upload --- Test.java | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Test.java diff --git a/Test.java b/Test.java new file mode 100644 index 0000000..5e5570c --- /dev/null +++ b/Test.java @@ -0,0 +1,51 @@ + +package javacodechecker; + +public class Test { + + public static void m() { + System.exit(1); + } + public static void m2() { + Runtime.exit(1); + } + + public void notValid() throws Throwable + { + + final String CIPHER_INPUT = "ABCDEFG123456"; + KeyGenerator kG = KeyGenerator.getInstance("AES"); + SecretKey secretKey = kG.generateKey(); + byte[] byteKey = secretKey.getEncoded(); + SecretKeySpec secretKeySpec = new SecretKeySpec(byteKey, "AES"); + Cipher aesCipher = Cipher.getInstance("AES"); + aesCipher.init(Cipher.ENCRYPT_MODE, secretKeySpec); + byte[] encrypted = aesCipher.doFinal(CIPHER_INPUT.getBytes("UTF-8")); + IO.writeLine(IO.toHex(encrypted)); + } + private void inValid() throws Throwable + { + + final String CIPHER_INPUT = "ABCDEFG123456"; + KeyGenerator kGVal = KeyGenerator.getInstance("AES"); + kGVal.equals(kGVal); + SecretKey secretKey = kGVal.generateKey(); + byte[] byteKey = secretKey.getEncoded(); + SecretKeySpec secretKeySpec = new SecretKeySpec(byteKey, "AES"); + Cipher aesCipher = Cipher.getInstance("AES"); + aesCipher.init(Cipher.ENCRYPT_MODE, secretKeySpec); + byte[] encrypted = aesCipher.doFinal(CIPHER_INPUT.getBytes("UTF-8")); + IO.writeLine(IO.toHex(encrypted)); + } + + public void bad(HttpServletRequest request, HttpServletResponse response) throws Throwable { + IO.writeLine("doing some more things here after the redirect"); + IO.writeLine("doing some more things here after the redirect"); + response.sendRedirect("/test"); + IO.writeLine("doing some more things here after the redirect"); + } + + +} + + From f073dec8ab40019109eead7fe43f06677753e21a Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Fri, 19 Nov 2021 18:03:58 +0530 Subject: [PATCH 02/20] Delete Test.java --- Test.java | 51 --------------------------------------------------- 1 file changed, 51 deletions(-) delete mode 100644 Test.java diff --git a/Test.java b/Test.java deleted file mode 100644 index 5e5570c..0000000 --- a/Test.java +++ /dev/null @@ -1,51 +0,0 @@ - -package javacodechecker; - -public class Test { - - public static void m() { - System.exit(1); - } - public static void m2() { - Runtime.exit(1); - } - - public void notValid() throws Throwable - { - - final String CIPHER_INPUT = "ABCDEFG123456"; - KeyGenerator kG = KeyGenerator.getInstance("AES"); - SecretKey secretKey = kG.generateKey(); - byte[] byteKey = secretKey.getEncoded(); - SecretKeySpec secretKeySpec = new SecretKeySpec(byteKey, "AES"); - Cipher aesCipher = Cipher.getInstance("AES"); - aesCipher.init(Cipher.ENCRYPT_MODE, secretKeySpec); - byte[] encrypted = aesCipher.doFinal(CIPHER_INPUT.getBytes("UTF-8")); - IO.writeLine(IO.toHex(encrypted)); - } - private void inValid() throws Throwable - { - - final String CIPHER_INPUT = "ABCDEFG123456"; - KeyGenerator kGVal = KeyGenerator.getInstance("AES"); - kGVal.equals(kGVal); - SecretKey secretKey = kGVal.generateKey(); - byte[] byteKey = secretKey.getEncoded(); - SecretKeySpec secretKeySpec = new SecretKeySpec(byteKey, "AES"); - Cipher aesCipher = Cipher.getInstance("AES"); - aesCipher.init(Cipher.ENCRYPT_MODE, secretKeySpec); - byte[] encrypted = aesCipher.doFinal(CIPHER_INPUT.getBytes("UTF-8")); - IO.writeLine(IO.toHex(encrypted)); - } - - public void bad(HttpServletRequest request, HttpServletResponse response) throws Throwable { - IO.writeLine("doing some more things here after the redirect"); - IO.writeLine("doing some more things here after the redirect"); - response.sendRedirect("/test"); - IO.writeLine("doing some more things here after the redirect"); - } - - -} - - From 059b2040d7ece4e18e9752c43379a4a5914850fd Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Fri, 19 Nov 2021 18:04:19 +0530 Subject: [PATCH 03/20] Add files via upload --- src/main/java/Test.java | 51 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 src/main/java/Test.java diff --git a/src/main/java/Test.java b/src/main/java/Test.java new file mode 100644 index 0000000..5e5570c --- /dev/null +++ b/src/main/java/Test.java @@ -0,0 +1,51 @@ + +package javacodechecker; + +public class Test { + + public static void m() { + System.exit(1); + } + public static void m2() { + Runtime.exit(1); + } + + public void notValid() throws Throwable + { + + final String CIPHER_INPUT = "ABCDEFG123456"; + KeyGenerator kG = KeyGenerator.getInstance("AES"); + SecretKey secretKey = kG.generateKey(); + byte[] byteKey = secretKey.getEncoded(); + SecretKeySpec secretKeySpec = new SecretKeySpec(byteKey, "AES"); + Cipher aesCipher = Cipher.getInstance("AES"); + aesCipher.init(Cipher.ENCRYPT_MODE, secretKeySpec); + byte[] encrypted = aesCipher.doFinal(CIPHER_INPUT.getBytes("UTF-8")); + IO.writeLine(IO.toHex(encrypted)); + } + private void inValid() throws Throwable + { + + final String CIPHER_INPUT = "ABCDEFG123456"; + KeyGenerator kGVal = KeyGenerator.getInstance("AES"); + kGVal.equals(kGVal); + SecretKey secretKey = kGVal.generateKey(); + byte[] byteKey = secretKey.getEncoded(); + SecretKeySpec secretKeySpec = new SecretKeySpec(byteKey, "AES"); + Cipher aesCipher = Cipher.getInstance("AES"); + aesCipher.init(Cipher.ENCRYPT_MODE, secretKeySpec); + byte[] encrypted = aesCipher.doFinal(CIPHER_INPUT.getBytes("UTF-8")); + IO.writeLine(IO.toHex(encrypted)); + } + + public void bad(HttpServletRequest request, HttpServletResponse response) throws Throwable { + IO.writeLine("doing some more things here after the redirect"); + IO.writeLine("doing some more things here after the redirect"); + response.sendRedirect("/test"); + IO.writeLine("doing some more things here after the redirect"); + } + + +} + + From 8662fdb7cad467cc9014586bf6a53c8c3c709801 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:03:26 +0530 Subject: [PATCH 04/20] Add files via upload --- AvoidThrowingGenericException.java.URL | 6 ++++++ ...ensitive_Data_Serializable__serializable_01_bad.java.URL | 6 ++++++ ...sitive_Data_Serializable__serializable_01_good1.java.URL | 6 ++++++ ...sitive_Data_Serializable__serializable_01_good2.java.URL | 6 ++++++ ...ensitive_Data_Serializable__serializable_Helper.java.URL | 6 ++++++ UseBreakInSwitch.java.URL | 6 ++++++ 6 files changed, 36 insertions(+) create mode 100644 AvoidThrowingGenericException.java.URL create mode 100644 CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL create mode 100644 CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL create mode 100644 CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL create mode 100644 CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL create mode 100644 UseBreakInSwitch.java.URL diff --git a/AvoidThrowingGenericException.java.URL b/AvoidThrowingGenericException.java.URL new file mode 100644 index 0000000..dd506cd --- /dev/null +++ b/AvoidThrowingGenericException.java.URL @@ -0,0 +1,6 @@ +[InternetShortcut] +URL=https://github.com/spyd3r98/demo/blob/main/AvoidThrowingGenericException.java +IDList= +HotKey=0 +IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\afFjZEeQY0kCrXxSJcbNZw==.ico +IconIndex=0 diff --git a/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL new file mode 100644 index 0000000..9e36a1d --- /dev/null +++ b/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL @@ -0,0 +1,6 @@ +[InternetShortcut] +URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java +IDList= +HotKey=0 +IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\1jMXan76SrBnJLzWTvje_w==.ico +IconIndex=0 diff --git a/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL new file mode 100644 index 0000000..de18a17 --- /dev/null +++ b/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL @@ -0,0 +1,6 @@ +[InternetShortcut] +URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java +IDList= +HotKey=0 +IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\f6_ZsMcAZi5IL0tsq8gNKA==.ico +IconIndex=0 diff --git a/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL new file mode 100644 index 0000000..c972678 --- /dev/null +++ b/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL @@ -0,0 +1,6 @@ +[InternetShortcut] +URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java +IDList= +HotKey=0 +IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\GOThhqEZ10fqEet2J+Ybng==.ico +IconIndex=0 diff --git a/CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL new file mode 100644 index 0000000..c6c9e0a --- /dev/null +++ b/CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL @@ -0,0 +1,6 @@ +[InternetShortcut] +URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_Helper.java +IDList= +HotKey=0 +IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\56VT3q4sXlvnO6rRO9VJdw==.ico +IconIndex=0 diff --git a/UseBreakInSwitch.java.URL b/UseBreakInSwitch.java.URL new file mode 100644 index 0000000..eef5dd3 --- /dev/null +++ b/UseBreakInSwitch.java.URL @@ -0,0 +1,6 @@ +[InternetShortcut] +URL=https://github.com/spyd3r98/demo/blob/main/UseBreakInSwitch.java +IDList= +HotKey=0 +IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\oKVt_1adOgTA2nrvEXIJVA==.ico +IconIndex=0 From 4757d9ae5e4df451994f9f76a060d01f50f65050 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:53:08 +0530 Subject: [PATCH 05/20] Delete AvoidThrowingGenericException.java.URL --- AvoidThrowingGenericException.java.URL | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 AvoidThrowingGenericException.java.URL diff --git a/AvoidThrowingGenericException.java.URL b/AvoidThrowingGenericException.java.URL deleted file mode 100644 index dd506cd..0000000 --- a/AvoidThrowingGenericException.java.URL +++ /dev/null @@ -1,6 +0,0 @@ -[InternetShortcut] -URL=https://github.com/spyd3r98/demo/blob/main/AvoidThrowingGenericException.java -IDList= -HotKey=0 -IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\afFjZEeQY0kCrXxSJcbNZw==.ico -IconIndex=0 From 88f739b424fcfc585763f1c224118ec5666fc871 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:53:22 +0530 Subject: [PATCH 06/20] Delete CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL --- ...ensitive_Data_Serializable__serializable_01_bad.java.URL | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL diff --git a/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL deleted file mode 100644 index 9e36a1d..0000000 --- a/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java.URL +++ /dev/null @@ -1,6 +0,0 @@ -[InternetShortcut] -URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_01_bad.java -IDList= -HotKey=0 -IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\1jMXan76SrBnJLzWTvje_w==.ico -IconIndex=0 From fd6e71f42ac0e351545faedc17de5dc1ef45041a Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:53:34 +0530 Subject: [PATCH 07/20] Delete CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL --- ...sitive_Data_Serializable__serializable_01_good1.java.URL | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL diff --git a/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL deleted file mode 100644 index de18a17..0000000 --- a/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java.URL +++ /dev/null @@ -1,6 +0,0 @@ -[InternetShortcut] -URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_01_good1.java -IDList= -HotKey=0 -IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\f6_ZsMcAZi5IL0tsq8gNKA==.ico -IconIndex=0 From e059698ffb2cdf7eeada3bf086f6e8806eaa3d9e Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:53:43 +0530 Subject: [PATCH 08/20] Delete CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL --- ...sitive_Data_Serializable__serializable_01_good2.java.URL | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL diff --git a/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL deleted file mode 100644 index c972678..0000000 --- a/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java.URL +++ /dev/null @@ -1,6 +0,0 @@ -[InternetShortcut] -URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_01_good2.java -IDList= -HotKey=0 -IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\GOThhqEZ10fqEet2J+Ybng==.ico -IconIndex=0 From 2e43bdeb44b4bd4f4c8ff180236bff0ba30455ac Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:53:54 +0530 Subject: [PATCH 09/20] Delete CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL --- ...ensitive_Data_Serializable__serializable_Helper.java.URL | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL diff --git a/CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL b/CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL deleted file mode 100644 index c6c9e0a..0000000 --- a/CWE499_Sensitive_Data_Serializable__serializable_Helper.java.URL +++ /dev/null @@ -1,6 +0,0 @@ -[InternetShortcut] -URL=https://github.com/spyd3r98/demo/blob/main/CWE499_Sensitive_Data_Serializable__serializable_Helper.java -IDList= -HotKey=0 -IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\56VT3q4sXlvnO6rRO9VJdw==.ico -IconIndex=0 From 448088d8d324a977782db3305a83161981da8ffa Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:54:04 +0530 Subject: [PATCH 10/20] Delete UseBreakInSwitch.java.URL --- UseBreakInSwitch.java.URL | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 UseBreakInSwitch.java.URL diff --git a/UseBreakInSwitch.java.URL b/UseBreakInSwitch.java.URL deleted file mode 100644 index eef5dd3..0000000 --- a/UseBreakInSwitch.java.URL +++ /dev/null @@ -1,6 +0,0 @@ -[InternetShortcut] -URL=https://github.com/spyd3r98/demo/blob/main/UseBreakInSwitch.java -IDList= -HotKey=0 -IconFile=C:\Users\Shantanu\AppData\Local\Mozilla\Firefox\Profiles\s8izagpf.default-release\shortcutCache\oKVt_1adOgTA2nrvEXIJVA==.ico -IconIndex=0 From 065fe4540e7855af4b28ab590e4070caf2ed46e5 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:57:30 +0530 Subject: [PATCH 11/20] Create sensetiveData.java --- src/main/java/sensetiveData.java | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 src/main/java/sensetiveData.java diff --git a/src/main/java/sensetiveData.java b/src/main/java/sensetiveData.java new file mode 100644 index 0000000..b32f77e --- /dev/null +++ b/src/main/java/sensetiveData.java @@ -0,0 +1,6 @@ +package javacodechecker; + +public class sensetiveData implements Serializable{ + + private static String passwordhash = "456"; +} From 45ca55ebefd3003af00e869590294e4dab0b0300 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 12:59:02 +0530 Subject: [PATCH 12/20] Create sensetiveData2.java --- src/main/java/sensetiveData2.java | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 src/main/java/sensetiveData2.java diff --git a/src/main/java/sensetiveData2.java b/src/main/java/sensetiveData2.java new file mode 100644 index 0000000..12c9d7f --- /dev/null +++ b/src/main/java/sensetiveData2.java @@ -0,0 +1,6 @@ +package javacodechecker; + +public class sensetiveData2 implements Serializable{ + + private Transient String passwordhash = "789"; +} From 01b36ba9a5543d92e40c995c8b026549802a98e2 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 13:50:03 +0530 Subject: [PATCH 13/20] Update and rename sensetiveData2.java to sensetive.java --- src/main/java/{sensetiveData2.java => sensetive.java} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename src/main/java/{sensetiveData2.java => sensetive.java} (60%) diff --git a/src/main/java/sensetiveData2.java b/src/main/java/sensetive.java similarity index 60% rename from src/main/java/sensetiveData2.java rename to src/main/java/sensetive.java index 12c9d7f..eb533a7 100644 --- a/src/main/java/sensetiveData2.java +++ b/src/main/java/sensetive.java @@ -1,6 +1,6 @@ package javacodechecker; -public class sensetiveData2 implements Serializable{ +public class sensetive implements Serializable{ private Transient String passwordhash = "789"; } From fcbd91b93a17bbb9d507fd276f0daa2d5e8e6f48 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 14:52:48 +0530 Subject: [PATCH 14/20] Update sensetive.java --- src/main/java/sensetive.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/sensetive.java b/src/main/java/sensetive.java index eb533a7..2627404 100644 --- a/src/main/java/sensetive.java +++ b/src/main/java/sensetive.java @@ -3,4 +3,6 @@ public class sensetive implements Serializable{ private Transient String passwordhash = "789"; + + System.out.println(passwordhash); } From 60c8312347cb08080a3baef8bc66495697a8d14c Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Tue, 23 Nov 2021 14:53:17 +0530 Subject: [PATCH 15/20] Delete sensetiveData.java --- src/main/java/sensetiveData.java | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 src/main/java/sensetiveData.java diff --git a/src/main/java/sensetiveData.java b/src/main/java/sensetiveData.java deleted file mode 100644 index b32f77e..0000000 --- a/src/main/java/sensetiveData.java +++ /dev/null @@ -1,6 +0,0 @@ -package javacodechecker; - -public class sensetiveData implements Serializable{ - - private static String passwordhash = "456"; -} From 6e18eab3eb68b32144eb4f7e6574e66148c24acc Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Wed, 24 Nov 2021 13:28:03 +0530 Subject: [PATCH 16/20] Add files via upload --- .../java/MissingBreakStatementInSwitch.java | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 src/main/java/MissingBreakStatementInSwitch.java diff --git a/src/main/java/MissingBreakStatementInSwitch.java b/src/main/java/MissingBreakStatementInSwitch.java new file mode 100644 index 0000000..55b644e --- /dev/null +++ b/src/main/java/MissingBreakStatementInSwitch.java @@ -0,0 +1,48 @@ +package com.acellere.corona.javacodechecker.ci.checkers; + +import com.acellere.corona.cmx.mod.cmn.Severity; +import com.acellere.corona.cmx.msg.data.auxmod.CodeIssueModel; +import com.acellere.corona.commons.cast.ObjCaster; +import com.acellere.corona.javaparsercore.ParseContext; +import com.acellere.corona.javaparsercore.ci.ICodeIssuePublisher; +import com.acellere.corona.javaparsercore.exceptions.ParserException; +import com.github.javaparser.ast.Node; +import com.github.javaparser.ast.stmt.*; + +import java.util.List; + + +public class MissingBreakStatementInSwitch extends BaseChecker{ + + @Override + protected void handleVisit(Node node, ParseContext context, ICodeIssuePublisher codeIssuePublisher) throws ParserException { + if(node instanceof SwitchStmt){ + SwitchStmt switchStmt = ObjCaster.castNode(SwitchStmt.class,node); + List entries = switchStmt.getEntries(); + if(entries != null){ + CheckingEntriesInSwitch(entries,node,context,codeIssuePublisher); + } + } + } + + private void CheckingEntriesInSwitch(List entries, Node node, ParseContext context, ICodeIssuePublisher codeIssuePublisher){ + for(SwitchEntryStmt switchEntryStmt:entries){ + int index = entries.indexOf(switchEntryStmt); + if(!(switchEntryStmt.getStmts().isEmpty()) && index != entries.size()-1){ + List statements = switchEntryStmt.getStmts(); + for(Statement statement:statements){ + int indexOfStmt = statements.indexOf(statement); + if(!(statement instanceof BreakStmt) && (indexOfStmt == statements.size()-1) && !(statement instanceof ReturnStmt)){ + publishCodeIssue(node, context, codeIssuePublisher); + } + } + + } + } + } + + private void publishCodeIssue(Node node, ParseContext context, ICodeIssuePublisher codeIssuePublisher) { + codeIssuePublisher.publish(new CodeIssueModel(context.getCu().getCuFile(), node.getRange().begin.line, + Severity.medium, "Missing Break Statement In Switch", CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH)); + } +} From 399e54d675353d1b24994c7eb851e1d1c6d819d5 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Wed, 24 Nov 2021 13:28:26 +0530 Subject: [PATCH 17/20] Delete MissingBreakStatementInSwitch.java --- .../java/MissingBreakStatementInSwitch.java | 48 ------------------- 1 file changed, 48 deletions(-) delete mode 100644 src/main/java/MissingBreakStatementInSwitch.java diff --git a/src/main/java/MissingBreakStatementInSwitch.java b/src/main/java/MissingBreakStatementInSwitch.java deleted file mode 100644 index 55b644e..0000000 --- a/src/main/java/MissingBreakStatementInSwitch.java +++ /dev/null @@ -1,48 +0,0 @@ -package com.acellere.corona.javacodechecker.ci.checkers; - -import com.acellere.corona.cmx.mod.cmn.Severity; -import com.acellere.corona.cmx.msg.data.auxmod.CodeIssueModel; -import com.acellere.corona.commons.cast.ObjCaster; -import com.acellere.corona.javaparsercore.ParseContext; -import com.acellere.corona.javaparsercore.ci.ICodeIssuePublisher; -import com.acellere.corona.javaparsercore.exceptions.ParserException; -import com.github.javaparser.ast.Node; -import com.github.javaparser.ast.stmt.*; - -import java.util.List; - - -public class MissingBreakStatementInSwitch extends BaseChecker{ - - @Override - protected void handleVisit(Node node, ParseContext context, ICodeIssuePublisher codeIssuePublisher) throws ParserException { - if(node instanceof SwitchStmt){ - SwitchStmt switchStmt = ObjCaster.castNode(SwitchStmt.class,node); - List entries = switchStmt.getEntries(); - if(entries != null){ - CheckingEntriesInSwitch(entries,node,context,codeIssuePublisher); - } - } - } - - private void CheckingEntriesInSwitch(List entries, Node node, ParseContext context, ICodeIssuePublisher codeIssuePublisher){ - for(SwitchEntryStmt switchEntryStmt:entries){ - int index = entries.indexOf(switchEntryStmt); - if(!(switchEntryStmt.getStmts().isEmpty()) && index != entries.size()-1){ - List statements = switchEntryStmt.getStmts(); - for(Statement statement:statements){ - int indexOfStmt = statements.indexOf(statement); - if(!(statement instanceof BreakStmt) && (indexOfStmt == statements.size()-1) && !(statement instanceof ReturnStmt)){ - publishCodeIssue(node, context, codeIssuePublisher); - } - } - - } - } - } - - private void publishCodeIssue(Node node, ParseContext context, ICodeIssuePublisher codeIssuePublisher) { - codeIssuePublisher.publish(new CodeIssueModel(context.getCu().getCuFile(), node.getRange().begin.line, - Severity.medium, "Missing Break Statement In Switch", CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH)); - } -} From 0ae55fb00599b90b1a9b9d0d80e96f2d6f4f11ea Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Wed, 24 Nov 2021 13:29:43 +0530 Subject: [PATCH 18/20] Add files via upload --- .../java/MissingBreakStatementInSwitch.java | 143 ++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 src/main/java/MissingBreakStatementInSwitch.java diff --git a/src/main/java/MissingBreakStatementInSwitch.java b/src/main/java/MissingBreakStatementInSwitch.java new file mode 100644 index 0000000..b5a8414 --- /dev/null +++ b/src/main/java/MissingBreakStatementInSwitch.java @@ -0,0 +1,143 @@ +package javacodechecker; + +public class MissingBreakStatementInSwitch { + + public void Statement(){ + int day = 2; + int n =2; + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (day){ + + case 1: + logger.info("1"); + break; + + case 2: + logger.info("2"); + + case 3: + logger.info("3"); + break; + + default: + logger.info("4"); + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ + + case 1: + logger.info("1"); + break; + + case 2: + logger.info("2"); + + default: + logger.info("4"); + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ + + case 1: + + case 2: + logger.info("2"); + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ + + case 1: + case 2: + case 3: + case 4: + logger.info("2"); + break; + + default: + logger.info("4"); + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ + + default: + logger.info("4"); + case 1: + case 2: + case 3: + case 4: + logger.info("2"); + break; + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ + + case 1: + case 2: + case 3: + case 4: + logger.info("2"); + break; + + default: + logger.info("4"); + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ + + case 1: + case 2: + case 3: + case 4: + logger.info("2"); + + default: + logger.info("4"); + + } + double returnValue = DemoMethod(3); + } + + + public double DemoMethod(int n){ + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ + + case 1: + case 2: + return 2.0; + case 3: + return 3.0; + case 4: + logger.info("4"); + return 4.0; + default: + logger.info("5"); + return 5.0; + + } + // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ + + case 1: + case 2: + return 2.0; + case 3: + return 3.0; + case 4: + logger.info("4"); + + default: + logger.info("5"); + return 5.0; + + } + } + + +} \ No newline at end of file From edadd56d49e3b23f6938ce16e598a19ef765db28 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Wed, 24 Nov 2021 13:30:36 +0530 Subject: [PATCH 19/20] Update MissingBreakStatementInSwitch.java --- .../java/MissingBreakStatementInSwitch.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/main/java/MissingBreakStatementInSwitch.java b/src/main/java/MissingBreakStatementInSwitch.java index b5a8414..d67a0d5 100644 --- a/src/main/java/MissingBreakStatementInSwitch.java +++ b/src/main/java/MissingBreakStatementInSwitch.java @@ -5,7 +5,7 @@ public class MissingBreakStatementInSwitch { public void Statement(){ int day = 2; int n =2; - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (day){ case 1: @@ -23,7 +23,7 @@ public void Statement(){ logger.info("4"); } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ case 1: @@ -37,7 +37,7 @@ public void Statement(){ logger.info("4"); } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ case 1: @@ -46,7 +46,7 @@ public void Statement(){ logger.info("2"); } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ case 1: @@ -60,7 +60,7 @@ public void Statement(){ logger.info("4"); } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ default: @@ -73,7 +73,7 @@ public void Statement(){ break; } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ case 1: @@ -87,7 +87,7 @@ public void Statement(){ logger.info("4"); } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ case 1: @@ -105,7 +105,7 @@ public void Statement(){ public double DemoMethod(int n){ - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH/no-detect + switch (n){ case 1: @@ -121,7 +121,7 @@ public double DemoMethod(int n){ return 5.0; } - // EMB-ISSUE: CodeIssueNames.MISSING_BREAK_STATEMENT_IN_SWITCH + switch (n){ case 1: @@ -140,4 +140,4 @@ public double DemoMethod(int n){ } -} \ No newline at end of file +} From 6896f6b08b6bf55c669f6bf01a40e5f970f40b43 Mon Sep 17 00:00:00 2001 From: shantu98 <94452752+shantu98@users.noreply.github.com> Date: Fri, 3 Dec 2021 20:33:18 +0530 Subject: [PATCH 20/20] Update AvoidThrowingGenericException.java --- src/main/java/AvoidThrowingGenericException.java | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/main/java/AvoidThrowingGenericException.java b/src/main/java/AvoidThrowingGenericException.java index 35cc888..eb1e922 100644 --- a/src/main/java/AvoidThrowingGenericException.java +++ b/src/main/java/AvoidThrowingGenericException.java @@ -18,4 +18,18 @@ public void M3()throws InvocationTargetException{ public void M5()throws IOException, InvocationTargetException, SQLException{ logger.info("Throwing IOException, InvocationTargetException, SQLException"); } + try{ + Connection con = DriverManager.getConnection(mysqlUrl, "root", "password"); + Statement stmt = con.createStatement(); { + try(ResultSet rs = stmt.executeQuery("select * from MyPlayers");){ + //Retrieving the data + while(rs.next()) { + + } + } catch (SQLException e) { + e.printStackTrace(); + } + }} catch (SQLException e) { + e.printStackTrace(); + } }