[10.0] Enable more StyleCI fixers (GitLabPHP#566)

Author: GrahamCampbell

.styleci.yml

@@ -1,13 +1,20 @@
 preset: symfony
 
+risky: true
+
 enabled:
   - align_phpdoc
   - alpha_ordered_imports
   - array_indentation
   - const_visibility_required
+  - native_constant_invocation
+  - native_function_invocation
   - phpdoc_order
+  - void_return
 
 disabled:
+  - native_constant_invocation_symfony
+  - native_function_invocation_symfony
   - no_superfluous_phpdoc_tags_symfony
   - phpdoc_to_comment
   - phpdoc_var_without_name

src/Api/AbstractApi.php

@@ -357,7 +357,7 @@ private static function addJsonContentType(array $headers)
     private static function tryFopen(string $filename, string $mode)
     {
         $ex = null;
-        \set_error_handler(function () use ($filename, $mode, &$ex) {
+        \set_error_handler(function () use ($filename, $mode, &$ex): void {
             $ex = new RuntimeException(\sprintf(
                 'Unable to open %s using mode %s: %s',
                 $filename,
@@ -390,7 +390,7 @@ private static function guessFileContentType(string $file)
             return ResponseMediator::STREAM_CONTENT_TYPE;
         }
 
-        $finfo = new \finfo(FILEINFO_MIME_TYPE);
+        $finfo = new \finfo(\FILEINFO_MIME_TYPE);
         $type = $finfo->file($file);
 
         return false !== $type ? $type : ResponseMediator::STREAM_CONTENT_TYPE;

src/HttpClient/Builder.php

@@ -159,7 +159,7 @@ public function getUriFactory()
      *
      * @return void
      */
-    public function addPlugin(Plugin $plugin)
+    public function addPlugin(Plugin $plugin): void
     {
         $this->plugins[] = $plugin;
         $this->pluginClient = null;
@@ -172,7 +172,7 @@ public function addPlugin(Plugin $plugin)
      *
      * @return void
      */
-    public function removePlugin(string $fqcn)
+    public function removePlugin(string $fqcn): void
     {
         foreach ($this->plugins as $idx => $plugin) {
             if ($plugin instanceof $fqcn) {
@@ -190,7 +190,7 @@ public function removePlugin(string $fqcn)
      *
      * @return void
      */
-    public function addCache(CacheItemPoolInterface $cachePool, array $config = [])
+    public function addCache(CacheItemPoolInterface $cachePool, array $config = []): void
     {
         if (!isset($config['cache_key_generator'])) {
             $config['cache_key_generator'] = new HeaderCacheKeyGenerator(['Authorization', 'Cookie', 'Accept', 'Content-type']);
@@ -205,7 +205,7 @@ public function addCache(CacheItemPoolInterface $cachePool, array $config = [])
      *
      * @return void
      */
-    public function removeCache()
+    public function removeCache(): void
     {
         $this->cachePlugin = null;
         $this->pluginClient = null;

src/HttpClient/Plugin/History.php

@@ -39,7 +39,7 @@ public function getLastResponse()
      *
      * @return void
      */
-    public function addSuccess(RequestInterface $request, ResponseInterface $response)
+    public function addSuccess(RequestInterface $request, ResponseInterface $response): void
     {
         $this->lastResponse = $response;
     }
@@ -52,7 +52,7 @@ public function addSuccess(RequestInterface $request, ResponseInterface $respons
      *
      * @return void
      */
-    public function addFailure(RequestInterface $request, ClientExceptionInterface $exception)
+    public function addFailure(RequestInterface $request, ClientExceptionInterface $exception): void
     {
     }
 }

src/HttpClient/Util/QueryStringBuilder.php

@@ -22,6 +22,6 @@ public static function build(array $query)
             return '';
         }
 
-        return \sprintf('?%s', \http_build_query($query, '', '&', PHP_QUERY_RFC3986));
+        return \sprintf('?%s', \http_build_query($query, '', '&', \PHP_QUERY_RFC3986));
     }
 }

src/Model/AbstractModel.php

@@ -91,7 +91,7 @@ public function getData()
      *
      * @return void
      */
-    public function __set(string $property, $value)
+    public function __set(string $property, $value): void
     {
         throw new RuntimeException('Model properties are immutable');
     }
@@ -106,7 +106,7 @@ public function __set(string $property, $value)
     public function __get(string $property)
     {
         if (!\in_array($property, static::$properties, true)) {
-            throw new RuntimeException(\sprintf('Property "%s" does not exist for %s object', $property, \get_called_class()));
+            throw new RuntimeException(\sprintf('Property "%s" does not exist for %s object', $property, static::class));
         }
 
         if (isset($this->data[$property])) {

src/ResultPager.php

@@ -204,7 +204,7 @@ public function fetchLast()
      *
      * @return void
      */
-    private function postFetch()
+    private function postFetch(): void
     {
         $response = $this->client->getLastResponse();
 

tests/Api/DeployKeysTest.php

@@ -11,7 +11,7 @@ class DeployKeysTest extends TestCase
     /**
      * @test
      */
-    public function shouldGetAllDeployKeys()
+    public function shouldGetAllDeployKeys(): void
     {
         $expectedArray = $this->getMultipleDeployKeysData();
 

tests/Api/DeploymentsTest.php

@@ -11,7 +11,7 @@ class DeploymentsTest extends TestCase
     /**
      * @test
      */
-    public function shouldGetAllDeployments()
+    public function shouldGetAllDeployments(): void
     {
         $expectedArray = [
             [
@@ -155,7 +155,7 @@ public function shouldGetAllDeployments()
     /**
      * @test
      */
-    public function shouldShowDeployment()
+    public function shouldShowDeployment(): void
     {
         $expectedArray = [
             [

tests/Api/EnvironmentsTest.php

@@ -11,7 +11,7 @@ class EnvironmentsTest extends TestCase
     /**
      * @test
      */
-    public function shouldGetAllEnvironments()
+    public function shouldGetAllEnvironments(): void
     {
         $expectedArray = [
             [
@@ -37,7 +37,7 @@ public function shouldGetAllEnvironments()
     }
 
     /** @test */
-    public function shouldFilterEnvironmentByName()
+    public function shouldFilterEnvironmentByName(): void
     {
         $expected = [
             [
@@ -58,7 +58,7 @@ public function shouldFilterEnvironmentByName()
     /**
      * @test
      */
-    public function shouldGetSingleEnvironment()
+    public function shouldGetSingleEnvironment(): void
     {
         $expected = [
             'id' => 1,
@@ -137,7 +137,7 @@ public function shouldGetSingleEnvironment()
     /**
      * @test
      */
-    public function shouldCreateEnvironment()
+    public function shouldCreateEnvironment(): void
     {
         $expectedArray = [
             [
@@ -165,7 +165,7 @@ public function shouldCreateEnvironment()
     /**
      * @test
      */
-    public function shouldRemoveEnvironment()
+    public function shouldRemoveEnvironment(): void
     {
         $expectedBool = true;
 
@@ -180,7 +180,7 @@ public function shouldRemoveEnvironment()
     /**
      * @test
      */
-    public function shouldStopEnvironment()
+    public function shouldStopEnvironment(): void
     {
         $expectedBool = true;