Skip to content

Commit 8f92051

Browse files
committed
Merge remote-tracking branch 'origin/2.0-wl9970' into 2.0
1 parent f6cab7f commit 8f92051

File tree

2 files changed

+9
-19
lines changed

2 files changed

+9
-19
lines changed

devapi/tests/session-t.cc

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -361,11 +361,6 @@ TEST_F(Sess, ssl_session)
361361
//Test if ssl is enabled using cipher
362362
auto check_ssl_impl = [](mysqlx::XSession &sess, bool enable, int line)
363363
{
364-
mysqlx::XSession sess(SessionSettings::PORT, get_port(),
365-
SessionSettings::USER,get_user(),
366-
SessionSettings::PWD, get_password() ? get_password() : NULL ,
367-
SessionSettings::SSL_ENABLE, true);
368-
369364
SqlResult res = sess.bindToDefaultShard().sql("SHOW STATUS LIKE 'mysqlx_ssl_cipher'").execute();
370365

371366
auto row = res.fetchOne();
@@ -529,12 +524,4 @@ TEST_F(Sess, ssl_session)
529524

530525
}
531526

532-
533-
//Enable SSL
534-
uri << "/?ssl-enable";
535-
{
536-
mysqlx::XSession sess(uri.str());
537-
538-
check_ssl(sess, true); }
539-
540527
}

xapi/tests/xapi-t.cc

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -778,16 +778,19 @@ TEST_F(xapi, conn_string_test)
778778
}
779779
cout << "Connected to xplugin..." << endl;
780780

781-
RESULT_CHECK(stmt = mysqlx_sql_new(local_sess, "SELECT 'foo'", MYSQLX_NULL_TERMINATED));
781+
RESULT_CHECK(stmt = mysqlx_sql_new(local_sess, "SHOW STATUS LIKE 'mysqlx_ssl_cipher'", MYSQLX_NULL_TERMINATED));
782782
CRUD_CHECK(res = mysqlx_execute(stmt), stmt);
783783

784-
while ((row = mysqlx_row_fetch_one(res)) != NULL)
784+
if ((row = mysqlx_row_fetch_one(res)) != NULL)
785785
{
786-
char data[32];
786+
char data[128] = { 0 };
787787
size_t data_len = sizeof(data);
788-
EXPECT_EQ(RESULT_OK, mysqlx_get_bytes(row, 0, 0, data, &data_len));
789-
EXPECT_STREQ("foo", data);
790-
cout << "ROW DATA: " << data << " " << endl;
788+
EXPECT_EQ(RESULT_OK, mysqlx_get_bytes(row, 1, 0, data, &data_len));
789+
if (ssl_enable)
790+
{
791+
cout << "SSL Cipher: " << data << endl;
792+
EXPECT_TRUE(data_len > 1);
793+
}
791794
}
792795

793796
mysqlx_session_close(local_sess);

0 commit comments

Comments
 (0)