Merged PR 101370: Remove default report settings

Remove default report settings

Author: Shahak Yosef

dist/powerbi-client.d.ts

@@ -1,4 +1,4 @@
-/*! powerbi-client v2.13.3 | (c) 2016 Microsoft Corporation MIT */
+/*! powerbi-client v2.14.0 | (c) 2016 Microsoft Corporation MIT */
 declare module "util" {
     import { HttpPostMessage } from 'http-post-message';
     /**
@@ -102,14 +102,6 @@ declare module "config" {
     };
     export default config;
 }
-declare module "defaults" {
-    import * as models from 'powerbi-models';
-    /** @hidden */
-    export abstract class Defaults {
-        static defaultSettings: models.ISettings;
-        static defaultQnaSettings: models.IQnaSettings;
-    }
-}
 declare module "errors" {
     export let APINotSupportedForRDLError: string;
     export let EmbedUrlNotSupported: string;
@@ -1216,6 +1208,13 @@ declare module "report" {
         private isMobileSettings(settings);
     }
 }
+declare module "defaults" {
+    import * as models from 'powerbi-models';
+    /** @hidden */
+    export abstract class Defaults {
+        static defaultQnaSettings: models.IQnaSettings;
+    }
+}
 declare module "create" {
     import * as service from "service";
     import * as models from 'powerbi-models';

dist/powerbi.js

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-client",
-  "version": "2.13.3",
+  "version": "2.14.0",
   "description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
   "main": "dist/powerbi.js",
   "typings": "dist/powerbi-client.d.ts",

dist/powerbi.min.js

@@ -1,6 +1,6 @@
 /** @ignore *//** */
 const config = {
-  version: '2.13.3',
+  version: '2.14.0',
   type: 'js'
 };
 

package.json

@@ -2,10 +2,6 @@ import * as models from 'powerbi-models';
 
 /** @hidden */  
 export abstract class Defaults {
-  public static defaultSettings: models.ISettings = {
-    filterPaneEnabled: true
-  };
-
   public static defaultQnaSettings: models.IQnaSettings = {
     filterPaneEnabled: false
   };

src/config.ts

@@ -2,7 +2,6 @@ import * as utils from './util';
 import * as service from './service';
 import * as sdkConfig from './config';
 import * as models from 'powerbi-models';
-import { Defaults } from './defaults';
 import { EmbedUrlNotSupported } from './errors';
 
 declare global {

src/defaults.ts

@@ -5,7 +5,6 @@ import * as utils from './util';
 import * as errors from './errors';
 import { IFilterable } from './ifilterable';
 import { Page } from './page';
-import { Defaults } from './defaults';
 import { IReportLoadConfiguration } from 'powerbi-models';
 import { BookmarksManager } from './bookmarksManager';
 
@@ -391,8 +390,8 @@ export class Report extends embed.Embed implements IReportNode, IFilterable {
     let navContentPaneEnabledAttribute = this.element.getAttribute(Report.navContentPaneEnabledAttribute);
 
     let elementAttrSettings: embed.IEmbedSettings = {
-      filterPaneEnabled: (filterPaneEnabledAttribute == null) ? Defaults.defaultSettings.filterPaneEnabled : (filterPaneEnabledAttribute !== "false"),
-      navContentPaneEnabled: (navContentPaneEnabledAttribute == null) ? Defaults.defaultSettings.navContentPaneEnabled : (navContentPaneEnabledAttribute !== "false")
+      filterPaneEnabled: (filterPaneEnabledAttribute == null) ? undefined : (filterPaneEnabledAttribute !== "false"),
+      navContentPaneEnabled: (navContentPaneEnabledAttribute == null) ? undefined : (navContentPaneEnabledAttribute !== "false")
     };
 
     // Set the settings back into the config.