Fix SPIFFS path length check, add notes about FSInfo structure (esp8266#1273)

Author: igrr

cores/esp8266/spiffs_api.cpp

@@ -495,7 +495,7 @@ static bool isSpiffsFilenameValid(const char* name) {
     if (name == nullptr)
         return false;
     auto len = strlen(name);
-    return len > 0 && len <= SPIFFS_OBJ_NAME_LEN;
+    return len > 0 && len < SPIFFS_OBJ_NAME_LEN;
 }
 
 // these symbols should be defined in the linker script for each flash layout

doc/filesystem.md

@@ -169,8 +169,14 @@ struct FSInfo {
 };
 ```
 
-This is the structure which may be filled using FS::info method. Field names
-are self-explanatory.
+This is the structure which may be filled using FS::info method.
+- `totalBytes` — total size of useful data on the file system
+- `usedBytes` — number of bytes used by files
+- `blockSize` — SPIFFS block size
+- `pageSize` — SPIFFS logical page size
+- `maxOpenFiles` — max number of files which may be open simultaneously
+- `maxPathLength` — max file name length (including one byte for zero termination)
+
 
 ## Directory object (Dir)