Fix failing tests for empty cells in csv (SpartnerNL#2754)

Author: patrickbrouwers

tests/Concerns/WithStrictNullComparisonTest.php

@@ -92,4 +92,43 @@ public function headings(): array
 
         $this->assertEquals($expected, $actual);
     }
+
+    /**
+     * @test
+     */
+    public function exports_empty_cells()
+    {
+        $export = new class implements FromCollection, WithStrictNullComparison {
+            use Exportable;
+
+            /**
+             * @return Collection
+             */
+            public function collection()
+            {
+                return collect([
+                    ['a1', '', '', 'd1', ''],
+                    ['a2', '', '', 'd2', ''],
+                ]);
+            }
+        };
+
+        $response = $export->store('empty-cells.csv');
+
+        $this->assertTrue($response);
+
+        $file   = __DIR__ . '/../Data/Disks/Local/empty-cells.csv';
+        $actual = $this->readAsArray($file, 'Csv');
+
+        $expected = [
+            ['a1', null, null, 'd1'],
+            ['a2', null, null, 'd2'],
+        ];
+
+        $this->assertEquals($expected, $actual);
+
+        $contents = file_get_contents($file);
+        $this->assertStringContains('"a1","","","d1",""', $contents);
+        $this->assertStringContains('"a2","","","d2",""', $contents);
+    }
 }

tests/ExcelTest.php

@@ -163,8 +163,8 @@ public function can_store_csv_export_with_custom_settings()
             public function collection()
             {
                 return collect([
-                    ['A1', 'B1', '', ''],
-                    ['A2', 'B2', '', ''],
+                    ['A1', 'B1'],
+                    ['A2', 'B2'],
                 ]);
             }
 
@@ -188,8 +188,8 @@ public function getCsvSettings(): array
         $contents = file_get_contents(__DIR__ . '/Data/Disks/Local/filename.csv');
 
         $this->assertStringContains('sep=;', $contents);
-        $this->assertStringContains('"A1";"B1";;', $contents);
-        $this->assertStringContains('"A2";"B2";;', $contents);
+        $this->assertStringContains('"A1";"B1"', $contents);
+        $this->assertStringContains('"A2";"B2"', $contents);
     }
 
     /**