Fix KHR_maintenance5 pipeline flags being put on wrong pNext chain

baldurk · baldurk · commit 26f273226888 · 2025-04-07T16:53:24.000+01:00
diff --git a/renderdoc/driver/vulkan/vk_shader_cache.cpp b/renderdoc/driver/vulkan/vk_shader_cache.cpp
@@ -1071,12 +1071,12 @@ void VulkanShaderCache::MakeGraphicsPipelineInfo(VkGraphicsPipelineCreateInfo &p
   {
     createFlags.flags = flags;
 
-    createFlags.pNext = rs.pNext;
-    rs.pNext = &createFlags;
+    createFlags.pNext = ret.pNext;
+    ret.pNext = &createFlags;
   }
   else
   {
-    rs.flags = (uint32_t)flags;
+    createFlags.flags = (uint32_t)flags;
   }
 
   pipeCreateInfo = ret;

Original file line number	Diff line number	Diff line change
`@@ -1071,12 +1071,12 @@ void VulkanShaderCache::MakeGraphicsPipelineInfo(VkGraphicsPipelineCreateInfo &p`
`1071`	`1071`	`{`
`1072`	`1072`	`createFlags.flags = flags;`
`1073`	`1073`
`1074`		`- createFlags.pNext = rs.pNext;`
`1075`		`- rs.pNext = &createFlags;`
	`1074`	`+ createFlags.pNext = ret.pNext;`
	`1075`	`+ ret.pNext = &createFlags;`
`1076`	`1076`	`}`
`1077`	`1077`	`else`
`1078`	`1078`	`{`
`1079`		`- rs.flags = (uint32_t)flags;`
	`1079`	`+ createFlags.flags = (uint32_t)flags;`
`1080`	`1080`	`}`
`1081`	`1081`
`1082`	`1082`	`pipeCreateInfo = ret;`