Apply framebuffer usage from dynamic rendering to secondary cmd draws

baldurk · baldurk · commit def94221638c · 2025-04-09T11:36:54.000+01:00
diff --git a/renderdoc/driver/vulkan/wrappers/vk_cmd_funcs.cpp b/renderdoc/driver/vulkan/wrappers/vk_cmd_funcs.cpp
@@ -4890,8 +4890,7 @@ bool WrappedVulkan::Serialise_vkCmdExecuteCommands(SerialiserType &ser, VkComman
       parentCmdBufInfo.curEventID++;
 
       // should we add framebuffer usage to the child draws.
-      bool framebufferUsage = parentCmdBufInfo.state.GetRenderPass() != ResourceId() &&
-                              parentCmdBufInfo.state.GetFramebuffer() != ResourceId();
+      bool framebufferUsage = parentCmdBufInfo.state.ActiveRenderPass();
 
       for(uint32_t c = 0; c < commandBufferCount; c++)
       {

Original file line number	Diff line number	Diff line change
`@@ -4890,8 +4890,7 @@ bool WrappedVulkan::Serialise_vkCmdExecuteCommands(SerialiserType &ser, VkComman`
`4890`	`4890`	`parentCmdBufInfo.curEventID++;`
`4891`	`4891`
`4892`	`4892`	`// should we add framebuffer usage to the child draws.`
`4893`		`- bool framebufferUsage = parentCmdBufInfo.state.GetRenderPass() != ResourceId() &&`
`4894`		`- parentCmdBufInfo.state.GetFramebuffer() != ResourceId();`
	`4893`	`+ bool framebufferUsage = parentCmdBufInfo.state.ActiveRenderPass();`
`4895`	`4894`
`4896`	`4895`	`for(uint32_t c = 0; c < commandBufferCount; c++)`
`4897`	`4896`	`{`