[NTFS] Rewrite ReleaseAttributeContext() so that its null checks are consistent

HeisSpiter · HeisSpiter · commit 849fa7fbae3d · 2017-12-31T10:38:58.000+01:00
CID 1427067
diff --git a/drivers/filesystems/ntfs/mft.c b/drivers/filesystems/ntfs/mft.c
@@ -105,13 +105,15 @@ PrepareAttributeContext(PNTFS_ATTR_RECORD AttrRecord)
 VOID
 ReleaseAttributeContext(PNTFS_ATTR_CONTEXT Context)
 {
-    if (Context->pRecord->IsNonResident)
+    if (Context->pRecord)
     {
-        FsRtlUninitializeLargeMcb(&Context->DataRunsMCB);
-    }
+        if (Context->pRecord->IsNonResident)
+        {
+            FsRtlUninitializeLargeMcb(&Context->DataRunsMCB);
+        }
 
-    if(Context->pRecord)
         ExFreePoolWithTag(Context->pRecord, TAG_NTFS);
+    }
 
     ExFreePoolWithTag(Context, TAG_NTFS);
 }

Original file line number	Diff line number	Diff line change
`@@ -105,13 +105,15 @@ PrepareAttributeContext(PNTFS_ATTR_RECORD AttrRecord)`
`105`	`105`	`VOID`
`106`	`106`	`ReleaseAttributeContext(PNTFS_ATTR_CONTEXT Context)`
`107`	`107`	`{`
`108`		`- if (Context->pRecord->IsNonResident)`
	`108`	`+ if (Context->pRecord)`
`109`	`109`	`{`
`110`		`- FsRtlUninitializeLargeMcb(&Context->DataRunsMCB);`
`111`		`- }`
	`110`	`+ if (Context->pRecord->IsNonResident)`
	`111`	`+ {`
	`112`	`+ FsRtlUninitializeLargeMcb(&Context->DataRunsMCB);`
	`113`	`+ }`
`112`	`114`
`113`		`- if(Context->pRecord)`
`114`	`115`	`ExFreePoolWithTag(Context->pRecord, TAG_NTFS);`
	`116`	`+ }`
`115`	`117`
`116`	`118`	`ExFreePoolWithTag(Context, TAG_NTFS);`
`117`	`119`	`}`