Skip to content

Commit b52f520

Browse files
committed
Merge branch 'main' into merge-to-main
2 parents 6b3a175 + a4fd6e9 commit b52f520

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ a pre-built binary from [https://github.com/protocolbuffers/protobuf/releases](h
3535

3636
If you want, you can compile `protoc` from source instead. To do this
3737
follow the instructions in [the top-level
38-
README](https://github.com/protocolbuffers/protobuf/blob/master/src/README.md).
38+
README](https://github.com/protocolbuffers/protobuf/blob/main/src/README.md).
3939

4040
Once you have `protoc` compiled, you can run the tests provided along with our project to examine whether it can run successfully. In order to do this, you should download the Protocol Buffer source code from the release page with the link above. Then extract the source code and navigate to the folder named `js` containing a `package.json` file and a series of test files. In this folder, you can run the commands below to run the tests automatically.
4141

@@ -129,7 +129,7 @@ The syntax of the `--js_out` flag is:
129129
Where `OPTIONS` are separated by commas. Options are either `opt=val` or
130130
just `opt` (for options that don't take a value). The available options
131131
are specified and documented in the `GeneratorOptions` struct in
132-
[src/google/protobuf/compiler/js/js_generator.h](https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/compiler/js/js_generator.h#L53).
132+
[src/google/protobuf/compiler/js/js_generator.h](https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/compiler/js/js_generator.h#L53).
133133

134134
Some examples:
135135

binary/reader_test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ describe('binaryReaderTest', function() {
5757
it('testInstanceCaches', /** @suppress {visibility} */ function() {
5858
var writer = new jspb.BinaryWriter();
5959
var dummyMessage = /** @type {!jspb.BinaryMessage} */ ({});
60-
writer.writeMessage(1, dummyMessage, goog.nullFunction);
61-
writer.writeMessage(2, dummyMessage, goog.nullFunction);
60+
writer.writeMessage(1, dummyMessage, () => {});
61+
writer.writeMessage(2, dummyMessage, () => {});
6262

6363
var buffer = writer.getResultBuffer();
6464

@@ -139,7 +139,7 @@ describe('binaryReaderTest', function() {
139139
var dummyMessage = /** @type {!jspb.BinaryMessage} */ ({});
140140
reader.nextField();
141141
assertThrows(function() {
142-
reader.readMessage(dummyMessage, goog.nullFunction);
142+
reader.readMessage(dummyMessage, () => {});
143143
});
144144

145145
// Reading past the end of the stream should trigger an assertion.
@@ -651,7 +651,7 @@ describe('binaryReaderTest', function() {
651651
});
652652

653653
// Add one empty message.
654-
writer.writeMessage(6, dummyMessage, goog.nullFunction);
654+
writer.writeMessage(6, dummyMessage, () => {});
655655

656656
writer.writeInt32(7, 700);
657657

binary/writer_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('binaryWriterTest', function() {
6565
var dummyMessage = /** @type {!jspb.BinaryMessage} */ ({});
6666

6767
assertFails(function() {
68-
writer.writeMessage(-1, dummyMessage, goog.nullFunction);
68+
writer.writeMessage(-1, dummyMessage, () => {});
6969
});
7070

7171
// Writing invalid field indices should assert.

compatibility_tests/v3.0.0/binary/reader_test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ describe('binaryReaderTest', function() {
5656
it('testInstanceCaches', /** @suppress {visibility} */ function() {
5757
var writer = new jspb.BinaryWriter();
5858
var dummyMessage = /** @type {!jspb.BinaryMessage} */({});
59-
writer.writeMessage(1, dummyMessage, goog.nullFunction);
60-
writer.writeMessage(2, dummyMessage, goog.nullFunction);
59+
writer.writeMessage(1, dummyMessage, () => {});
60+
writer.writeMessage(2, dummyMessage, () => {});
6161

6262
var buffer = writer.getResultBuffer();
6363

@@ -138,7 +138,7 @@ describe('binaryReaderTest', function() {
138138
var dummyMessage = /** @type {!jspb.BinaryMessage} */({});
139139
reader.nextField();
140140
assertThrows(function() {
141-
reader.readMessage(dummyMessage, goog.nullFunction);
141+
reader.readMessage(dummyMessage, () => {});
142142
});
143143

144144
// Reading past the end of the stream should trigger an assertion.
@@ -596,7 +596,7 @@ describe('binaryReaderTest', function() {
596596
});
597597

598598
// Add one empty message.
599-
writer.writeMessage(6, dummyMessage, goog.nullFunction);
599+
writer.writeMessage(6, dummyMessage, () => {});
600600

601601
writer.writeInt32(7, 700);
602602

compatibility_tests/v3.0.0/binary/writer_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ describe('binaryWriterTest', function() {
6262
var dummyMessage = /** @type {!jspb.BinaryMessage} */({});
6363

6464
assertFails(function() {
65-
writer.writeMessage(-1, dummyMessage, goog.nullFunction);
65+
writer.writeMessage(-1, dummyMessage, () => {});
6666
});
6767

6868
// Writing invalid field indices should assert.

compatibility_tests/v3.1.0/binary/reader_test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ describe('binaryReaderTest', function() {
5656
it('testInstanceCaches', /** @suppress {visibility} */ function() {
5757
var writer = new jspb.BinaryWriter();
5858
var dummyMessage = /** @type {!jspb.BinaryMessage} */ ({});
59-
writer.writeMessage(1, dummyMessage, goog.nullFunction);
60-
writer.writeMessage(2, dummyMessage, goog.nullFunction);
59+
writer.writeMessage(1, dummyMessage, () => {});
60+
writer.writeMessage(2, dummyMessage, () => {});
6161

6262
var buffer = writer.getResultBuffer();
6363

@@ -138,7 +138,7 @@ describe('binaryReaderTest', function() {
138138
var dummyMessage = /** @type {!jspb.BinaryMessage} */ ({});
139139
reader.nextField();
140140
assertThrows(function() {
141-
reader.readMessage(dummyMessage, goog.nullFunction);
141+
reader.readMessage(dummyMessage, () => {});
142142
});
143143

144144
// Reading past the end of the stream should trigger an assertion.
@@ -620,7 +620,7 @@ describe('binaryReaderTest', function() {
620620
});
621621

622622
// Add one empty message.
623-
writer.writeMessage(6, dummyMessage, goog.nullFunction);
623+
writer.writeMessage(6, dummyMessage, () => {});
624624

625625
writer.writeInt32(7, 700);
626626

compatibility_tests/v3.1.0/binary/writer_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ describe('binaryWriterTest', function() {
6262
var dummyMessage = /** @type {!jspb.BinaryMessage} */ ({});
6363

6464
assertFails(function() {
65-
writer.writeMessage(-1, dummyMessage, goog.nullFunction);
65+
writer.writeMessage(-1, dummyMessage, () => {});
6666
});
6767

6868
// Writing invalid field indices should assert.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
},
2121
"repository": {
2222
"type": "git",
23-
"url": "https://github.com/protocolbuffers/protobuf/tree/master/js"
23+
"url": "https://github.com/protocolbuffers/protobuf/tree/main/js"
2424
},
2525
"author": "Google Protocol Buffers Team",
2626
"license": "BSD-3-Clause"

0 commit comments

Comments
 (0)