Skip to content

Commit 16391f2

Browse files
ArminJoArminJo
committed
Improved SHARP repeat decoding
1 parent 18e9d61 commit 16391f2

File tree

23 files changed

+111
-106
lines changed

23 files changed

+111
-106
lines changed

‎changelog.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ See also the commit log at github: https://github.com/Arduino-IRremote/Arduino-I
3131
- Support for seeduino which lacks the print(unsigned long long...) method. Thanks to sklott https://stackoverflow.com/users/11680056/sklott
3232
- Added support for attiny1614 by Joe Ostrander.
3333
- Fixed SEND_PWM_BY_TIMER for ATtiny167 thanks to freskpe.
34+
- Improved SHARP repeat decoding.
3435

3536
## 3.9.0
3637
- Improved documentation with the help of [ElectronicsArchiver}(https://github.com/ElectronicsArchiver).

‎examples/AllProtocols/AllProtocols.ino‎

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ LiquidCrystal myLCD(4, 5, 6, 7, 8, 9);
120120
void printIRResultOnLCD();
121121
size_t printHex(uint16_t aHexByteValue);
122122
void printSpaces(uint_fast8_t aNumberOfSpacesToPrint);
123-
void PrintVCCOnLCD();
124123

125124
void setup() {
126125
#if FLASHEND >= 0x3FFF // For 16k flash or more, like ATtiny1604. Code does not fit in program memory of ATtiny85 etc.
@@ -221,25 +220,21 @@ void loop() {
221220
#if defined(USE_LCD) && defined(__AVR__) && defined(ADCSRA) && defined(ADATE)
222221
//Periodically print VCC
223222
if (!ProtocolStringOverwritesVoltage && millis() - sMillisOfLastVoltagePrint > MILLIS_BETWEEN_VOLTAGE_PRINT) {
224-
PrintVCCOnLCD();
223+
/*
224+
* Periodically print VCC
225+
*/
226+
sMillisOfLastVoltagePrint = millis();
227+
uint16_t tVCC = getVCCVoltageMillivoltSimple();
228+
char tVoltageString[5];
229+
dtostrf(tVCC / 1000.0, 4, 2, tVoltageString);
230+
myLCD.setCursor(LCD_VOLTAGE_START_INDEX, 0);
231+
myLCD.print(tVoltageString);
232+
myLCD.print('V');
225233
}
226234
#endif
227235

228236
}
229237

230-
void PrintVCCOnLCD() {
231-
/*
232-
* Periodically print VCC
233-
*/
234-
sMillisOfLastVoltagePrint = millis();
235-
uint16_t tVCC = getVCCVoltageMillivoltSimple();
236-
char tVoltageString[5];
237-
dtostrf(tVCC / 1000.0, 4, 2, tVoltageString);
238-
myLCD.setCursor(LCD_VOLTAGE_START_INDEX, 0);
239-
myLCD.print(tVoltageString);
240-
myLCD.print('V');
241-
}
242-
243238
/*
244239
* LCD output for 1602 LCDs
245240
* 40 - 55 Milliseconds per initial output

‎examples/AllProtocols/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/ControlRelay/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/IRDispatcherDemo/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/IRremoteExtensionTest/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/MicroGirs/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/ReceiveAndSend/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/ReceiveDemo/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

‎examples/ReceiveDump/PinDefinitionsAndMore.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
#define IR_RECEIVE_PIN 9 // PA3 - on Digispark board labeled as pin 9
6262
//#define IR_RECEIVE_PIN 14 // PB6 / INT0 is connected to USB+ on DigisparkPro boards
6363
#define IR_SEND_PIN 8 // PA2 - on Digispark board labeled as pin 8
64-
#define TONE_PIN 5 // PA7
64+
#define TONE_PIN 5 // PA7 - on Digispark board labeled as pin 5
6565
#define _IR_TIMING_TEST_PIN 10 // PA4
6666
# else
67-
#define IR_RECEIVE_PIN 3
68-
#define IR_SEND_PIN 2
69-
#define TONE_PIN 7
67+
#define IR_RECEIVE_PIN 3 // PA3 - on Digispark board labeled as pin 9
68+
#define IR_SEND_PIN 2 // PA2 - on Digispark board labeled as pin 8
69+
#define TONE_PIN 7 // PA7 - on Digispark board labeled as pin 5
7070
# endif
7171

7272
# elif defined(__AVR_ATtiny88__) // MH-ET Tiny88 board

0 commit comments

Comments
 (0)