Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TanStack/query
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: TanStack/query
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/select-error-boundary
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 14 files changed
  • 1 contributor

Commits on Jul 26, 2024

  1. fix(react-query): make sure that we never render with undefined data … 

    …when using suspense

We guarantee this on type level, but at runtime, if `select` throws an error, the defaultThrowOnError would return `false` because data is only undefined on observer level. The extra check for observer data in suspense mode guarantees this
    @TkDodo
    TkDodo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4d56163 View commit details
    Browse the repository at this point in the history

  2. refactor: exposes noop from query-core and use it in adapters

    @TkDodo
    TkDodo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    70c3614 View commit details
    Browse the repository at this point in the history

  3. refactor: move shouldThrowOnError to errorBoundaryUtils.ts

    @TkDodo
    TkDodo committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    acb1c0a View commit details
    Browse the repository at this point in the history
Loading