Bug29770682: IS FALSE is being interpreted as IS TRUE

Fix CAST(val as NOT_KNOWN_TYPE) segmentation fault

Author: silvakid

cdk/parser/expr_parser.cc

@@ -215,6 +215,10 @@ std::string Expr_parser_base::parse_cast_type()
     parse_error("Expected cast type");
 
   Keyword::Type type = Keyword::get(*token);
+
+  if (Keyword::NONE == type)
+    parse_error("Unexpected cast type");
+
   type_str = Keyword::name(type);
 
   switch (type)
@@ -242,7 +246,7 @@ std::string Expr_parser_base::parse_cast_type()
     break;
 
   default:
-    parse_error("Expected cast type");
+    parse_error("Unexpected cast type");
 
   }
 
@@ -1695,7 +1699,7 @@ Expression* Expr_parser_base::parse_ilri(Processor *prc)
         switch (Keyword::get(*t))
         {
         case Keyword::L_TRUE:  aprc->list_el()->scalar()->val()->yesno(true); break;
-        case Keyword::L_FALSE: aprc->list_el()->scalar()->val()->yesno(true); break;
+        case Keyword::L_FALSE: aprc->list_el()->scalar()->val()->yesno(false); break;
         case Keyword::L_NULL: aprc->list_el()->scalar()->val()->null(); break;
         default:
           t = NULL; // this indicates error

devapi/tests/bugs-t.cc

@@ -641,5 +641,22 @@ TEST_F(Bugs, bug29525077)
     }
   }
   sess.dropSchema("bug29525077_int_types");
+}
 
-}
+TEST_F(Bugs, is_false)
+{
+  SKIP_IF_NO_XPLUGIN
+  auto schema = get_sess().createSchema("test", true);
+  auto coll = schema.createCollection("is_false", true);
+  coll.remove("true").execute();
+  coll.add(DbDoc(R"({"val": 0 })")).execute();
+  coll.add(DbDoc(R"({"val": 1 })")).execute();
+  coll.add(DbDoc(R"({"val": 1 })")).execute();
+  // Since boolean is not an expected type, it should throw error
+  // Had a segmentation fault issue
+  EXPECT_THROW(coll.find("cast(val as boolean) is false").execute(),
+               mysqlx::Error);
+  EXPECT_EQ(1, coll.find("val is false").execute().count());
+  auto tbl = schema.getCollectionAsTable("is_false");
+  EXPECT_EQ(1, tbl.select().where("doc->$.val is false").execute().count());
+}