Skip to content

Commit d860948

Browse files
committed
Change fixture server -> threaded_server
1 parent 365c229 commit d860948

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

tests/test_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from utils import session, client_session, server
1+
from utils import session, client_session, threaded_server
22
from time import sleep
33
import threading
44

tests/utils.py

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,33 +57,31 @@ def handle_received_message(self, client, server, message):
5757

5858

5959
@pytest.fixture(scope='function')
60-
def server():
60+
def threaded_server():
6161
""" Returns the response of a server after"""
62-
s = TestServer(0, loglevel=logging.DEBUG)
63-
server_thread = Thread(target=s.run_forever)
64-
server_thread.daemon = True
65-
server_thread.start()
66-
yield s
67-
s.server_close()
62+
server = TestServer(0, loglevel=logging.DEBUG)
63+
server.run_forever(threaded=True)
64+
yield server
65+
server.server_close()
6866

6967

7068
@pytest.fixture
71-
def session(server):
69+
def session(threaded_server):
7270
"""
7371
Gives a simple connection to a server
7472
"""
75-
conn = websocket.create_connection("ws://{}:{}".format(*server.server_address))
76-
yield conn, server
73+
conn = websocket.create_connection("ws://{}:{}".format(*threaded_server.server_address))
74+
yield conn, threaded_server
7775
conn.close()
7876

7977

8078
@pytest.fixture
81-
def client_session(server):
79+
def client_session(threaded_server):
8280
"""
8381
Gives a TestClient instance connected to a server
8482
"""
85-
client = TestClient(port=server.port)
83+
client = TestClient(port=threaded_server.port)
8684
sleep(1)
8785
assert client.ws.sock and client.ws.sock.connected
88-
yield client, server
86+
yield client, threaded_server
8987
client.ws.close()

0 commit comments

Comments
 (0)