glayzzle#348 - disable byref on new tokens

Author: ichiriac

src/parser/expr.js

@@ -356,6 +356,9 @@ module.exports = {
           let right;
           if (this.next().token == "&") {
             if (this.next().token === this.tok.T_NEW) {
+              if (this.php7) {
+                this.error();
+              }
               right = this.read_new_expr();
             } else {
               right = this.read_variable(false, false, true);

test/snapshot/__snapshots__/new.test.js.snap

@@ -1,5 +1,44 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`new #348 - byref usage deprecated 1`] = `
+Program {
+  "children": Array [
+    ExpressionStatement {
+      "expression": Assign {
+        "kind": "assign",
+        "left": Variable {
+          "byref": false,
+          "curly": false,
+          "kind": "variable",
+          "name": "a",
+        },
+        "operator": "=",
+        "right": New {
+          "arguments": Array [],
+          "kind": "new",
+          "what": ClassReference {
+            "kind": "classreference",
+            "name": "Foo",
+            "resolution": "uqn",
+          },
+        },
+      },
+      "kind": "expressionstatement",
+    },
+  ],
+  "errors": Array [
+    Error {
+      "expected": undefined,
+      "kind": "error",
+      "line": 1,
+      "message": "Parse Error : syntax error, unexpected 'new' (T_NEW) on line 1",
+      "token": "'new' (T_NEW)",
+    },
+  ],
+  "kind": "program",
+}
+`;
+
 exports[`new anonymous 1`] = `
 Program {
   "children": Array [

test/snapshot/new.test.js

@@ -1,9 +1,16 @@
 const parser = require('../main');
 
 describe("new", function() {
+  it("#348 - byref usage deprecated", function() {
+    expect(parser.parseEval('$a =& new Foo();', {
+      parser: {
+        suppressErrors: true
+      }
+    })).toMatchSnapshot();
+  });
   it("simple", function() {
     expect(parser.parseEval('new Foo();')).toMatchSnapshot();
-  });
+  });  
   it("variable", function() {
     expect(parser.parseEval('new $var;')).toMatchSnapshot();
   });