Skip to content

Commit 0e3e29d

Browse files
committed
Merge branch 'master' of https://github.com/bcostm/mbed
Conflicts: libraries/mbed/targets/cmsis/TARGET_STM/TARGET_STM32L4/TARGET_NUCLEO_L476RG/TOOLCHAIN_ARM_MICRO/startup_stm32l476xx.s libraries/mbed/targets/cmsis/TARGET_STM/TARGET_STM32L4/TARGET_NUCLEO_L476RG/TOOLCHAIN_ARM_MICRO/stm32l476xx.sct libraries/mbed/targets/cmsis/TARGET_STM/TARGET_STM32L4/TARGET_NUCLEO_L476RG/TOOLCHAIN_ARM_STD/startup_stm32l476xx.s libraries/mbed/targets/cmsis/TARGET_STM/TARGET_STM32L4/TARGET_NUCLEO_L476RG/TOOLCHAIN_ARM_STD/stm32l476xx.sct libraries/mbed/targets/cmsis/TARGET_STM/TARGET_STM32L4/TARGET_NUCLEO_L476RG/TOOLCHAIN_GCC_ARM/STM32L476XX.ld libraries/mbed/targets/cmsis/TARGET_STM/TARGET_STM32L4/TARGET_NUCLEO_L476RG/TOOLCHAIN_IAR/stm32l476xx.icf libraries/mbed/targets/hal/TARGET_Atmel/TARGET_SAM_CortexM0+/TARGET_SAMD21J18A/PeripheralNames.h libraries/mbed/targets/hal/TARGET_Atmel/TARGET_SAM_CortexM0+/TARGET_SAMD21J18A/PeripheralPins.c libraries/mbed/targets/hal/TARGET_Atmel/TARGET_SAM_CortexM0+/TARGET_SAMD21J18A/PeripheralPins.h libraries/mbed/targets/hal/TARGET_Atmel/TARGET_SAM_CortexM0+/TARGET_SAMD21J18A/PinNames.h libraries/mbed/targets/hal/TARGET_Atmel/TARGET_SAM_CortexM0+/TARGET_SAMD21J18A/analogout_api.c workspace_tools/build_release.py workspace_tools/host_tests/host_test.py
1 parent 856efdc commit 0e3e29d

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

libraries/mbed/targets/hal/TARGET_STM/TARGET_STM32F4/analogout_api.c

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
#include "stm32f4xx_hal.h"
3636
#include "PeripheralPins.h"
3737

38-
#define RANGE_12BIT (0xFFF)
38+
#define DAC_RANGE (0xFFF) // 12 bits
39+
#define DAC_NB_BITS (12)
3940

4041
DAC_HandleTypeDef DacHandle;
4142
static DAC_ChannelConfTypeDef sConfig;
@@ -98,14 +99,14 @@ void analogout_free(dac_t *obj)
9899
{
99100
}
100101

101-
static inline void dac_write(dac_t *obj, uint16_t value)
102+
static inline void dac_write(dac_t *obj, int value)
102103
{
103104
HAL_StatusTypeDef status = HAL_ERROR;
104105

105106
if (obj->channel == 1) {
106-
status = HAL_DAC_SetValue(&DacHandle, DAC_CHANNEL_1, DAC_ALIGN_12B_R, value);
107+
status = HAL_DAC_SetValue(&DacHandle, DAC_CHANNEL_1, DAC_ALIGN_12B_R, (value & DAC_RANGE));
107108
} else if (obj->channel == 2) {
108-
status = HAL_DAC_SetValue(&DacHandle, DAC_CHANNEL_2, DAC_ALIGN_12B_R, value);
109+
status = HAL_DAC_SetValue(&DacHandle, DAC_CHANNEL_2, DAC_ALIGN_12B_R, (value & DAC_RANGE));
109110
}
110111

111112
if ( status != HAL_OK ) {
@@ -128,31 +129,27 @@ void analogout_write(dac_t *obj, float value)
128129
if (value < 0.0f) {
129130
dac_write(obj, 0); // Min value
130131
} else if (value > 1.0f) {
131-
dac_write(obj, (uint16_t)RANGE_12BIT); // Max value
132+
dac_write(obj, (int)DAC_RANGE); // Max value
132133
} else {
133-
dac_write(obj, (uint16_t)(value * (float)RANGE_12BIT));
134+
dac_write(obj, (int)(value * (float)DAC_RANGE));
134135
}
135136
}
136137

137138
void analogout_write_u16(dac_t *obj, uint16_t value)
138139
{
139-
if (value > (uint16_t)RANGE_12BIT) {
140-
value = (uint16_t)RANGE_12BIT; // Max value
141-
}
142-
143-
dac_write(obj, value);
140+
dac_write(obj, value >> (16 - DAC_NB_BITS));
144141
}
145142

146143
float analogout_read(dac_t *obj)
147144
{
148-
149145
uint32_t value = dac_read(obj);
150-
return (float)value * (1.0f / (float)RANGE_12BIT);
146+
return (float)value * (1.0f / (float)DAC_RANGE);
151147
}
152148

153149
uint16_t analogout_read_u16(dac_t *obj)
154150
{
155-
return (uint16_t)dac_read(obj);
151+
uint32_t value = dac_read(obj);
152+
return (value << 4) | ((value >> 8) & 0x000F); // Conversion from 12 to 16 bits
156153
}
157154

158155
#endif // DEVICE_ANALOGOUT

0 commit comments

Comments
 (0)