Skip to content

Commit ace5a21

Browse files
committed
DATAES-285 - Polishing
* drop superfluous class FieldIndex * change FieldType text and keyword starting with capital letters Original commit: 089d774
1 parent 9c235cd commit ace5a21

File tree

10 files changed

+33
-48
lines changed

10 files changed

+33
-48
lines changed

src/main/java/org/springframework/data/elasticsearch/annotations/FieldIndex.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/main/java/org/springframework/data/elasticsearch/annotations/FieldType.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,17 @@
2121
* @author Artur Konczak
2222
*/
2323
public enum FieldType {
24-
text, Integer, Long, Date, Float, Double, Boolean, Object, Auto, Nested, Ip, Attachment, keyword
24+
Text,
25+
Integer,
26+
Long,
27+
Date,
28+
Float,
29+
Double,
30+
Boolean,
31+
Object,
32+
Auto,
33+
Nested,
34+
Ip,
35+
Attachment,
36+
Keyword
2537
}

src/test/java/org/springframework/data/elasticsearch/core/facet/ArticleEntity.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.springframework.data.elasticsearch.core.facet;
1717

1818
import static org.springframework.data.elasticsearch.annotations.FieldType.Integer;
19-
import static org.springframework.data.elasticsearch.annotations.FieldType.text;
19+
import static org.springframework.data.elasticsearch.annotations.FieldType.Text;
2020

2121
import java.util.ArrayList;
2222
import java.util.List;
@@ -36,14 +36,14 @@ public class ArticleEntity {
3636
@Id
3737
private String id;
3838
private String title;
39-
@Field(type = text, fielddata = true)
39+
@Field(type = Text, fielddata = true)
4040
private String subject;
4141

4242
@MultiField(
43-
mainField = @Field(type = text),
43+
mainField = @Field(type = Text),
4444
otherFields = {
45-
@InnerField(suffix = "untouched", type = text, store = true, fielddata = true, indexAnalyzer = "keyword"),
46-
@InnerField(suffix = "sort", type = text, store = true, indexAnalyzer = "keyword")
45+
@InnerField(suffix = "untouched", type = Text, store = true, fielddata = true, indexAnalyzer = "keyword"),
46+
@InnerField(suffix = "sort", type = Text, store = true, indexAnalyzer = "keyword")
4747
}
4848
)
4949
private List<String> authors = new ArrayList<>();

src/test/java/org/springframework/data/elasticsearch/entities/ParentEntity.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import org.springframework.data.annotation.Id;
2020
import org.springframework.data.elasticsearch.annotations.Document;
2121
import org.springframework.data.elasticsearch.annotations.Field;
22-
import org.springframework.data.elasticsearch.annotations.FieldIndex;
2322
import org.springframework.data.elasticsearch.annotations.FieldType;
2423
import org.springframework.data.elasticsearch.annotations.Parent;
2524

@@ -38,7 +37,7 @@ public class ParentEntity {
3837

3938
@Id
4039
private String id;
41-
@Field(type = FieldType.text, store = true)
40+
@Field(type = FieldType.Text, store = true)
4241
private String name;
4342

4443
public ParentEntity() {
@@ -67,10 +66,10 @@ public static class ChildEntity {
6766

6867
@Id
6968
private String id;
70-
@Field(type = FieldType.text, store = true)
69+
@Field(type = FieldType.Text, store = true)
7170
@Parent(type = PARENT_TYPE)
7271
private String parentId;
73-
@Field(type = FieldType.text, store = true)
72+
@Field(type = FieldType.Text, store = true)
7473
private String name;
7574

7675
public ChildEntity() {

src/test/java/org/springframework/data/elasticsearch/entities/SampleDateMappingEntity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.springframework.data.elasticsearch.entities;
22

33
import static org.springframework.data.elasticsearch.annotations.FieldType.*;
4-
import static org.springframework.data.elasticsearch.annotations.FieldType.text;
4+
import static org.springframework.data.elasticsearch.annotations.FieldType.Text;
55

66
import java.util.Date;
77

@@ -19,7 +19,7 @@ public class SampleDateMappingEntity {
1919
@Id
2020
private String id;
2121

22-
@Field(type = text, index = false, store = true, analyzer = "standard")
22+
@Field(type = Text, index = false, store = true, analyzer = "standard")
2323
private String message;
2424

2525
@Field(type = Date, format = DateFormat.custom, pattern = "dd.MM.yyyy hh:mm")

src/test/java/org/springframework/data/elasticsearch/entities/SampleEntity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ public class SampleEntity {
4949

5050
@Id
5151
private String id;
52-
@Field(type = text, store = true, fielddata = true)
52+
@Field(type = Text, store = true, fielddata = true)
5353
private String type;
54-
@Field(type = text, store = true, fielddata = true)
54+
@Field(type = Text, store = true, fielddata = true)
5555
private String message;
5656
private int rate;
5757
@ScriptedField

src/test/java/org/springframework/data/elasticsearch/entities/SampleEntityUUIDKeyed.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public class SampleEntityUUIDKeyed {
4848
@Id
4949
private UUID id;
5050
private String type;
51-
@Field(type = FieldType.text, fielddata = true)
51+
@Field(type = FieldType.Text, fielddata = true)
5252
private String message;
5353
private int rate;
5454
@ScriptedField

src/test/java/org/springframework/data/elasticsearch/entities/SampleInheritedEntity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.springframework.data.elasticsearch.entities;
1717

18-
import static org.springframework.data.elasticsearch.annotations.FieldType.text;
18+
import static org.springframework.data.elasticsearch.annotations.FieldType.Text;
1919

2020
import org.springframework.data.elasticsearch.annotations.Document;
2121
import org.springframework.data.elasticsearch.annotations.Field;
@@ -26,7 +26,7 @@
2626
@Document(indexName = "test-index-sample-inherited", type = "mapping", shards = 1, replicas = 0, refreshInterval = "-1")
2727
public class SampleInheritedEntity extends AbstractInheritedEntity {
2828

29-
@Field(type = text, index = false, store = true, analyzer = "standard")
29+
@Field(type = Text, index = false, store = true, analyzer = "standard")
3030
private String message;
3131

3232
public String getMessage() {

src/test/java/org/springframework/data/elasticsearch/entities/SampleMappingEntity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.springframework.data.elasticsearch.entities;
1717

18-
import static org.springframework.data.elasticsearch.annotations.FieldType.text;
18+
import static org.springframework.data.elasticsearch.annotations.FieldType.Text;
1919

2020
import org.springframework.data.annotation.Id;
2121
import org.springframework.data.elasticsearch.annotations.Document;
@@ -31,7 +31,7 @@ public class SampleMappingEntity {
3131
@Id
3232
private String id;
3333

34-
@Field(type = text, index = false, store = true, analyzer = "standard")
34+
@Field(type = Text, index = false, store = true, analyzer = "standard")
3535
private String message;
3636

3737
private NestedEntity nested;
@@ -54,7 +54,7 @@ public void setMessage(String message) {
5454

5555
static class NestedEntity {
5656

57-
@Field(type = text)
57+
@Field(type = Text)
5858
private String someField;
5959

6060
public String getSomeField() {

src/test/java/org/springframework/data/elasticsearch/entities/SampleTransientEntity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.springframework.data.elasticsearch.entities;
1717

18-
import static org.springframework.data.elasticsearch.annotations.FieldType.text;
18+
import static org.springframework.data.elasticsearch.annotations.FieldType.Text;
1919

2020
import org.springframework.data.annotation.Id;
2121
import org.springframework.data.annotation.Transient;
@@ -31,7 +31,7 @@ public class SampleTransientEntity {
3131
@Id
3232
private String id;
3333

34-
@Field(type = text, index = false, store = true, analyzer = "standard")
34+
@Field(type = Text, index = false, store = true, analyzer = "standard")
3535
private String message;
3636

3737
@Transient

0 commit comments

Comments
 (0)