chore(ewbpack): fix webpack warnings & sitemap.xml

* Migrated plugin to shared config.
Eliminates webpack warning.

* Added placeholder awaits.
Eliminates initial warnings.

* Changed to pure XML with format string.
"localhost" removed as well.

* format update.

* Revised after testing.

Author: electricessence

Server/Controllers/HomeController.cs

@@ -11,6 +11,7 @@
 using System.Diagnostics;
 using System;
 using Asp2017.Server.Models;
+using System.Text.RegularExpressions;
 
 namespace AspCoreServer.Controllers
 {
@@ -32,26 +33,24 @@ public async Task<IActionResult> Index()
       return View();
     }
 
+    const string SITEMAP_XML =
+      @"<?xml version=""1.0"" encoding=""utf-8""?>
+      <sitemapindex xmlns=""http://www.sitemaps.org/schemas/sitemap/0.9"">
+      <sitemap>
+        <loc>/home</loc>
+        <lastmod>{0}</lastmod>
+      </sitemap>
+      <sitemap>
+        <loc>/counter</loc>
+        <lastmod>{0}</lastmod>
+      </sitemap>
+      </sitemapindex>
+      ";
+
     [HttpGet]
     [Route("sitemap.xml")]
-    public async Task<IActionResult> SitemapXml()
-    {
-      String xml = "<?xml version=\"1.0\" encoding=\"utf-8\"?>";
-
-      xml += "<sitemapindex xmlns=\"http://www.sitemaps.org/schemas/sitemap/0.9\">";
-      xml += "<sitemap>";
-      xml += "<loc>http://localhost:4251/home</loc>";
-      xml += "<lastmod>" + DateTime.Now.ToString("yyyy-MM-dd") + "</lastmod>";
-      xml += "</sitemap>";
-      xml += "<sitemap>";
-      xml += "<loc>http://localhost:4251/counter</loc>";
-      xml += "<lastmod>" + DateTime.Now.ToString("yyyy-MM-dd") + "</lastmod>";
-      xml += "</sitemap>";
-      xml += "</sitemapindex>";
-
-      return Content(xml, "text/xml");
-
-    }
+    public IActionResult SitemapXml()
+      => Content(string.Format(SITEMAP_XML, DateTime.Now.ToString("yyyy-MM-dd")));
 
     public IActionResult Error()
     {

webpack.config.js

@@ -37,7 +37,15 @@ module.exports = (env) => {
                 ...sharedModuleRules
             ]
         },
-        plugins: [new CheckerPlugin()]
+        plugins: [
+            new CheckerPlugin(),
+            new webpack.ContextReplacementPlugin(
+                // fixes WARNING Critical dependency: the request of a dependency is an expression
+                /(.+)?angular(\\|\/)core(.+)?/,
+                path.join(__dirname, 'src'), // location of your src
+                {} // a map of your routes
+              ),
+        ]
     };
 
     // Configuration for client-side bundle suitable for running in browsers
@@ -89,19 +97,7 @@ module.exports = (env) => {
                 manifest: require('./ClientApp/dist/vendor-manifest.json'),
                 sourceType: 'commonjs2',
                 name: './vendor'
-            }),
-            new webpack.ContextReplacementPlugin(
-              // fixes WARNING Critical dependency: the request of a dependency is an expression
-              /(.+)?angular(\\|\/)core(.+)?/,
-              path.join(__dirname, 'src'), // location of your src
-              {} // a map of your routes
-            ),
-            new webpack.ContextReplacementPlugin(
-              // fixes WARNING Critical dependency: the request of a dependency is an expression
-              /(.+)?express(\\|\/)(.+)?/,
-              path.join(__dirname, 'src'),
-              {}
-            )
+            })
         ].concat(isDevBuild ? [] : [
             // new webpack.optimize.UglifyJsPlugin({
             //   compress: false,