Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kamaha12000/aspnetcore-angular-universal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: TrilonIO/aspnetcore-angular-universal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 24 files changed
  • 3 contributors

Commits on Feb 10, 2019

  1. feat(update client): update client dependencies (TrilonIO#708) 

    This commit:
- updates Angular from 6.* to most recent 7.2 version
- updates all related client and tooling dependencies
- removes dependencies that are no longer user (like Chai related ones)

Thanks!
    @peterblazejewicz @MarkPieszak
    peterblazejewicz authored and MarkPieszak committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    57273e1 View commit details
    Browse the repository at this point in the history

  2. feat(webpack): migrate to terser from uglifiy 

    This fixes webpack build in production mode
See @webpack/webpack#7908

Thanks!
    @peterblazejewicz @MarkPieszak
    peterblazejewicz authored and MarkPieszak committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    49cfeba View commit details
    Browse the repository at this point in the history

  3. feat(pwa): update icons, favicons and manifest (TrilonIO#710) 

    - most common sizes added
- manifest entries updated
- favicon ships the same content as manifest icons

Thanks!
    @peterblazejewicz @MarkPieszak
    peterblazejewicz authored and MarkPieszak committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    5e43331 View commit details
    Browse the repository at this point in the history

  4. feat(charset): move declaration to top (TrilonIO#711) 

    Just to follow established routes:
https://blogs.msdn.microsoft.com/ieinternals/2011/07/18/best-practice-get-your-head-in-order/

Thanks!
    @peterblazejewicz @MarkPieszak
    peterblazejewicz authored and MarkPieszak committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    e184ce9 View commit details
    Browse the repository at this point in the history

  5. chore(preboot): pin to beta4

    @MarkPieszak
    MarkPieszak committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    8b0ec8e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Update dependencies to be aligned with NG 7.2.0. Fixes TrilonIO#716 (T… 

    …rilonIO#718)

closes TrilonIO#716 

This commit make changes in dependencies entries in package.json to be
more aligned to package.json version generated by @angular/cli 7.2.0.
This fixes the issue with outcome of script like build:prod

Thanks!

```bash
npm run clean:install

> [email protected] clean:install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> npm run clean && rimraf ./node_modules ./bin ./obj ./package-lock.json && dotnet restore Asp2017.csproj && npm i


> [email protected] clean /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> rimraf wwwroot/dist clientapp/dist

  Restoring packages for /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/Asp2017.csproj...
  Generating MSBuild file /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/obj/Asp2017.csproj.nuget.g.props.
  Generating MSBuild file /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/obj/Asp2017.csproj.nuget.g.targets.
  Restore completed in 1.95 sec for /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/Asp2017.csproj.
npm WARN deprecated [email protected]: CircularJSON is in maintenance only, flatted is its successor.

> [email protected] install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/fsevents
> node install

node-pre-gyp WARN Using request for node-pre-gyp https download 
[fsevents] Success: "/Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node" is installed via remote

> [email protected] install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/node-sass
> node scripts/install.js

Cached binary found at /Users/piotrblazejewicz/.npm/node-sass/4.11.0/darwin-x64-59_binding.node

> [email protected] install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/phantomjs-prebuilt
> node install.js

Considering PhantomJS found at /usr/local/bin/phantomjs
Found PhantomJS at /usr/local/bin/phantomjs ...verifying
Writing location.js file
PhantomJS is already installed on PATH at /usr/local/bin/phantomjs

> [email protected] postinstall /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/node-sass
> node scripts/build.js

Binary found at /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/node-sass/vendor/darwin-x64-59/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] requires a peer of popper.js@^1.14.7 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of webpack@^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.

added 1328 packages from 1266 contributors and audited 52380 packages in 40.119s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
```

```bash
npm run build:prod

> [email protected] build:prod /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> npm run clean && npm run build:vendor -- --env.prod && npm run build:webpack -- --env.prod


> [email protected] clean /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> rimraf wwwroot/dist clientapp/dist


> [email protected] build:vendor /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --config webpack.config.vendor.js --progress --color "--env.prod"

env = {"prod":true}
[1] Hash: 0cd0fe463be445b08132ce687d8bdad25e6a9daf                                    
Version: webpack 4.29.5
Child
    Hash: 0cd0fe463be445b08132
    Time: 6789ms
    Built at: 2019-02-26 18:32:15
        Asset     Size  Chunks             Chunk Names
    vendor.js  112 KiB       0  [emitted]  vendor
    Entrypoint vendor = vendor.js
Child
    Hash: ce687d8bdad25e6a9daf
    Time: 23102ms
    Built at: 2019-02-26 18:32:31
        Asset   Size  Chunks             Chunk Names
    vendor.js  2 MiB       0  [emitted]  vendor
    Entrypoint vendor = vendor.js
    
    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18394:19-40
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]
    
    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18406:19-106
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

> [email protected] build:webpack /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --progress --color "--env.prod"

[1] Hash: 283e428aa756b4bf9dc86d7e8bceb2c03b314740                                   
Version: webpack 4.29.5
Child
    Hash: 283e428aa756b4bf9dc8
    Time: 48150ms
    Built at: 2019-02-26 18:33:22
             Asset      Size  Chunks                    Chunk Names
              1.js  1.08 KiB       1  [emitted]         
    main-client.js  1.78 MiB       0  [emitted]  [big]  main-client
    Entrypoint main-client [big] = main-client.js
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.browser.ts 2:0-47 13:4-18
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.browser.ts 2:0-47 13:4-18
    
    WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
    This can impact web performance.
    Assets: 
      main-client.js (1.78 MiB)
    
    WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
    Entrypoints:
      main-client (1.78 MiB)
          main-client.js
    
Child
    Hash: 6d7e8bceb2c03b314740
    Time: 49251ms
    Built at: 2019-02-26 18:33:24
             Asset      Size  Chunks             Chunk Names
              1.js  1.21 KiB       1  [emitted]  
    main-server.js  2.96 MiB       0  [emitted]  main-server
    Entrypoint main-server = main-server.js
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.PRODUCTION.ts 3:0-47 8:0-14
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.PRODUCTION.ts 3:0-47 8:0-14
```

```bash
npm run build:dev

> [email protected] build:dev /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> npm run build:vendor && npm run build:webpack


> [email protected] build:vendor /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --config webpack.config.vendor.js --progress --color

env = undefined
[1] Hash: 3a685f0209a95b535a9f17a6a40f1c8908affc70                                    
Version: webpack 4.29.5
Child
    Hash: 3a685f0209a95b535a9f
    Time: 6393ms
    Built at: 2019-02-26 18:31:26
        Asset      Size  Chunks             Chunk Names
    vendor.js  6.94 MiB  vendor  [emitted]  vendor
    Entrypoint vendor = vendor.js
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]
Child
    Hash: 17a6a40f1c8908affc70
    Time: 6359ms
    Built at: 2019-02-26 18:31:26
        Asset      Size  Chunks             Chunk Names
    vendor.js  7.05 MiB  vendor  [emitted]  vendor
    Entrypoint vendor = vendor.js
    
    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18394:19-40
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]
    
    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18406:19-106
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

> [email protected] build:webpack /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --progress --color

[1] Hash: b4d33732336411f4f0263367da7fc158b6733f0d                                              
Version: webpack 4.29.5
Child
    Hash: b4d33732336411f4f026
    Time: 21055ms
    Built at: 2019-02-26 18:31:50
                 Asset      Size       Chunks             Chunk Names
                  0.js  8.26 KiB            0  [emitted]  
              0.js.map  81 bytes            0  [emitted]  
        main-client.js  4.07 MiB  main-client  [emitted]  main-client
    main-client.js.map  7.96 KiB  main-client  [emitted]  main-client
    Entrypoint main-client = main-client.js main-client.js.map
Child
    Hash: 3367da7fc158b6733f0d
    Time: 22992ms
    Built at: 2019-02-26 18:31:52
             Asset      Size       Chunks             Chunk Names
              0.js   8.2 KiB            0  [emitted]  
    main-server.js  20.7 MiB  main-server  [emitted]  main-server
    Entrypoint main-server = main-server.js
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.ts 3:0-47 8:0-14
    
    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.ts 3:0-47 8:0-14
```
    @peterblazejewicz @MarkPieszak
    peterblazejewicz authored and MarkPieszak committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    b461076 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. docs(readme): update

    @MarkPieszak
    MarkPieszak authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    ec6b2f3 View commit details
    Browse the repository at this point in the history

  2. docs: update

    @MarkPieszak
    MarkPieszak authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    1de9303 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. docs: update trilon info

    @MarkPieszak
    MarkPieszak authored Mar 12, 2019
    Configuration menu
    Copy the full SHA
    c8dac96 View commit details
    Browse the repository at this point in the history

  2. chore: trilon info

    @MarkPieszak
    MarkPieszak authored Mar 12, 2019
    Configuration menu
    Copy the full SHA
    2b91544 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. docs: update

    @MarkPieszak
    MarkPieszak authored Mar 17, 2019
    Configuration menu
    Copy the full SHA
    83b0301 View commit details
    Browse the repository at this point in the history

  2. docs: update

    @MarkPieszak
    MarkPieszak authored Mar 17, 2019
    Configuration menu
    Copy the full SHA
    7e2468a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. fix: rxjs pin to 6.2.2 

    closes TrilonIO#714
    @MarkPieszak
    MarkPieszak authored Mar 18, 2019
    Configuration menu
    Copy the full SHA
    4aa1640 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Update README.md

    @MarkPieszak
    MarkPieszak authored Apr 5, 2019
    Configuration menu
    Copy the full SHA
    9cf8b7b View commit details
    Browse the repository at this point in the history

  2. Update README.md

    @MarkPieszak
    MarkPieszak authored Apr 5, 2019
    Configuration menu
    Copy the full SHA
    82dc189 View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @MarkPieszak
    MarkPieszak authored Apr 5, 2019
    Configuration menu
    Copy the full SHA
    b8ec2b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2019

  1. Update README.md

    @MarkPieszak
    MarkPieszak authored Apr 7, 2019
    Configuration menu
    Copy the full SHA
    55f0105 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. fix(seeding): seeding now follows .NET Core 2.0 best practices

    @Detys @MarkPieszak
    Detys authored and MarkPieszak committed May 26, 2019
    Configuration menu
    Copy the full SHA
    837b134 View commit details
    Browse the repository at this point in the history
Loading