Issue checkstyle#17487: Add StreamRulesRecipes

Author: Vincent Potucek

config/jsoref-spellchecker/whitelist.words

@@ -1171,6 +1171,7 @@ redundantimport
 redundantmodifier
 refactor
 refactoring
+refasterrules
 refid
 refreshenv
 regex

pom.xml

@@ -221,6 +221,7 @@
     <checkstyle.openrewrite.version>1.0.0-SNAPSHOT</checkstyle.openrewrite.version>
     <rewrite-migrate-java.version>3.16.0</rewrite-migrate-java.version>
     <rewrite-static-analysis.version>2.16.0</rewrite-static-analysis.version>
+    <rewrite-third-party.version>0.26.0</rewrite-third-party.version>
     <java.version>17</java.version>
     <next.java.version>21</next.java.version>
     <maven.compiler.release>${java.version}</maven.compiler.release>
@@ -5334,6 +5335,7 @@
                 <recipe>org.checkstyle.CheckstyleAutoFix</recipe>
                 <recipe>org.openrewrite.java.migrate.Java8toJava11</recipe>
                 <recipe>org.openrewrite.staticanalysis.EqualsAvoidsNull</recipe>
+                <recipe>tech.picnic.errorprone.refasterrules.StreamRulesRecipes</recipe>
               </activeRecipes>
               <exclusions>
                 <exclusion>**.ci-temp**</exclusion>

src/main/java/com/puppycrawl/tools/checkstyle/PackageObjectFactory.java

@@ -328,8 +328,8 @@ public static String getShortFromFullModuleNames(String fullName) {
                 .entrySet()
                 .stream()
                 .filter(entry -> entry.getValue().equals(fullName))
-                .map(Entry::getKey)
                 .findFirst()
+                .map(Entry::getKey)
                 .orElse(fullName);
     }
 

src/main/java/com/puppycrawl/tools/checkstyle/site/ModuleJavadocParsingUtil.java

@@ -245,8 +245,8 @@ public static int getModuleSinceVersionTagStartIndex(DetailNode moduleJavadoc) {
                 return JavadocUtil
                     .findFirstToken(javadocTag, JavadocTokenTypes.SINCE_LITERAL) != null;
             })
-            .map(DetailNode::getIndex)
             .findFirst()
+            .map(DetailNode::getIndex)
             .orElse(-1);
     }
 

src/main/java/com/puppycrawl/tools/checkstyle/site/SiteUtil.java

@@ -847,8 +847,8 @@ public static Optional<DetailNode> getPropertyJavadocNodeInModule(String propert
 
         return liTagsInlineTexts.stream()
             .filter(text -> text.getText().equals(propertyName))
-            .map(textNode -> textNode.getParent().getParent())
-            .findFirst();
+            .findFirst()
+            .map(textNode -> textNode.getParent().getParent());
 
     }