Skip to content

Commit 967365b

Browse files
committed
take nodejs as dependency instead of npm, since npm is included in nodejs
1 parent 8d0e3ec commit 967365b

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

buildNodeModules.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
{lib,stdenv,runCommand,coreutils,fetchurl,npm}:
1+
{lib,stdenv,runCommand,coreutils,fetchurl,nodejs}:
22
{directory,buildInputs?[]}:
33
let
44
buildCache = import ./buildCache.nix {inherit lib runCommand coreutils fetchurl;};
55
cache = buildCache {packageLockPath = "${directory}/package-lock.json";};
66
derivation = stdenv.mkDerivation {
77
pname = "node_modules";
88
version = "";
9-
buildInputs=[npm coreutils]++buildInputs;
9+
buildInputs=[nodejs coreutils]++buildInputs;
1010
phases = ["buildPhase" "patchPhase" "fixupPhase" ];
1111
buildPhase = ''
1212
cp ${directory}/package-lock.json ./package-lock.json

examples/express-app/shell.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
with import <nixpkgs> {};
22

33
let
4-
buildNodeModules = callPackage ../../buildNodeModules.nix {npm = nodePackages.npm;};
4+
buildNodeModules = callPackage ../../buildNodeModules.nix {};
55
node_modules = import ./node_modules.nix {inherit buildNodeModules;};
66
express-app = callPackage ./default.nix {inherit nodejs node_modules;};
77
in
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{buildNodeModules,nodejs}: buildNodeModules {directory = ./.;buildInputs=[nodejs];}
1+
{buildNodeModules}: buildNodeModules {directory = ./.;}

examples/typescript-app/shell.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
with import <nixpkgs> {};
22

33
let
4-
buildNodeModules = callPackage ../../buildNodeModules.nix {npm = nodePackages.npm;};
5-
node_modules = import ./node_modules.nix {inherit buildNodeModules nodejs;};
4+
buildNodeModules = callPackage ../../buildNodeModules.nix {};
5+
node_modules = import ./node_modules.nix {inherit buildNodeModules;};
66
typescript-app = callPackage ./default.nix {inherit nodejs node_modules;};
77
in
88
mkShell {

0 commit comments

Comments
 (0)