Merge pull request php-annotations#93 from php-annotations/92-built-in-annotations-should-validate-their-value

Don't trigger notices during malformed `@param` annotation parsing

Author: Alexander Obuhovich

src/annotations/standard/ParamAnnotation.php

@@ -53,6 +53,11 @@ public static function parseAnnotation($value)
     {
         $parts = explode(' ', trim($value), 3);
 
+        if (count($parts) < 2) {
+            // Malformed value, let "initAnnotation" report about it.
+            return array();
+        }
+
         return array('type' => $parts[0], 'name' => substr($parts[1], 1));
     }
 

test/suite/Annotations.case.php

@@ -104,7 +104,8 @@ class SingleNonUsageAnnotation extends Annotation
 
 }
 
-class WrongInterfaceAnnotation {
+class WrongInterfaceAnnotation
+{
 
 }
 
@@ -252,6 +253,19 @@ class TestClassFileAwareAnnotation
 
 }
 
-interface TestInterface {
+interface TestInterface
+{
+
+}
+
+class BrokenParamAnnotationClass
+{
 
+    /**
+     * @param $paramName
+     */
+    protected function brokenParamAnnotation($paramName)
+    {
+
+    }
 }

test/suite/Annotations.test.php

@@ -46,7 +46,6 @@ public function run(xTestRunner $testRunner)
 
         // disable some annotations not used during testing:
         Annotations::getManager()->registry['var'] = false;
-        Annotations::getManager()->registry['param'] = false;
         Annotations::getManager()->registry['undefined'] = 'UndefinedAnnotation';
         $testRunner->stopCoverageCollector();
 
@@ -750,6 +749,17 @@ protected function testFilterUnresolvedAnnotationClass()
 
         $this->check($annotations === array(), 'empty annotation list when filtering failed');
     }
+
+    public function testMalformedParamAnnotationThrowsException()
+    {
+        $this->setExpectedException(
+            self::ANNOTATION_EXCEPTION,
+            'ParamAnnotation requires a type property'
+        );
+
+        Annotations::ofMethod('BrokenParamAnnotationClass', 'brokenParamAnnotation');
+    }
+
 }
 
 return new AnnotationsTest;