Skip to content

Commit e1979b9

Browse files
committed
fix: Change variable name from update to change
1 parent 4494e5e commit e1979b9

File tree

5 files changed

+38
-39
lines changed

5 files changed

+38
-39
lines changed

src/components/setting/SettingEmailRow.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,17 @@ import Button from '../common/Button';
77

88
export type SettingEmailRowProps = {
99
email: string;
10-
onUpdateEmail: (email: string) => Promise<void>;
10+
onChangeEmail: (email: string) => Promise<void>;
1111
};
1212

13-
function SettingEmailRow({ email, onUpdateEmail }: SettingEmailRowProps) {
13+
function SettingEmailRow({ email, onChangeEmail }: SettingEmailRowProps) {
1414
const [edit, setEdit] = useState(false);
1515
const [value, onChange] = useInput(email);
1616

1717
const onSubmit = async (e: React.FormEvent) => {
1818
e.preventDefault();
19-
await onUpdateEmail(value);
19+
//! TODO: 이메일 형식으로 입력하지 않을 경우 처리
20+
await onChangeEmail(value);
2021
setEdit(false);
2122
};
2223

src/components/setting/SettingRows.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export type SettingRowsProps = {
1414
username: string;
1515
email: string;
1616
onUpdateTitle: (title: string) => Promise<any>;
17-
onUpdateEmail: (email: string) => Promise<any>;
17+
onChangeEmail: (email: string) => Promise<any>;
1818
onUpdateSocialInfo: (profileLinks: ProfileLinks) => Promise<any>;
1919
onUpdateEmailRules: (params: {
2020
promotion: boolean;
@@ -42,7 +42,7 @@ function SettingRows({
4242
userMeta,
4343
email,
4444
onUpdateTitle,
45-
onUpdateEmail,
45+
onChangeEmail,
4646
onUpdateSocialInfo,
4747
onUpdateEmailRules,
4848
onUnregister,
@@ -54,7 +54,7 @@ function SettingRows({
5454
onUpdateTitle={onUpdateTitle}
5555
/>
5656
<SettingSocialInfoRow {...profileLinks} onUpdate={onUpdateSocialInfo} />
57-
<SettingEmailRow email={email} onUpdateEmail={onUpdateEmail} />
57+
<SettingEmailRow email={email} onChangeEmail={onChangeEmail} />
5858
{userMeta && (
5959
<SettingEmailRulesRow
6060
notification={userMeta.email_notification}

src/containers/setting/SettingRowsContainer.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import useUserProfile from './hooks/useUserProfile';
77
import useUpdateSocialInfo from './hooks/useUpdateSocialInfo';
88
import useUpdateEmailRules from './hooks/useUpdateEmailRules';
99
import useUnregister from './hooks/useUnregister';
10-
import useUpdateEmail from './hooks/useUpdateEmail';
10+
import useChangeEmail from './hooks/useChangeEmail';
1111

1212
export type SettingRowsContainerProps = {};
1313

@@ -17,7 +17,7 @@ function SettingRowsContainer(props: SettingRowsContainerProps) {
1717
const user = useSelector((state: RootState) => state.core.user);
1818
const updateSocialInfo = useUpdateSocialInfo();
1919
const { update: updateEmailRules } = useUpdateEmailRules();
20-
const { update: updateEmail } = useUpdateEmail();
20+
const { change: changeEmail } = useChangeEmail();
2121
const unregister = useUnregister();
2222

2323
const onUpdateEmailRules = useCallback(
@@ -44,7 +44,7 @@ function SettingRowsContainer(props: SettingRowsContainerProps) {
4444
username={user.username}
4545
email={user.email}
4646
onUpdateTitle={updateTitle}
47-
onUpdateEmail={updateEmail}
47+
onChangeEmail={changeEmail}
4848
profileLinks={profile.profile_links}
4949
onUpdateSocialInfo={updateSocialInfo.update}
5050
onUpdateEmailRules={onUpdateEmailRules}
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import { useMutation } from '@apollo/react-hooks';
2+
import gql from 'graphql-tag';
3+
import { useCallback } from 'react';
4+
5+
const CHANGE_EMAIL = gql`
6+
mutation ChangeEmail($email: String!) {
7+
changeEmail(email: $email)
8+
}
9+
`;
10+
11+
export default function useChangeEmail() {
12+
const [changeEmail] = useMutation(CHANGE_EMAIL);
13+
14+
const change = useCallback(
15+
(email: string) => {
16+
return changeEmail({
17+
variables: {
18+
email,
19+
},
20+
});
21+
},
22+
[changeEmail],
23+
);
24+
25+
return {
26+
change,
27+
};
28+
}

src/containers/setting/hooks/useUpdateEmail.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)