Fix a few for TcpListenerWebSocketContext.cs

Author: sta

websocket-sharp/Ext.cs

@@ -510,9 +510,9 @@ internal static string GetValueInternal (this string nameAndValue, string separa
     }
 
     internal static TcpListenerWebSocketContext GetWebSocketContext (
-      this TcpClient client, string protocol, X509Certificate cert, bool secure, Logger logger)
+      this TcpClient client, string protocol, bool secure, X509Certificate cert, Logger logger)
     {
-      return new TcpListenerWebSocketContext (client, protocol, cert, secure, logger);
+      return new TcpListenerWebSocketContext (client, protocol, secure, cert, logger);
     }
 
     internal static bool IsCompressionExtension (this string value)

websocket-sharp/Net/WebSockets/TcpListenerWebSocketContext.cs

@@ -59,14 +59,12 @@ public class TcpListenerWebSocketContext : WebSocketContext
     #region Internal Constructors
 
     internal TcpListenerWebSocketContext (
-      TcpClient client, string protocol, X509Certificate cert, bool secure, Logger logger)
+      TcpClient client, string protocol, bool secure, X509Certificate cert, Logger logger)
     {
       _client = client;
       _secure = secure;
-      _stream = WsStream.CreateServerStream (client, cert, secure);
-      _request = _stream.ReadHandshake<HandshakeRequest> (
-        HandshakeRequest.Parse, 90000);
-
+      _stream = WsStream.CreateServerStream (client, secure, cert);
+      _request = _stream.ReadHandshake<HandshakeRequest> (HandshakeRequest.Parse, 90000);
       _websocket = new WebSocket (this, protocol, logger);
     }
 
@@ -326,8 +324,8 @@ private Uri createRequestUri ()
       var host = _request.Headers ["Host"];
       var rawUri = _request.RequestUri;
       var path = rawUri.IsAbsoluteUri
-               ? rawUri.PathAndQuery
-               : HttpUtility.UrlDecode (_request.RawUrl);
+                 ? rawUri.PathAndQuery
+                 : HttpUtility.UrlDecode (_request.RawUrl);
 
       return String.Format ("{0}://{1}{2}", scheme, host, path).ToUri ();
     }
@@ -356,37 +354,37 @@ internal void SendAuthChallenge (string challenge)
     }
 
     internal void SetUser (
-      AuthenticationSchemes expectedScheme,
+      AuthenticationSchemes scheme,
       string realm,
       Func<IIdentity, NetworkCredential> credentialsFinder)
     {
       var authRes = _request.AuthResponse;
       if (authRes == null)
         return;
 
-      var identity = authRes.ToIdentity ();
-      if (identity == null)
+      var id = authRes.ToIdentity ();
+      if (id == null)
         return;
 
-      NetworkCredential credentials = null;
+      NetworkCredential cred = null;
       try {
-        credentials = credentialsFinder (identity);
+        cred = credentialsFinder (id);
       }
       catch {
       }
 
-      if (credentials == null)
+      if (cred == null)
         return;
 
-      var valid = expectedScheme == AuthenticationSchemes.Basic
-                ? ((HttpBasicIdentity) identity).Password == credentials.Password
-                : expectedScheme == AuthenticationSchemes.Digest
-                  ? ((HttpDigestIdentity) identity).IsValid (
-                      credentials.Password, realm, _request.HttpMethod, null)
-                  : false;
+      var valid = scheme == AuthenticationSchemes.Basic
+                  ? ((HttpBasicIdentity) id).Password == cred.Password
+                  : scheme == AuthenticationSchemes.Digest
+                    ? ((HttpDigestIdentity) id).IsValid (
+                        cred.Password, realm, _request.HttpMethod, null)
+                    : false;
 
       if (valid)
-        _user = new GenericPrincipal (identity, credentials.Roles);
+        _user = new GenericPrincipal (id, cred.Roles);
     }
 
     #endregion

websocket-sharp/Server/WebSocketServer.cs

@@ -476,7 +476,7 @@ private void acceptRequestAsync (TcpClient client)
       ThreadPool.QueueUserWorkItem (
         state => {
           try {
-            var context = client.GetWebSocketContext (null, _cert, _secure, _logger);
+            var context = client.GetWebSocketContext (null, _secure, _cert, _logger);
             if (_authSchemes != AuthenticationSchemes.Anonymous &&
                 !authenticateRequest (_authSchemes, context))
               return;

websocket-sharp/WsStream.cs

@@ -163,7 +163,7 @@ internal static WsStream CreateClientStream (
     }
 
     internal static WsStream CreateServerStream (
-      TcpClient client, X509Certificate cert, bool secure)
+      TcpClient client, bool secure, X509Certificate cert)
     {
       var netStream = client.GetStream ();
       if (secure) {