When talking to a SSL proxy, AHC should use relative URIs by default, close AsyncHttpClient#509

Author: Stephane Landelle

src/main/java/com/ning/http/client/AsyncHttpClientConfig.java

@@ -15,6 +15,8 @@
  */
 package com.ning.http.client;
 
+import static com.ning.http.util.MiscUtil.getBoolean;
+
 import com.ning.http.client.date.TimeConverter;
 import com.ning.http.client.filter.IOExceptionFilter;
 import com.ning.http.client.filter.RequestFilter;
@@ -539,7 +541,7 @@ public static class Builder {
         private boolean useProxyProperties = Boolean.getBoolean(ASYNC_CLIENT + "useProxyProperties");
         private boolean useProxySelector = Boolean.getBoolean(ASYNC_CLIENT + "useProxySelector");
         private boolean allowPoolingConnection = true;
-        private boolean useRelativeURIsWithSSLProxies = Boolean.getBoolean(ASYNC_CLIENT + "useRelativeURIsWithSSLProxies");
+        private boolean useRelativeURIsWithSSLProxies = getBoolean(ASYNC_CLIENT + "useRelativeURIsWithSSLProxies", true);
         private ExecutorService applicationThreadPool;
         private ProxyServerSelector proxyServerSelector = null;
         private SSLContext sslContext;

src/main/java/com/ning/http/util/MiscUtil.java

@@ -23,7 +23,7 @@ private MiscUtil() {
     public static boolean isNonEmpty(String string) {
         return string != null && string.length() != 0;
     }
-    
+
     public static boolean isNonEmpty(Object[] array) {
         return array != null && array.length != 0;
     }
@@ -39,4 +39,9 @@ public static boolean isNonEmpty(Collection<?> collection) {
     public static boolean isNonEmpty(Map<?, ?> map) {
         return map != null && !map.isEmpty();
     }
+
+    public static boolean getBoolean(String systemPropName, boolean defaultValue) {
+        String systemPropValue = System.getProperty(systemPropName);
+        return systemPropValue != null ? systemPropValue.equalsIgnoreCase("true") : defaultValue;
+    }
 }