Skip to content

Commit f2ed6e0

Browse files
authored
chore(proc): Update repo's settings (GoogleCloudPlatform#8957)
Configure Java 11 and Java 17 runtime checks as required. Explain about what checks are run vs. any submitted change. Provide recommendation about Java runtime version that should be used to build code samples.
1 parent d55907f commit f2ed6e0

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/sync-repo-settings.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ branchProtectionRules:
66
isAdminEnforced: true
77
requiredStatusCheckContexts:
88
- 'Kokoro CI - Java 11'
9+
- 'Kokoro CI - Java 17'
910
- 'Kokoro CI - Lint'
1011
- 'cla/google'
1112
requiredApprovingReviewCount: 1

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,12 @@ To browse ready to use code samples check [Google Cloud Samples](https://cloud.g
4848

4949
## Supported Java runtimes
5050

51-
The minimal supported Java runtime is Java 11.
52-
Testing of the code samples in Java 8 runtime is discontinued.
53-
Code samples that are build with older Java runtimes (e.g. Java 8) are requested to pass tests with Java 11.
54-
Code samples designated to build and run with Java 8 will be removed at end of support for Java 8 in GCP.
51+
Every submitted change has to pass all checks that run on the testing environments with Java 11 and Java 17 runtimes before merging the change to the main branch.
52+
We run periodic checks on the environments with Java 8 and Java 21 runtimes but we don't enforce passing these tests at the moment.
53+
Because Java 8 is a [supported Java runtime][supported_runtimes] in Google Cloud, please configure to build your code sample with Java 8.
54+
In exceptional cases, configure to build your code sample using Java 11.
55+
56+
[supported_runtimes]: https://cloud.google.com/java/docs/supported-java-versions
5557

5658
## Source Code Headers
5759

0 commit comments

Comments
 (0)