Skip to content

Commit ad181df

Browse files
committed
i2c: PEP8 compliance.
1 parent 2a682a1 commit ad181df

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

i2c/asi2c.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
# Initiator sets up first.
3838
_DELAY = const(20) # μs
3939

40+
4041
# Base class provides user interface and send/receive object buffers
4142
class Channel(io.IOBase):
4243
def __init__(self, i2c, own, rem, verbose, rxbufsize):
@@ -80,7 +81,7 @@ def _txdone(self):
8081
self.txsiz[0] = 0
8182
self.txsiz[1] = 0
8283

83-
# Stream interface
84+
# Stream interface
8485

8586
def ioctl(self, req, arg):
8687
ret = _MP_STREAM_ERROR
@@ -102,7 +103,7 @@ def readline(self):
102103
self.rxbyt = b''
103104
else:
104105
t = self.rxbyt[: n + 1]
105-
self.rxbyt = self.rxbyt[n + 1 :]
106+
self.rxbyt = self.rxbyt[n + 1:]
106107
return t.decode()
107108

108109
def read(self, n):
@@ -120,7 +121,7 @@ def write(self, buf, off, sz):
120121
if off == 0 and sz == len(buf):
121122
d = buf
122123
else:
123-
d = buf[off : off + sz]
124+
d = buf[off: off + sz]
124125
d = d.encode()
125126
l = len(d)
126127
self.txbyt = d
@@ -129,7 +130,7 @@ def write(self, buf, off, sz):
129130
return l
130131
return 0
131132

132-
# User interface
133+
# User interface
133134

134135
# Wait for sync
135136
async def ready(self):
@@ -140,27 +141,29 @@ async def ready(self):
140141
def close(self):
141142
self.own(1)
142143

144+
143145
# Responder is I2C master. It is cross-platform and uses machine.
144146
# It does not handle errors: if I2C fails it dies and awaits reset by initiator.
145147
# send_recv is triggered by Interrupt from Initiator.
146148

147149
class Responder(Channel):
148150
addr = 0x12
149151
rxbufsize = 200
152+
150153
def __init__(self, i2c, pin, pinack, verbose=True):
151154
super().__init__(i2c, pinack, pin, verbose, self.rxbufsize)
152155
loop = asyncio.get_event_loop()
153156
loop.create_task(self._run())
154157

155158
async def _run(self):
156159
await self._sync() # own pin ->0, wait for remote pin == 0
157-
self.rem.irq(handler = self._handler, trigger = machine.Pin.IRQ_RISING)
160+
self.rem.irq(handler=self._handler, trigger=machine.Pin.IRQ_RISING)
158161

159162
# Request was received: immediately read payload size, then payload
160163
# On Pyboard blocks for 380μs to 1.2ms for small amounts of data
161164
def _handler(self, _, sn=bytearray(2), txnull=bytearray(2)):
162165
addr = Responder.addr
163-
self.rem.irq(handler = None, trigger = machine.Pin.IRQ_RISING)
166+
self.rem.irq(handler=None, trigger=machine.Pin.IRQ_RISING)
164167
utime.sleep_us(_DELAY) # Ensure Initiator has set up to write.
165168
self.i2c.readfrom_into(addr, sn)
166169
self.own(1)
@@ -173,7 +176,7 @@ def _handler(self, _, sn=bytearray(2), txnull=bytearray(2)):
173176
if n:
174177
self.waitfor(1)
175178
utime.sleep_us(_DELAY)
176-
mv = memoryview(self.rx_mv[0 : n]) # allocates
179+
mv = memoryview(self.rx_mv[0: n]) # allocates
177180
self.i2c.readfrom_into(addr, mv)
178181
self.own(1)
179182
self.waitfor(0)
@@ -200,4 +203,4 @@ def _handler(self, _, sn=bytearray(2), txnull=bytearray(2)):
200203
self.own(0)
201204
self.waitfor(0)
202205
self._txdone() # Invalidate source
203-
self.rem.irq(handler = self._handler, trigger = machine.Pin.IRQ_RISING)
206+
self.rem.irq(handler=self._handler, trigger=machine.Pin.IRQ_RISING)

i2c/asi2c_i.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import gc
3030
from asi2c import Channel
3131

32+
3233
# The initiator is an I2C slave. It runs on a Pyboard. I2C uses pyb for slave
3334
# mode, but pins are instantiated using machine.
3435
# reset (if provided) is a means of resetting Responder in case of error: it
@@ -46,7 +47,7 @@ def __init__(self, i2c, pin, pinack, reset=None, verbose=True,
4647
self.cr_fail = cr_fail
4748
self.f_args = f_args
4849
if reset is not None:
49-
reset[0].init(mode=machine.Pin.OUT, value = not(reset[1]))
50+
reset[0].init(mode=machine.Pin.OUT, value=not (reset[1]))
5051
# Self measurement
5152
self.nboots = 0 # No. of reboots of Responder
5253
self.block_max = 0 # Blocking times: max
@@ -109,7 +110,7 @@ def _sendrx(self, sn=bytearray(2), txnull=bytearray(2)):
109110
# send. Send must start before RX begins. Fast responders may need to
110111
# do a short blocking wait to guarantee this.
111112
self.own(1) # Trigger interrupt.
112-
self.i2c.send(siz) # Blocks until RX complete.
113+
self.i2c.send(siz) # Blocks until RX complete.
113114
self.waitfor(1)
114115
self.own(0)
115116
self.waitfor(0)
@@ -132,9 +133,9 @@ def _sendrx(self, sn=bytearray(2), txnull=bytearray(2)):
132133
self.cantx = not bool(sn[1] & 0x80)
133134
if n:
134135
self.waitfor(1) # Wait for responder to request send
135-
#print('setting up receive', n,' bytes')
136+
# print('setting up receive', n,' bytes')
136137
self.own(1) # Acknowledge
137-
mv = memoryview(self.rx_mv[0 : n])
138+
mv = memoryview(self.rx_mv[0: n])
138139
self.i2c.recv(mv)
139140
self.waitfor(0)
140141
self.own(0)

0 commit comments

Comments
 (0)