nit

Author: slandelle

netty-utils/src/main/java/org/asynchttpclient/netty/util/ByteBufUtils.java

@@ -16,7 +16,6 @@
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 
-import java.nio.charset.CharacterCodingException;
 import java.nio.charset.Charset;
 
 import static java.nio.charset.StandardCharsets.*;
@@ -49,11 +48,11 @@ public static String byteBuf2StringDefault(Charset charset, ByteBuf... bufs) {
     }
   }
 
-  public static String byteBuf2String(Charset charset, ByteBuf buf) throws CharacterCodingException {
+  public static String byteBuf2String(Charset charset, ByteBuf buf) {
     return isUtf8OrUsAscii(charset) ? Utf8ByteBufCharsetDecoder.decodeUtf8(buf) : buf.toString(charset);
   }
 
-  public static String byteBuf2String(Charset charset, ByteBuf... bufs) throws CharacterCodingException {
+  public static String byteBuf2String(Charset charset, ByteBuf... bufs) {
     return isUtf8OrUsAscii(charset) ? Utf8ByteBufCharsetDecoder.decodeUtf8(bufs) : byteBuf2StringDefault(charset, bufs);
   }
 

netty-utils/src/main/java/org/asynchttpclient/netty/util/Utf8ByteBufCharsetDecoder.java

@@ -29,7 +29,7 @@ public class Utf8ByteBufCharsetDecoder {
   private static final int UTF_8_MAX_BYTES_PER_CHAR = 4;
   private static final char INVALID_CHAR_REPLACEMENT = '�';
 
-  private static final ThreadLocal<Utf8ByteBufCharsetDecoder> POOL = ThreadLocal.withInitial(() -> new Utf8ByteBufCharsetDecoder());
+  private static final ThreadLocal<Utf8ByteBufCharsetDecoder> POOL = ThreadLocal.withInitial(Utf8ByteBufCharsetDecoder::new);
   private final CharsetDecoder decoder = configureReplaceCodingErrorActions(UTF_8.newDecoder());
   protected CharBuffer charBuffer = allocateCharBuffer(INITIAL_CHAR_BUFFER_SIZE);
   private ByteBuffer splitCharBuffer = ByteBuffer.allocate(UTF_8_MAX_BYTES_PER_CHAR);
@@ -161,14 +161,14 @@ protected void decodePartial(ByteBuffer nioBuffer, boolean endOfInput) {
     }
   }
 
-  private void decode(ByteBuffer[] nioBuffers, int length) {
+  private void decode(ByteBuffer[] nioBuffers) {
     int count = nioBuffers.length;
     for (int i = 0; i < count; i++) {
       decodePartial(nioBuffers[i].duplicate(), i == count - 1);
     }
   }
 
-  private void decodeSingleNioBuffer(ByteBuffer nioBuffer, int length) {
+  private void decodeSingleNioBuffer(ByteBuffer nioBuffer) {
     decoder.decode(nioBuffer, charBuffer, true);
   }
 
@@ -181,9 +181,9 @@ public String decode(ByteBuf buf) {
     ensureCapacity(length);
 
     if (buf.nioBufferCount() == 1) {
-      decodeSingleNioBuffer(buf.internalNioBuffer(buf.readerIndex(), length).duplicate(), length);
+      decodeSingleNioBuffer(buf.internalNioBuffer(buf.readerIndex(), length).duplicate());
     } else {
-      decode(buf.nioBuffers(), buf.readableBytes());
+      decode(buf.nioBuffers());
     }
 
     return charBuffer.flip().toString();
@@ -219,7 +219,7 @@ public String decode(ByteBuf... bufs) {
       }
 
       ensureCapacity(totalSize);
-      decode(nioBuffers, totalSize);
+      decode(nioBuffers);
 
       return charBuffer.flip().toString();
     }