Merge pull request spring-projects#9 from stuartstevenson/master

MappingBuilder circular reference issue

Author: akonczak

src/main/java/org/springframework/data/elasticsearch/annotations/Field.java

@@ -43,4 +43,6 @@
 
     String indexAnalyzer() default "";
 
+    String [] ignoreFields() default {};
+
 }

src/main/java/org/springframework/data/elasticsearch/core/MappingBuilder.java

@@ -24,6 +24,7 @@
 import org.springframework.data.util.TypeInformation;
 
 import java.io.IOException;
+import java.util.Arrays;
 import java.util.Map;
 
 import static org.apache.commons.lang.StringUtils.EMPTY;
@@ -71,7 +72,7 @@ private static void mapEntity(XContentBuilder xContentBuilder, Class clazz, bool
         }
 
         for (java.lang.reflect.Field field : fields) {
-            if (isEntity(field)) {
+            if (isEntity(field)  && !isInIgnoreFields(field)) {
                 mapEntity(xContentBuilder, field.getType(), false, EMPTY, field.getName());
             }
 
@@ -246,4 +247,13 @@ private static boolean isAnyPropertyAnnotatedAsField(java.lang.reflect.Field[] f
     private static boolean isIdField(java.lang.reflect.Field field, String idFieldName) {
         return idFieldName.equals(field.getName());
     }
+
+    private static boolean isInIgnoreFields(java.lang.reflect.Field field) {
+        Field fieldAnnotation = field.getAnnotation(Field.class);
+        if ( null != fieldAnnotation ) {
+            String [] ignoreFields = fieldAnnotation.ignoreFields();
+            return Arrays.asList(ignoreFields).contains(field.getName());
+        }
+        return false;
+    }
 }

src/test/java/org/springframework/data/elasticsearch/core/CircularObject.java

@@ -0,0 +1,18 @@
+package org.springframework.data.elasticsearch.core;
+
+import org.springframework.data.annotation.Id;
+import org.springframework.data.elasticsearch.annotations.Document;
+import org.springframework.data.elasticsearch.annotations.Field;
+import org.springframework.data.elasticsearch.annotations.FieldType;
+
+/**
+ * @author Stuart Stevenson
+ */
+@Document(indexName = "circular-objects", type = "circular-object" , indexStoreType = "memory", shards = 1, replicas = 0, refreshInterval = "-1")
+public class CircularObject {
+
+    @Id
+    private String id;
+    @Field(type = FieldType.Object, ignoreFields = {"circularObject"})
+    private CircularObject circularObject;
+}

src/test/java/org/springframework/data/elasticsearch/core/MappingBuilderTests.java

@@ -0,0 +1,25 @@
+package org.springframework.data.elasticsearch.core;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
+
+/**
+ * @author Stuart Stevenson
+ */
+@RunWith(SpringJUnit4ClassRunner.class)
+@ContextConfiguration("classpath:elasticsearch-template-test.xml")
+public class MappingBuilderTests {
+
+    @Autowired
+    private ElasticsearchTemplate elasticsearchTemplate;
+
+    @Test
+    public void shouldNotFailOnCircularReference() {
+        elasticsearchTemplate.createIndex(CircularObject.class);
+        elasticsearchTemplate.putMapping(CircularObject.class);
+    }
+
+}