Skip to content

Commit e4cfb9d

Browse files
metawetaIgorMinar
authored andcommitted
refactor(Angular.js): prevent Error variable name leak in tests
Remove var Error = window.Error window.Error is a read-only property in Apps Script. Igor says, "we should just delete that line instead. I think it was misko's attempt to get better closure minification, but it turns out that it's actually hurting us after gzip (I verified it)."
1 parent 87ba822 commit e4cfb9d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/Angular.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ if ('i' !== 'I'.toLowerCase()) {
4949
function fromCharCode(code) {return String.fromCharCode(code);}
5050

5151

52-
var Error = window.Error,
53-
/** holds major version number for IE or NaN for real browsers */
52+
var /** holds major version number for IE or NaN for real browsers */
5453
msie = int((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]),
5554
jqLite, // delay binding since jQuery could be loaded after us.
5655
jQuery, // delay binding

0 commit comments

Comments
 (0)