Skip to content

Commit 7f1d26d

Browse files
committed
Updated Test (Scan and Scroll) which was causing build failure
1 parent b5873cb commit 7f1d26d

File tree

1 file changed

+35
-9
lines changed

1 file changed

+35
-9
lines changed

src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java

Lines changed: 35 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -555,18 +555,20 @@ public void shouldReturnResultsWithScanAndScroll() {
555555
indexQuery2.setObject(sampleEntity2);
556556

557557
indexQueries.add(indexQuery2);
558+
559+
List<IndexQuery> entities = createSampleEntitiesWithMessage("Test message", 30);
558560
// when
559-
elasticsearchTemplate.bulkIndex(indexQueries);
561+
elasticsearchTemplate.bulkIndex(entities);
560562
elasticsearchTemplate.refresh(SampleEntity.class, true);
561563
// then
562564

563565
SearchQuery searchQuery = new NativeSearchQueryBuilder().withQuery(matchAllQuery()).withIndices("test-index")
564-
.withTypes("test-type").withPageable(new PageRequest(0, 1)).build();
566+
.withTypes("test-type").withPageable(new PageRequest(0, 10)).build();
565567

566568
String scrollId = elasticsearchTemplate.scan(searchQuery, 1000, false);
567569
List<SampleEntity> sampleEntities = new ArrayList<SampleEntity>();
568570
boolean hasRecords = true;
569-
while (hasRecords) {
571+
while (hasRecords) {
570572
Page<SampleEntity> page = elasticsearchTemplate.scroll(scrollId, 5000L, new ResultsMapper<SampleEntity>() {
571573
@Override
572574
public Page<SampleEntity> mapResults(SearchResponse response) {
@@ -580,21 +582,45 @@ public Page<SampleEntity> mapResults(SearchResponse response) {
580582
user.setMessage((String) searchHit.getSource().get("message"));
581583
chunk.add(user);
582584
}
583-
return new PageImpl<SampleEntity>(chunk);
585+
if(chunk.size() > 0){
586+
587+
return new PageImpl<SampleEntity>(chunk);
588+
}
589+
return null;
584590
}
585591

586592
});
587593
if (page != null) {
588594
sampleEntities.addAll(page.getContent());
589-
hasRecords = page.hasNextPage();
590-
} else {
591-
hasRecords = false;
592-
}
595+
} else {
596+
hasRecords = false;
597+
}
593598

594599
}
595-
assertThat(sampleEntities.size(), is(equalTo(2)));
600+
assertThat(sampleEntities.size(), is(equalTo(30)));
596601
}
597602

603+
private static List<IndexQuery> createSampleEntitiesWithMessage(String message, int numberOfEntities) {
604+
List<SampleEntity> sampleEntities = new ArrayList<SampleEntity>();
605+
List<IndexQuery> indexQueries = new ArrayList<IndexQuery>();
606+
for (int i = 0; i < numberOfEntities; i++) {
607+
String documentId = randomNumeric(5);
608+
SampleEntity sampleEntity = new SampleEntity();
609+
sampleEntity.setId(documentId);
610+
sampleEntity.setMessage(message);
611+
sampleEntity.setRate(2);
612+
sampleEntity.setVersion(System.currentTimeMillis());
613+
IndexQuery indexQuery2 = new IndexQuery();
614+
indexQuery2.setId(documentId);
615+
indexQuery2.setObject(sampleEntity);
616+
617+
indexQueries.add(indexQuery2);
618+
sampleEntities.add(sampleEntity);
619+
620+
}
621+
return indexQueries;
622+
}
623+
598624
@Test
599625
public void shouldReturnListForGivenCriteria() {
600626
// given

0 commit comments

Comments
 (0)