Fix tests

Tests had one big mistake - setTimeout executed after test case passed. In other words - no checks are performed inside `setTimeout` calls.
The other thing is that we don't check if scrollTop is changed, but I don't know how to test it correctly

Author: bethrezen

test/spec/spec-smoothScroll.js

@@ -3,29 +3,58 @@ describe('Smooth Scroll', function () {
 	//
 	// Helper Methods
 	//
-
+	var removeElements = function() {
+		var p = document.querySelector('p');
+		if (p && p.remove) {
+			p.remove();
+		}
+		var a = document.querySelector('a');
+		if (a && a.remove) {
+			a.remove();
+		}
+		var target = document.querySelector('div');
+		if (target && target.remove) {
+			target.remove();
+		}
+	};
 	/**
-	* Create a link element, add it to the body.
-	* @public
-	* @param {String} the href attribute of the new link
-	* @param {Boolean} whether to add data-scroll to the link or not
-	* @returns {Element}
-	*/
+	 * Create a link element, add it to the body.
+	 * @public
+	 * @param {String} the href attribute of the new link
+	 * @param {Boolean} whether to add data-scroll to the link or not
+	 * @returns {Element}
+	 */
 	var injectElem = function (href, smooth) {
+		removeElements();
+
 		var elt = document.createElement('a');
 		elt.href = href;
+		elt.style.background = '#f0f';
+		elt.textContent="newtext";
 		if (smooth) {
 			elt.setAttribute('data-scroll', true);
 		}
 		document.body.appendChild(elt);
+
+		var p = document.createElement('p');
+		p.style.height = '20000px';
+		p.style.background = '#f00';
+		document.body.appendChild(p);
+
+		var target = document.createElement('div');
+		target.id = 'target';
+		target.style.height = '200px';
+		target.style.background = '#0ff';
+		document.body.appendChild(target);
+		window.top.callPhantom({type: 'render', fname: './myscreen.png'});
 		return elt;
 	};
 
 	/**
-	* Simulate a click event.
-	* @public
-	* @param {Element} the element to simulate a click on
-	*/
+	 * Simulate a click event.
+	 * @public
+	 * @param {Element} the element to simulate a click on
+	 */
 	var simulateClick = function (elt) {
 		var click = document.createEvent('MouseEvents');
 		click.initMouseEvent('click', true, true, window, 1, 0, 0, 0, 0, false, false, false, false, 0, null);
@@ -70,18 +99,19 @@ describe('Smooth Scroll', function () {
 
 	describe('Should merge user options into defaults', function () {
 
-		var elt = injectElem('#anchor', true);
+		var elt = injectElem('#target', true);
 
 		beforeEach(function () {
 			smoothScroll.init({
 				callback: function () { document.documentElement.classList.add('callback'); }
 			});
 		});
 
-		it('User options should be merged into defaults', function () {
+		it('User options should be merged into defaults', function (done) {
 			simulateClick(elt);
 			setTimeout(function() {
 				expect(document.documentElement.classList.contains('callback')).toBe(true);
+				done();
 			}, 200);
 		});
 
@@ -93,8 +123,8 @@ describe('Smooth Scroll', function () {
 	//
 
 	describe('Should animate scroll when anchor clicked', function () {
-		var elt = injectElem('#anchor', true);
-		document.body.id = 'anchor';
+		var elt = injectElem('#target', true);
+		// document.body.id = 'anchor';
 
 		beforeEach(function() {
 			spyOn(smoothScroll, 'animateScroll');
@@ -104,11 +134,13 @@ describe('Smooth Scroll', function () {
 			smoothScroll.destroy();
 		});
 
-		it('Should trigger smooth scrolling on click', function () {
+
+		it('Should trigger smooth scrolling on click', function (done) {
 			smoothScroll.init();
 			simulateClick(elt);
 			setTimeout(function() {
-				expect(smoothScroll.animateScroll).toHaveBeenCalledWith(elt, '#anchor', jasmine.objectContaining(settingsStub));
+				expect(smoothScroll.animateScroll).toHaveBeenCalledWith('#target', elt, jasmine.objectContaining(settingsStub));
+				done();
 			}, 200);
 		});
 
@@ -117,13 +149,14 @@ describe('Smooth Scroll', function () {
 			expect(smoothScroll.animateScroll).not.toHaveBeenCalled();
 		});
 
-		it('Should do nothing if destroyed', function () {
+		it('Should do nothing if destroyed', function (done) {
 			smoothScroll.init();
 			smoothScroll.destroy();
 			simulateClick(elt);
 			setTimeout(function() {
 				expect(smoothScroll.animateScroll).not.toHaveBeenCalled();
+				done();
 			}, 200);
 		});
 	});
-});
+});