JWT Unit Test with email verification + Standardjs Format + Codeclimate

Author: silverbux

.codeclimate.yml

@@ -11,4 +11,8 @@ languages:
   PHP: true
   Python: false
 exclude_paths:
+- "gulpfile.js"
 - "public/js/vendor.js"
+- "public/dist/js/app.js"
+- "tasks/**"
+- "tests/**"

.eslintrc

@@ -15,6 +15,10 @@
   "globals": {
     "angular": true,
     "module": true,
-    "inject": true
+    "inject": true,
+    "jQuery": true,
+    "$": true,
+    "swal": true,
+    "ngDescribe": true
   }
 }

README.md

@@ -5,7 +5,10 @@ Plus Oauth and JWT authentication on the side.
 [![Build Status](https://travis-ci.org/silverbux/laravel-angular-admin.svg?branch=master)](https://travis-ci.org/silverbux/laravel-angular-admin)
 [![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg)](http://standardjs.com/)
 [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://raw.githubusercontent.com/silverbux/laravel-angular-admin/master/LICENSE)
-[![wercker status](https://app.wercker.com/status/92444e926f721c992f7f41c605d5cbc4/s/master "wercker status")](https://app.wercker.com/project/bykey/92444e926f721c992f7f41c605d5cbc4)
+[![Code Climate](https://codeclimate.com/github/silverbux/laravel-angular-admin/badges/gpa.svg)](https://codeclimate.com/github/silverbux/laravel-angular-admin)
+[![Issue Count](https://codeclimate.com/github/silverbux/laravel-angular-admin/badges/issue_count.svg)](https://codeclimate.com/github/silverbux/laravel-angular-admin)
+
+[![wercker status](https://app.wercker.com/status/92444e926f721c992f7f41c605d5cbc4/m "wercker status")](https://app.wercker.com/project/bykey/92444e926f721c992f7f41c605d5cbc4)
 
 ## Screenshots
 ![Dashboard Screenshot](https://cloud.githubusercontent.com/assets/1888261/14597104/53b404b6-057d-11e6-876d-c83630686590.png)

angular/app/components/coming-soon/coming-soon.component.js

@@ -1,19 +1,16 @@
-class ComingSoonController{
-    constructor(){
-        'ngInject';
+class ComingSoonController {
+  constructor () {
+    'ngInject'
 
-        //
-    }
+  //
+  }
 
-    $onInit(){
-    }
+  $onInit () {}
 }
 
 export const ComingSoonComponent = {
-    templateUrl: './views/app/components/coming-soon/coming-soon.component.html',
-    controller: ComingSoonController,
-    controllerAs: 'vm',
-    bindings: {}
+  templateUrl: './views/app/components/coming-soon/coming-soon.component.html',
+  controller: ComingSoonController,
+  controllerAs: 'vm',
+  bindings: {}
 }
-
-

angular/app/components/create_post_form/create_post_form.component.html

@@ -9,9 +9,7 @@ class DashboardController {
       [28, 48, 40, 19, 86, 27, 90]
     ]
 
-    $scope.onClick = function () {
-
-    }
+    $scope.onClick = function () {}
 
     $scope.pieLabels = ['Download Sales', 'In-Store Sales', 'Mail-Order Sales']
     $scope.pieData = [300, 500, 100]

angular/app/components/create_post_form/create_post_form.component.js

@@ -61,13 +61,13 @@ class UserPermissionsController {
       API.one('users').one('permissions', permissionId).remove()
         .then(() => {
           swal({
-              title: "Deleted!",
-              text: "User Permission has been deleted.",
-              type: "success",
-              confirmButtonText: "OK",
-              closeOnConfirm: true
-          }, function() {
-              $state.reload()
+            title: 'Deleted!',
+            text: 'User Permission has been deleted.',
+            type: 'success',
+            confirmButtonText: 'OK',
+            closeOnConfirm: true
+          }, function () {
+            $state.reload()
           })
         })
     })

angular/app/components/create_post_form/create_post_form.less

@@ -1,25 +1,21 @@
-class UserVerificationController{
-    constructor($stateParams){
-        'ngInject';
-        this.alerts = []
-
-        if($stateParams.status === 'success') {
-            this.alerts.push({ type: 'success', 'title': 'Success!', msg: 'Email Verification Success.' })
-        } else {
-            this.alerts.push({ type: 'danger', 'title': 'Error:', msg: 'Email verification failed.' })
-        }
+class UserVerificationController {
+  constructor ($stateParams) {
+    'ngInject'
+    this.alerts = []
 
+    if ($stateParams.status === 'success') {
+      this.alerts.push({ type: 'success', 'title': 'Success!', msg: 'Email Verification Success.' })
+    } else {
+      this.alerts.push({ type: 'danger', 'title': 'Error:', msg: 'Email verification failed.' })
     }
+  }
 
-    $onInit(){
-    }
+  $onInit () {}
 }
 
 export const UserVerificationComponent = {
-    templateUrl: './views/app/components/user-verification/user-verification.component.html',
-    controller: UserVerificationController,
-    controllerAs: 'vm',
-    bindings: {}
+  templateUrl: './views/app/components/user-verification/user-verification.component.html',
+  controller: UserVerificationController,
+  controllerAs: 'vm',
+  bindings: {}
 }
-
-

angular/app/components/dashboard/dashboard.component.js

@@ -8,5 +8,5 @@ export function AclConfig (AclServiceProvider) {
 
   /*eslint-disable */
   AclServiceProvider.config(myConfig)
-  /*eslint-enable */
+/*eslint-enable */
 }

angular/app/components/user-permissions/user-permissions.component.js

@@ -1,5 +1,5 @@
-import {UserVerificationComponent} from './app/components/user-verification/user-verification.component';
-import { ComingSoonComponent } from './app/components/coming-soon/coming-soon.component';
+import { UserVerificationComponent } from './app/components/user-verification/user-verification.component'
+import { ComingSoonComponent } from './app/components/coming-soon/coming-soon.component'
 import { UserEditComponent } from './app/components/user-edit/user-edit.component'
 import { UserPermissionsEditComponent } from './app/components/user-permissions-edit/user-permissions-edit.component'
 import { UserPermissionsAddComponent } from './app/components/user-permissions-add/user-permissions-add.component'
@@ -14,11 +14,10 @@ import { NavHeaderComponent } from './app/components/nav-header/nav-header.compo
 import { LoginLoaderComponent } from './app/components/login-loader/login-loader.component'
 import { LoginFormComponent } from './app/components/login-form/login-form.component'
 import { RegisterFormComponent } from './app/components/register-form/register-form.component'
-import { CreatePostFormComponent } from './app/components/create_post_form/create_post_form.component'
 
 angular.module('app.components')
-	.component('userVerification', UserVerificationComponent)
-	.component('comingsoon', ComingSoonComponent)
+  .component('userVerification', UserVerificationComponent)
+  .component('comingsoon', ComingSoonComponent)
   .component('useredit', UserEditComponent)
   .component('userpermissionsedit', UserPermissionsEditComponent)
   .component('userpermissionsadd', UserPermissionsAddComponent)
@@ -33,4 +32,3 @@ angular.module('app.components')
   .component('loginLoader', LoginLoaderComponent)
   .component('loginForm', LoginFormComponent)
   .component('registerForm', RegisterFormComponent)
-  .component('createPostForm', CreatePostFormComponent)

angular/app/components/user-verification/user-verification.component.js

@@ -35,5 +35,5 @@ export function RoutesRun ($rootScope, $state, $auth, AclService, $timeout) {
 
   $rootScope.$on('$destroy', deregisterationCallback)
   $rootScope.$on('$stateChangeSuccess', fixSideBar)
-  /*eslint-enable */
+/*eslint-enable */
 }

angular/config/acl.config.js

@@ -14,7 +14,7 @@ export class APIService {
         .setErrorInterceptor(function (response) {
           if (response.status === 422) {
             // for (var error in response.data.errors) {
-              // return ToastService.error(response.data.errors[error][0])
+            // return ToastService.error(response.data.errors[error][0])
             // }
           }
         })

angular/index.components.js

@@ -185,18 +185,13 @@ public function verifyUserEmail($verificationCode)
      */
     public function postRegister(Request $request)
     {
-        $verificationCode = str_random(40);
-
-        Mail::send('emails.userverification', ['verificationCode' => $verificationCode], function ($m) use ($request) {
-            $m->to($request->email, 'test')->subject('Email Confirmation');
-        });
-
         $this->validate($request, [
             'name'       => 'required|min:3',
             'email'      => 'required|email|unique:users',
             'password'   => 'required|min:8',
         ]);
 
+        $verificationCode = str_random(40);
         $user = new User;
         $user->name = trim($request->name);
         $user->email = trim(strtolower($request->email));
@@ -206,6 +201,10 @@ public function postRegister(Request $request)
 
         $token = JWTAuth::fromUser($user);
 
+        Mail::send('emails.userverification', ['verificationCode' => $verificationCode], function ($m) use ($request) {
+            $m->to($request->email, 'test')->subject('Email Confirmation');
+        });
+
         return response()->success(compact('user', 'token'));
     }
 }

angular/run/routes.run.js

@@ -26,7 +26,7 @@ module.exports = function (config) {
     plugins: [
       'karma-jasmine',
       'karma-phantomjs-launcher',
-      'karma-browserify',
+      'karma-browserify'
     ]
 
   // define reporters, port, logLevel, browsers etc.

angular/services/API.service.js

@@ -17,9 +17,9 @@ Elixir.extend('angular', function (src, output, outputFilename) {
     return gulp.src([baseDir + 'index.main.js', baseDir + '**/*.*.js'])
       .pipe(eslint({
         globals: {
-            'jQuery':false,
-            '$':true,
-            'swal': true
+          'jQuery': false,
+          '$': true,
+          'swal': true
         }
       }))
       .pipe(eslint.format())

app/Http/Controllers/Auth/AuthController.php

@@ -13,6 +13,7 @@ public function testSuccessfulLogin()
     {
         $user = factory(App\User::class)->create([
             'password' => bcrypt('test12345'),
+            'email_verified' => '1'
         ]);
 
         $this->post('/api/auth/login', [
@@ -30,7 +31,9 @@ public function testSuccessfulLogin()
      */
     public function testFailedLogin()
     {
-        $user = factory(App\User::class)->create();
+        $user = factory(App\User::class)->create([
+            'email_verified' => '1'
+        ]);
 
         $this->post('/api/auth/login', [
             'email'    => $user->email,
@@ -49,9 +52,10 @@ public function testSuccessfulRegistration()
         $user = factory(App\User::class)->make();
 
         $this->post('/api/auth/register', [
-            'name'     => $user->name,
-            'email'    => $user->email,
-            'password' => 'test15125',
+            'name'           => $user->name,
+            'email'          => $user->email,
+            'password'       => 'test15125',
+            'email_verified' => '1'
         ])
         ->seeApiSuccess()
         ->seeJsonKeyValueString('email', $user->email)

karma.conf.js

@@ -1,11 +1,10 @@
 ngDescribe({
-    name: 'Test coming-soon component',
-    modules: 'app',
-    element: '<coming-soon></coming-soon>',
-    tests: function (deps) {
-
-        it('basic test', () => {
-            //
-        });
-    }
-});
+  name: 'Test coming-soon component',
+  modules: 'app',
+  element: '<coming-soon></coming-soon>',
+  tests: function (deps) {
+    it('basic test', () => {
+      //
+    })
+  }
+})

tasks/angular.task.js

@@ -1,11 +1,10 @@
 ngDescribe({
-    name: 'Test user-verification component',
-    modules: 'app',
-    element: '<user-verification></user-verification>',
-    tests: function (deps) {
-
-        it('basic test', () => {
-            //
-        });
-    }
-});
+  name: 'Test user-verification component',
+  modules: 'app',
+  element: '<user-verification></user-verification>',
+  tests: function (deps) {
+    it('basic test', () => {
+      //
+    })
+  }
+})