Skip to content

Commit 5dd292c

Browse files
authored
feat: add php 8.0 kokoro tests, remove php 7.2 (GoogleCloudPlatform#1269)
(recreating to refresh kokoro builds)
1 parent 44f66f7 commit 5dd292c

File tree

149 files changed

+1066
-1046
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

149 files changed

+1066
-1046
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Configure the docker image for kokoro-trampoline.
44
env_vars: {
55
key: "TRAMPOLINE_IMAGE"
6-
value: "gcr.io/cloud-devrel-kokoro-resources/php72"
6+
value: "gcr.io/cloud-devrel-kokoro-resources/php80"
77
}
88

99
# Give the docker image a unique project ID and credentials per PHP version

appengine/flexible/analytics/test/DeployTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testIndex()
2929
$resp = $this->client->get('/');
3030
$this->assertEquals('200', $resp->getStatusCode(),
3131
'top page status code');
32-
$this->assertContains('returned 200', (string) $resp->getBody(),
32+
$this->assertStringContainsString('returned 200', (string) $resp->getBody(),
3333
'top page content');
3434
}
3535
}

appengine/flexible/analytics/test/LocalTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
class LocalTest extends WebTestCase
2222
{
23-
public function setUp()
23+
public function setUp(): void
2424
{
2525
parent::setUp();
2626
$this->client = $this->createClient();

appengine/flexible/datastore/test/DeployTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ public function testIndex()
3030
$this->assertEquals('200', $resp->getStatusCode(),
3131
'top page status code');
3232

33-
$this->assertContains("Last 10 visits:", (string) $resp->getBody());
33+
$this->assertStringContainsString("Last 10 visits:", (string) $resp->getBody());
3434
}
3535
}

appengine/flexible/datastore/test/LocalTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
class LocalTest extends WebTestCase
2222
{
23-
public function setUp()
23+
public function setUp(): void
2424
{
2525
parent::setUp();
2626
$this->client = $this->createClient();
@@ -43,6 +43,6 @@ public function testIndex()
4343
$client->request('GET', '/');
4444
$this->assertTrue($client->getResponse()->isOk());
4545
$text = $client->getResponse()->getContent();
46-
$this->assertContains("Last 10 visits:", $text);
46+
$this->assertStringContainsString("Last 10 visits:", $text);
4747
}
4848
}

appengine/flexible/drupal8/test/DeployTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public function testContacts()
115115
'top page status code'
116116
);
117117
$content = $resp->getBody()->getContents();
118-
$this->assertContains('Website feedback', $content);
119-
$this->assertContains('Drupal', $content);
118+
$this->assertStringContainsString('Website feedback', $content);
119+
$this->assertStringContainsString('Drupal', $content);
120120
}
121121
}

appengine/flexible/helloworld/test/ControllersTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function testTopPage()
4040
$crawlerexport = $client->request('GET', '/');
4141
$resp = $client->getResponse();
4242
$this->assertTrue($resp->isOk());
43-
$this->assertContains('Hello World', $resp->getContent());
43+
$this->assertStringContainsString('Hello World', $resp->getContent());
4444
}
4545

4646
public function testGoodbye()
@@ -49,6 +49,6 @@ public function testGoodbye()
4949
$crawlerexport = $client->request('GET', '/goodbye');
5050
$resp = $client->getResponse();
5151
$this->assertTrue($resp->isOk());
52-
$this->assertContains('Goodbye World', $resp->getContent());
52+
$this->assertStringContainsString('Goodbye World', $resp->getContent());
5353
}
5454
}

appengine/flexible/helloworld/test/DeployTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function testIndex()
3232
$resp = $this->client->get('/');
3333
$this->assertEquals('200', $resp->getStatusCode(),
3434
'index status code');
35-
$this->assertContains('Hello World', (string) $resp->getBody(),
35+
$this->assertStringContainsString('Hello World', (string) $resp->getBody(),
3636
'index content');
3737
}
3838
}

appengine/flexible/laravel/test/DeployDatabaseSessionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,6 @@ public function testHomepage()
111111
'top page status code'
112112
);
113113
$content = $resp->getBody()->getContents();
114-
$this->assertContains('Laravel', $content);
114+
$this->assertStringContainsString('Laravel', $content);
115115
}
116116
}

appengine/flexible/laravel/test/DeployTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public function testHomepage()
109109
'top page status code'
110110
);
111111
$content = $resp->getBody()->getContents();
112-
$this->assertContains('Laravel', $content);
112+
$this->assertStringContainsString('Laravel', $content);
113113
}
114114

115115
public function testNormalLog()

0 commit comments

Comments
 (0)