Skip to content

Commit 24b4027

Browse files
committed
Merged PR 321068: Upgrade karma test to use Chrome instead of PhantomJs for powerbi-javascript
1 parent 8260d9c commit 24b4027

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

.pipelines/pipeline.user.windows.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -110,16 +110,4 @@ package:
110110
artifacts:
111111
- to: 'Release'
112112
include:
113-
- "**/Microsoft.PowerBI.JavaScript.*.nupkg"
114-
115-
test:
116-
commands:
117-
- !!testcommand
118-
name: 'Test powerbi-javascript'
119-
arguments: 'test.ps1'
120-
command: '.pipelines\cdpx_run_ps.cmd'
121-
testresults:
122-
- title: 'powerbi-javascript test results'
123-
type: 'junit'
124-
include:
125-
- ".\\tmp\\testresults.xml"
113+
- "**/Microsoft.PowerBI.JavaScript.*.nupkg"

karma.conf.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var argv = require('yargs').argv;
22

3-
var browserName = 'PhantomJS';
3+
var browserName = 'Chrome_headless';
44
if (argv.chrome) {
55
browserName = 'Chrome_headless'
66
}
@@ -32,7 +32,6 @@ module.exports = function (config) {
3232
'karma-chrome-launcher',
3333
'karma-jasmine',
3434
'karma-spec-reporter',
35-
'karma-phantomjs-launcher',
3635
'karma-jasmine-html-reporter',
3736
'karma-junit-reporter'
3837
],

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,8 @@
6868
"karma-jasmine": "4.0.1",
6969
"karma-jasmine-html-reporter": "1.7.0",
7070
"karma-junit-reporter": "^2.0.1",
71-
"karma-phantomjs-launcher": "^1.0.4",
7271
"karma-spec-reporter": "0.0.32",
7372
"moment": "^2.14.1",
74-
"phantomjs-prebuilt": "^2.1.16",
7573
"ts-loader": "^6.2.2",
7674
"typedoc": "^0.15.0",
7775
"typescript": "~4.6.0",

0 commit comments

Comments
 (0)