Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/Arduino
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: andrewdotn/Arduino
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 7, 2019

  1. Hide splash screen asap if not using gui 

    Fixes #1970

On macOS, when running,

    Arduino.app/Contents/MacOS/Arduino --upload sketch.ino

a splash screen is visible the entire time the upload is running.

This PR hides that splash screen as soon as it’s known for sure that the
GUI should not be displayed. This makes for a slightly better user
experience: there’s still a splash screen, but it only appears briefly at
launch time.

The [SplashScreen docs][] explain:

> The splash screen can be displayed at application startup, before the
> Java Virtual Machine (JVM) starts. ... is closed automatically as soon as
> the first window is displayed by Swing/AWT (may be also closed manually
> using the Java API, see below)

[SplashScreen docs]: https://docs.oracle.com/javase/7/docs/api/java/awt/SplashScreen.html
    @andrewdotn
    andrewdotn committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    add4ed8 View commit details
    Browse the repository at this point in the history
Loading