Skip to content

Commit f2e8742

Browse files
committed
Merge pull request google#71 from romannurik/master
Update to v21 SwipeRefreshLayout. Also fix nav drawer BACK button bug.
2 parents c6d0017 + 1d8ff28 commit f2e8742

File tree

6 files changed

+30
-874
lines changed

6 files changed

+30
-874
lines changed

android/src/main/java/com/google/samples/apps/iosched/ui/BaseActivity.java

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import android.provider.Settings;
4646
import android.support.v4.view.ViewCompat;
4747
import android.support.v4.widget.DrawerLayout;
48+
import android.support.v4.widget.SwipeRefreshLayout;
4849
import android.support.v7.app.ActionBar;
4950
import android.support.v7.app.ActionBarActivity;
5051
import android.support.v7.widget.Toolbar;
@@ -76,7 +77,6 @@
7677
import com.google.samples.apps.iosched.ui.debug.DebugActionRunnerActivity;
7778
import com.google.samples.apps.iosched.ui.widget.MultiSwipeRefreshLayout;
7879
import com.google.samples.apps.iosched.ui.widget.ScrimInsetsScrollView;
79-
import com.google.samples.apps.iosched.ui.widget.SwipeRefreshLayout;
8080
import com.google.samples.apps.iosched.util.AccountUtils;
8181
import com.google.samples.apps.iosched.util.AnalyticsManager;
8282
import com.google.samples.apps.iosched.util.HelpUtils;
@@ -270,11 +270,10 @@ protected void onCreate(Bundle savedInstanceState) {
270270
private void trySetupSwipeRefresh() {
271271
mSwipeRefreshLayout = (SwipeRefreshLayout) findViewById(R.id.swipe_refresh_layout);
272272
if (mSwipeRefreshLayout != null) {
273-
mSwipeRefreshLayout.setColorScheme(
273+
mSwipeRefreshLayout.setColorSchemeResources(
274274
R.color.refresh_progress_1,
275275
R.color.refresh_progress_2,
276-
R.color.refresh_progress_3,
277-
R.color.refresh_progress_4);
276+
R.color.refresh_progress_3);
278277
mSwipeRefreshLayout.setOnRefreshListener(new SwipeRefreshLayout.OnRefreshListener() {
279278
@Override
280279
public void onRefresh() {
@@ -299,11 +298,13 @@ private void updateSwipeRefreshProgressBarTop() {
299298
return;
300299
}
301300

302-
if (mActionBarShown) {
303-
mSwipeRefreshLayout.setProgressBarTop(mProgressBarTopWhenActionBarShown);
304-
} else {
305-
mSwipeRefreshLayout.setProgressBarTop(0);
306-
}
301+
int progressBarStartMargin = getResources().getDimensionPixelSize(
302+
R.dimen.swipe_refresh_progress_bar_start_margin);
303+
int progressBarEndMargin = getResources().getDimensionPixelSize(
304+
R.dimen.swipe_refresh_progress_bar_end_margin);
305+
int top = mActionBarShown ? mProgressBarTopWhenActionBarShown : 0;
306+
mSwipeRefreshLayout.setProgressViewOffset(false,
307+
top + progressBarStartMargin, top + progressBarEndMargin);
307308
}
308309

309310
/**
@@ -435,6 +436,12 @@ protected boolean isNavDrawerOpen() {
435436
return mDrawerLayout != null && mDrawerLayout.isDrawerOpen(Gravity.START);
436437
}
437438

439+
protected void closeNavDrawer() {
440+
if (mDrawerLayout != null) {
441+
mDrawerLayout.closeDrawer(Gravity.START);
442+
}
443+
}
444+
438445
/** Populates the navigation drawer with the appropriate items. */
439446
private void populateNavDrawer() {
440447
boolean attendeeAtVenue = PrefUtils.isAttendeeAtVenue(this);
@@ -479,6 +486,15 @@ private void populateNavDrawer() {
479486
createNavDrawerItems();
480487
}
481488

489+
@Override
490+
public void onBackPressed() {
491+
if (isNavDrawerOpen()) {
492+
closeNavDrawer();
493+
} else {
494+
super.onBackPressed();
495+
}
496+
}
497+
482498
private void createNavDrawerItems() {
483499
mDrawerItemsListContainer = (ViewGroup) findViewById(R.id.navdrawer_items_list);
484500
if (mDrawerItemsListContainer == null) {

android/src/main/java/com/google/samples/apps/iosched/ui/widget/MultiSwipeRefreshLayout.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import android.content.res.TypedArray;
2121
import android.graphics.Canvas;
2222
import android.graphics.drawable.Drawable;
23+
import android.support.v4.widget.SwipeRefreshLayout;
2324
import android.util.AttributeSet;
2425

2526
import com.google.samples.apps.iosched.R;

android/src/main/java/com/google/samples/apps/iosched/ui/widget/SwipeProgressBar.java

Lines changed: 0 additions & 267 deletions
This file was deleted.

0 commit comments

Comments
 (0)