fix(chapter-9): Remove modification of type attribute on buttons

This is not allowed by certain browsers who shall not be named, and so neither by jQuery.

Author: petebacondarwin

1820EN_09_Code/02_button_directive/directive.js

@@ -5,12 +5,8 @@ angular.module('button-directive', [])
     restrict: 'E',
     compile: function(element, attributes) {
       element.addClass('btn');
-      if ( attributes.type === 'submit' || attributes.type === "primary" ) {
-        attributes.$set('type','submit');
+      if ( attributes.type === 'submit' ) {
         element.addClass('btn-primary');
-      } else if ( angular.isDefined(attributes.type) && attributes.type !== 'reset' ) {
-        element.addClass('btn-' + attributes.type);
-        attributes.$set('type', 'button');
       }
       if ( attributes.size ) {
         element.addClass('btn-' + attributes.size);

1820EN_09_Code/02_button_directive/directive.spec.js

@@ -21,17 +21,9 @@ describe('button directive', function () {
     expect(element.hasClass('btn-large')).toBe(true);
   });
 
-  it('set button type and CSS classes correctly', function() {
+  it('adds primary class to submit buttons', function() {
     var element = $compile('<button type="submit"></button>')($rootScope);
     expect(element.hasClass('btn-primary')).toBe(true);
-    expect(element.attr('type')).toBe('submit');
-
-    element = $compile('<button type="reset"></button>')($rootScope);
-    expect(element.attr('type')).toBe('reset');
-
-    element = $compile('<button type="warning"> </button>')($rootScope);
-    expect(element.hasClass('btn-warning')).toBe(true);
-    expect(element.attr('type')).toBe('button');
   });
 
 });