Revert "fix(compiler): Pretty print object instead of [Object object] (angular#22689)" (angular#23442)

This reverts commit 8555a3a.

Reverted because of angular#23440

PR Close angular#23442

Author: vicb

packages/compiler/src/util.ts

@@ -163,8 +163,6 @@ export interface OutputContext {
   importExpr(reference: any, typeParams?: o.Type[]|null, useSummaries?: boolean): o.Expression;
 }
 
-const MAX_LENGTH_STRINGIFY = 100;
-
 export function stringify(token: any): string {
   if (typeof token === 'string') {
     return token;
@@ -186,27 +184,16 @@ export function stringify(token: any): string {
     return `${token.name}`;
   }
 
-  let res;
-  try {
-    res = JSON.stringify(token);
-  } catch {
-    res = token.toString();
-  }
+  // WARNING: do not try to `JSON.stringify(token)` here
+  // see https://github.com/angular/angular/issues/23440
+  const res = token.toString();
 
   if (res == null) {
     return '' + res;
   }
 
   const newLineIndex = res.indexOf('\n');
-  if (0 < newLineIndex) {
-    res = res.substring(0, newLineIndex);
-  }
-
-  if (MAX_LENGTH_STRINGIFY < res.length) {
-    res = res.substring(0, MAX_LENGTH_STRINGIFY) + '...';
-  }
-
-  return res;
+  return newLineIndex === -1 ? res : res.substring(0, newLineIndex);
 }
 
 /**

packages/compiler/test/metadata_resolver_spec.ts

@@ -409,7 +409,7 @@ import {TEST_COMPILER_PROVIDERS} from './test_bindings';
 
          expect(() => { resolver.getNgModuleMetadata(InvalidModule); })
              .toThrowError(
-                 `Unexpected value '{"ngModule":true}' imported by the module 'InvalidModule'. Please add a @NgModule annotation.`);
+                 `Unexpected value '[object Object]' imported by the module 'InvalidModule'. Please add a @NgModule annotation.`);
        }));
   });
 

packages/compiler/test/util_spec.ts

@@ -7,8 +7,7 @@
  */
 
 import {fakeAsync} from '@angular/core/testing/src/fake_async';
-
-import {SyncAsync, escapeRegExp, splitAtColon, stringify, utf8Encode} from '../src/util';
+import {SyncAsync, escapeRegExp, splitAtColon, utf8Encode} from '../src/util';
 
 {
   describe('util', () => {
@@ -76,23 +75,5 @@ import {SyncAsync, escapeRegExp, splitAtColon, stringify, utf8Encode} from '../s
             ([input, output]: [string, string]) => { expect(utf8Encode(input)).toEqual(output); });
       });
     });
-
-    describe('stringify', () => {
-      it('should pretty print an Object', () => {
-        const result = stringify({hello: 'world'});
-        expect(result).toBe('{"hello":"world"}');
-      });
-
-      it('should truncate large object', () => {
-        const result = stringify({
-          selector: 'app-root',
-          preserveWhitespaces: false,
-          templateUrl: './app.component.ng.html',
-          styleUrls: ['./app.component.css']
-        });
-        expect(result).toBe(
-            '{"selector":"app-root","preserveWhitespaces":false,"templateUrl":"./app.component.ng.html","styleUrl...');
-      });
-    });
   });
-}
+}

packages/core/test/bundling/hello_world_r2/bundle.golden_symbols.json

@@ -1004,9 +1004,6 @@
   {
     "name": "LiteralPrimitive"
   },
-  {
-    "name": "MAX_LENGTH_STRINGIFY"
-  },
   {
     "name": "MEANING_SEPARATOR"
   },