fix(ivy): TestBed.get(Compiler) throws "Error: Runtime compiler is not loaded" (angular#27223)

BREAKING CHANGE:

The public API for `DebugNode` was accidentally too broad. This change removes
1. Public constructor. Since `DebugNode` is a way for Angular to communicate information
   on to the developer there is no reason why the developer should ever need to
   Instantiate the `DebugNode`
2. We are also removing `removeChild`, `addChild`, `insertBefore`, and `insertChildAfter`.
   All of these methods are used by Angular to constructor the correct `DebugNode` tree.
   There is no reason why the developer should ever be constructing a `DebugNode` tree
   And these methods should have never been made public.
3. All properties have been change to `readonly` since `DebugNode` is used by Angular
   to communicate to developer and there is no reason why these APIs should be writable.

While technically breaking change we don’t expect anyone to be effected by this change.

PR Close angular#27223

Author: mhevery

packages/common/test/directives/ng_component_outlet_spec.ts

@@ -144,22 +144,21 @@ describe('insert/remove', () => {
        expect(fixture.nativeElement).toHaveText('projected foo');
      }));
 
-  fixmeIvy('FW-561: Runtime compiler is not loaded') &&
-      it('should resolve components from other modules, if supplied', async(() => {
-           const compiler = TestBed.get(Compiler) as Compiler;
-           let fixture = TestBed.createComponent(TestComponent);
+  it('should resolve components from other modules, if supplied', async(() => {
+       const compiler = TestBed.get(Compiler) as Compiler;
+       let fixture = TestBed.createComponent(TestComponent);
 
-           fixture.detectChanges();
-           expect(fixture.nativeElement).toHaveText('');
+       fixture.detectChanges();
+       expect(fixture.nativeElement).toHaveText('');
 
-           fixture.componentInstance.module = compiler.compileModuleSync(TestModule2);
-           fixture.componentInstance.currentComponent = Module2InjectedComponent;
+       fixture.componentInstance.module = compiler.compileModuleSync(TestModule2);
+       fixture.componentInstance.currentComponent = Module2InjectedComponent;
 
-           fixture.detectChanges();
-           expect(fixture.nativeElement).toHaveText('baz');
-         }));
+       fixture.detectChanges();
+       expect(fixture.nativeElement).toHaveText('baz');
+     }));
 
-  fixmeIvy('FW-561: Runtime compiler is not loaded') &&
+  fixmeIvy('FW-739: destroy on NgModuleRef is not being called') &&
       it('should clean up moduleRef, if supplied', async(() => {
            let destroyed = false;
            const compiler = TestBed.get(Compiler) as Compiler;
@@ -176,40 +175,38 @@ describe('insert/remove', () => {
            expect(moduleRef.destroy).toHaveBeenCalled();
          }));
 
-  fixmeIvy('FW-561: Runtime compiler is not loaded') &&
-      it('should not re-create moduleRef when it didn\'t actually change', async(() => {
-           const compiler = TestBed.get(Compiler) as Compiler;
-           const fixture = TestBed.createComponent(TestComponent);
+  it('should not re-create moduleRef when it didn\'t actually change', async(() => {
+       const compiler = TestBed.get(Compiler) as Compiler;
+       const fixture = TestBed.createComponent(TestComponent);
 
-           fixture.componentInstance.module = compiler.compileModuleSync(TestModule2);
-           fixture.componentInstance.currentComponent = Module2InjectedComponent;
-           fixture.detectChanges();
-           expect(fixture.nativeElement).toHaveText('baz');
-           const moduleRef = fixture.componentInstance.ngComponentOutlet['_moduleRef'];
+       fixture.componentInstance.module = compiler.compileModuleSync(TestModule2);
+       fixture.componentInstance.currentComponent = Module2InjectedComponent;
+       fixture.detectChanges();
+       expect(fixture.nativeElement).toHaveText('baz');
+       const moduleRef = fixture.componentInstance.ngComponentOutlet['_moduleRef'];
 
-           fixture.componentInstance.currentComponent = Module2InjectedComponent2;
-           fixture.detectChanges();
+       fixture.componentInstance.currentComponent = Module2InjectedComponent2;
+       fixture.detectChanges();
 
-           expect(fixture.nativeElement).toHaveText('baz2');
-           expect(moduleRef).toBe(fixture.componentInstance.ngComponentOutlet['_moduleRef']);
-         }));
+       expect(fixture.nativeElement).toHaveText('baz2');
+       expect(moduleRef).toBe(fixture.componentInstance.ngComponentOutlet['_moduleRef']);
+     }));
 
-  fixmeIvy('FW-561: Runtime compiler is not loaded') &&
-      it('should re-create moduleRef when changed', async(() => {
-           const compiler = TestBed.get(Compiler) as Compiler;
-           const fixture = TestBed.createComponent(TestComponent);
-           fixture.componentInstance.module = compiler.compileModuleSync(TestModule2);
-           fixture.componentInstance.currentComponent = Module2InjectedComponent;
-           fixture.detectChanges();
+  it('should re-create moduleRef when changed', async(() => {
+       const compiler = TestBed.get(Compiler) as Compiler;
+       const fixture = TestBed.createComponent(TestComponent);
+       fixture.componentInstance.module = compiler.compileModuleSync(TestModule2);
+       fixture.componentInstance.currentComponent = Module2InjectedComponent;
+       fixture.detectChanges();
 
-           expect(fixture.nativeElement).toHaveText('baz');
+       expect(fixture.nativeElement).toHaveText('baz');
 
-           fixture.componentInstance.module = compiler.compileModuleSync(TestModule3);
-           fixture.componentInstance.currentComponent = Module3InjectedComponent;
-           fixture.detectChanges();
+       fixture.componentInstance.module = compiler.compileModuleSync(TestModule3);
+       fixture.componentInstance.currentComponent = Module3InjectedComponent;
+       fixture.detectChanges();
 
-           expect(fixture.nativeElement).toHaveText('bat');
-         }));
+       expect(fixture.nativeElement).toHaveText('bat');
+     }));
 });
 
 const TEST_TOKEN = new InjectionToken('TestToken');

packages/core/src/core_render3_private_export.ts

@@ -114,12 +114,9 @@ export {
   i18nEnd as ɵi18nEnd,
   i18nApply as ɵi18nApply,
   i18nPostprocess as ɵi18nPostprocess,
-  WRAP_RENDERER_FACTORY2 as ɵWRAP_RENDERER_FACTORY2,
   setClassMetadata as ɵsetClassMetadata,
 } from './render3/index';
 
-export {  Render3DebugRendererFactory2 as ɵRender3DebugRendererFactory2 } from './render3/debug';
-
 
 export {
   compileComponent as ɵcompileComponent,