Skip to content

Commit e6c81d2

Browse files
committed
Revert "refactor(platform-browser): move platform-browser/animations to animations/browser (angular#15043)"
This reverts commit 195b863.
1 parent 498a951 commit e6c81d2

File tree

58 files changed

+84
-210
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+84
-210
lines changed

packages/animations/browser/.babelrc-browser

-9
This file was deleted.

packages/animations/browser/.babelrc-browser-testing

-11
This file was deleted.

packages/animations/browser/index.ts

-14
This file was deleted.

packages/animations/browser/public_api.ts

-14
This file was deleted.

packages/animations/browser/src/browser.ts

-15
This file was deleted.

packages/animations/browser/src/private_export.ts

-15
This file was deleted.

packages/animations/browser/testing/tsconfig-build.json

-18
This file was deleted.

packages/animations/browser/tsconfig-build.json

-21
This file was deleted.

packages/animations/src/version.ts

+1-15
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,7 @@
1212
* Entry point for all public APIs of the animation package.
1313
*/
1414

15-
/**
16-
* @whatItDoes Represents the version of angular/animations
17-
*
18-
* @stable
19-
*/
20-
export class Version {
21-
constructor(public full: string) {}
22-
23-
get major(): string { return this.full.split('.')[0]; }
24-
25-
get minor(): string { return this.full.split('.')[1]; }
26-
27-
get patch(): string { return this.full.split('.').slice(2).join('.'); }
28-
}
29-
15+
import {Version} from '@angular/core';
3016
/**
3117
* @stable
3218
*/

packages/animations/tsconfig-build.json

+5-3
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
"experimentalDecorators": true,
77
"module": "es2015",
88
"moduleResolution": "node",
9-
"outDir": "../../../dist/packages-dist/animations",
9+
"outDir": "../../dist/packages/animations",
1010
"paths": {
11+
"@angular/core": ["../../dist/packages/core"],
12+
"@angular/core/testing": ["../../dist/packages/core/testing"]
1113
},
1214
"rootDir": ".",
1315
"sourceMap": true,
@@ -20,8 +22,8 @@
2022
},
2123
"files": [
2224
"public_api.ts",
23-
"../../../node_modules/zone.js/dist/zone.js.d.ts",
24-
"../../system.d.ts"
25+
"../../node_modules/zone.js/dist/zone.js.d.ts",
26+
"../system.d.ts"
2527
],
2628
"angularCompilerOptions": {
2729
"annotateForClosureCompiler": true,

packages/compiler-cli/integrationtest/src/module.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {ɵAnimationEngine} from '@angular/animations/browser';
109
import {ApplicationRef, NgModule, NgZone, Provider, RendererFactory2} from '@angular/core';
1110
import {FormsModule} from '@angular/forms';
12-
import {NoopAnimationsModule, ɵAnimationRendererFactory} from '@angular/platform-browser/animations';
11+
import {NoopAnimationsModule, ɵAnimationEngine, ɵAnimationRendererFactory} from '@angular/platform-browser/animations';
1312
import {ServerModule, ɵServerRendererFactory2} from '@angular/platform-server';
1413
import {MdButtonModule} from '@angular2-material/button';
1514
// Note: don't refer to third_party_src as we want to test that

packages/core/test/animation/animation_integration_spec.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,10 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88
import {AUTO_STYLE, AnimationEvent, animate, keyframes, state, style, transition, trigger} from '@angular/animations';
9-
import {AnimationDriver, ɵAnimationEngine} from '@angular/animations/browser';
10-
import {MockAnimationDriver, MockAnimationPlayer} from '@angular/animations/browser/testing';
119
import {Component, HostBinding, HostListener, RendererFactory2, ViewChild} from '@angular/core';
1210
import {ɵDomRendererFactory2} from '@angular/platform-browser';
13-
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
11+
import {AnimationDriver, BrowserAnimationsModule, ɵAnimationEngine} from '@angular/platform-browser/animations';
12+
import {MockAnimationDriver, MockAnimationPlayer} from '@angular/platform-browser/animations/testing';
1413
import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter';
1514

1615
import {TestBed} from '../../testing';

packages/examples/_common/system-config.ts

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ System.config({
1111
'@angular/common': '/vendor/@angular/common/bundles/common.umd.js',
1212
'@angular/compiler': '/vendor/@angular/compiler/bundles/compiler.umd.js',
1313
'@angular/animations': '/vendor/@angular/animations/bundles/animations.umd.js',
14-
'@angular/animations/browser': '/vendor/@angular/animations/bundles/animations-browser.umd.js',
1514
'@angular/platform-browser/animations':
1615
'/vendor/@angular/platform-browser/bundles/platform-browser-animations.umd.js',
1716
'@angular/core': '/vendor/@angular/core/bundles/core.umd.js',

packages/examples/core/animation/ts/dsl/animation_example.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
*/
88

99
// #docregion Component
10-
import {animate, state, style, transition, trigger} from '@angular/animations';
11-
import {Component, NgModule} from '@angular/core';
10+
import {Component, NgModule, animate, state, style, transition, trigger} from '@angular/core';
1211
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
1312

1413
@Component({

packages/platform-browser/animations/src/animations.ts

+1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@
1212
* Entry point for all animation APIs of the animation browser package.
1313
*/
1414
export {BrowserAnimationsModule, NoopAnimationsModule} from './module';
15+
export {AnimationDriver} from './render/animation_driver';
1516
export * from './private_export';

packages/platform-browser/animations/src/module.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88
import {NgModule} from '@angular/core';
9-
import {BrowserModule} from '@angular/platform-browser';
9+
import {BrowserModule, ɵDomRendererFactory2} from '@angular/platform-browser';
1010

1111
import {BROWSER_ANIMATIONS_PROVIDERS, BROWSER_NOOP_ANIMATIONS_PROVIDERS} from './providers';
1212

packages/platform-browser/animations/src/private_export.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,9 @@
55
* Use of this source code is governed by an MIT-style license that can be
66
* found in the LICENSE file at https://angular.io/license
77
*/
8-
export {AnimationRenderer as ɵAnimationRenderer, AnimationRendererFactory as ɵAnimationRendererFactory} from './animation_renderer';
8+
export {AnimationEngine as ɵAnimationEngine} from './animation_engine';
9+
export {Animation as ɵAnimation} from './dsl/animation';
10+
export {AnimationStyleNormalizer as ɵAnimationStyleNormalizer, NoopAnimationStyleNormalizer as ɵNoopAnimationStyleNormalizer} from './dsl/style_normalization/animation_style_normalizer';
11+
export {NoopAnimationDriver as ɵNoopAnimationDriver} from './render/animation_driver';
12+
export {AnimationRenderer as ɵAnimationRenderer, AnimationRendererFactory as ɵAnimationRendererFactory} from './render/animation_renderer';
13+
export {DomAnimationEngine as ɵDomAnimationEngine} from './render/dom_animation_engine';

packages/platform-browser/animations/src/providers.ts

+9-3
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,17 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {AnimationDriver, ɵAnimationEngine as AnimationEngine, ɵAnimationStyleNormalizer as AnimationStyleNormalizer, ɵDomAnimationEngine as DomAnimationEngine, ɵNoopAnimationDriver as NoopAnimationDriver, ɵNoopAnimationEngine as NoopAnimationEngine, ɵWebAnimationsDriver as WebAnimationsDriver, ɵWebAnimationsStyleNormalizer as WebAnimationsStyleNormalizer, ɵsupportsWebAnimations as supportsWebAnimations} from '@angular/animations/browser';
109
import {Injectable, NgZone, Provider, RendererFactory2} from '@angular/core';
1110
import {ɵDomRendererFactory2} from '@angular/platform-browser';
1211

13-
import {AnimationRendererFactory} from './animation_renderer';
12+
import {AnimationEngine} from './animation_engine';
13+
import {AnimationStyleNormalizer} from './dsl/style_normalization/animation_style_normalizer';
14+
import {WebAnimationsStyleNormalizer} from './dsl/style_normalization/web_animations_style_normalizer';
15+
import {AnimationDriver, NoopAnimationDriver} from './render/animation_driver';
16+
import {AnimationRendererFactory} from './render/animation_renderer';
17+
import {DomAnimationEngine} from './render/dom_animation_engine';
18+
import {NoopAnimationEngine} from './render/noop_animation_engine';
19+
import {WebAnimationsDriver, supportsWebAnimations} from './render/web_animations/web_animations_driver';
1420

1521
@Injectable()
1622
export class InjectableAnimationEngine extends DomAnimationEngine {
@@ -59,4 +65,4 @@ export const BROWSER_NOOP_ANIMATIONS_PROVIDERS: Provider[] = [
5965
useFactory: instantiateRendererFactory,
6066
deps: [ɵDomRendererFactory2, AnimationEngine, NgZone]
6167
}
62-
];
68+
];

packages/platform-browser/animations/src/animation_renderer.ts renamed to packages/platform-browser/animations/src/render/animation_renderer.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@
55
* Use of this source code is governed by an MIT-style license that can be
66
* found in the LICENSE file at https://angular.io/license
77
*/
8-
import {AnimationTriggerMetadata} from '@angular/animations';
9-
import {ɵAnimationEngine as AnimationEngine} from '@angular/animations/browser';
8+
import {AnimationEvent, AnimationTriggerMetadata} from '@angular/animations';
109
import {Injectable, NgZone, Renderer2, RendererFactory2, RendererStyleFlags2, RendererType2} from '@angular/core';
1110

11+
import {AnimationEngine} from '../animation_engine';
12+
1213
@Injectable()
1314
export class AnimationRendererFactory implements RendererFactory2 {
1415
constructor(

packages/animations/browser/test/engine/dom_animation_engine_spec.ts renamed to packages/platform-browser/animations/test/engine/dom_animation_engine_spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88
import {AnimationEvent, NoopAnimationPlayer, animate, keyframes, state, style, transition, trigger} from '@angular/animations';
9-
import {el} from '@angular/platform-browser/testing/browser_util';
9+
import {el} from '@angular/platform-browser/testing/src/browser_util';
1010

1111
import {buildAnimationKeyframes} from '../../src/dsl/animation_timeline_visitor';
1212
import {buildTrigger} from '../../src/dsl/animation_trigger';
1313
import {AnimationStyleNormalizer, NoopAnimationStyleNormalizer} from '../../src/dsl/style_normalization/animation_style_normalizer';
1414
import {DomAnimationEngine} from '../../src/render/dom_animation_engine';
15-
import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/mock_animation_driver';
15+
import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_animation_driver';
1616

1717
function makeTrigger(name: string, steps: any) {
1818
const triggerData = trigger(name, steps);

packages/platform-browser/animations/test/noop_animation_engine_spec.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88
import {state, style, trigger} from '@angular/animations';
9-
import {ɵNoopAnimationEngine as NoopAnimationEngine} from '@angular/animations/browser';
10-
import {el} from '@angular/platform-browser/testing/browser_util';
9+
import {el} from '@angular/platform-browser/testing/src/browser_util';
10+
11+
import {NoopAnimationEngine} from '../src/render/noop_animation_engine';
1112

1213
export function main() {
1314
describe('NoopAnimationEngine', () => {

packages/platform-browser/animations/test/noop_animations_module_spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,20 @@
55
* Use of this source code is governed by an MIT-style license that can be
66
* found in the LICENSE file at https://angular.io/license
77
*/
8-
import {animate, style, transition, trigger} from '@angular/animations';
9-
import {ɵAnimationEngine, ɵNoopAnimationEngine} from '@angular/animations/browser';
8+
import {animate, state, style, transition, trigger} from '@angular/animations';
109
import {Component} from '@angular/core';
1110
import {TestBed} from '@angular/core/testing';
12-
11+
import {ɵAnimationEngine} from '@angular/platform-browser/animations';
1312
import {NoopAnimationsModule} from '../src/module';
13+
import {NoopAnimationEngine} from '../src/render/noop_animation_engine';
1414

1515
export function main() {
1616
describe('NoopAnimationsModule', () => {
1717
beforeEach(() => { TestBed.configureTestingModule({imports: [NoopAnimationsModule]}); });
1818

1919
it('the engine should be a Noop engine', () => {
2020
const engine = TestBed.get(ɵAnimationEngine);
21-
expect(engine instanceof ɵNoopAnimationEngine).toBeTruthy();
21+
expect(engine instanceof NoopAnimationEngine).toBeTruthy();
2222
});
2323

2424
it('should flush and fire callbacks when the zone becomes stable', (async) => {

packages/animations/browser/testing/src/mock_animation_driver.ts renamed to packages/platform-browser/animations/testing/src/mock_animation_driver.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88
import {AUTO_STYLE, AnimationPlayer, NoopAnimationPlayer, ɵStyleData} from '@angular/animations';
99

10-
import {AnimationDriver} from '../src/render/animation_driver';
10+
import {AnimationDriver} from '../../src/render/animation_driver';
1111

1212
/**
1313
* @experimental Animation support is experimental.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
{
2+
"extends": "../../tsconfig-build",
3+
"compilerOptions": {
4+
"outDir": "../../../../dist/packages/platform-browser",
5+
"paths": {
6+
"@angular/core": ["../../dist/packages/core"],
7+
"@angular/core/testing": ["../../dist/packages/core/testing"],
8+
"@angular/animations": ["../../dist/packages/animations"],
9+
"@angular/platform-browser": ["../../dist/packages/platform-browser"],
10+
"@angular/platform-browser/animations": ["../../dist/packages/platform-browser/animations"],
11+
"@angular/common": ["../../dist/packages/common"],
12+
"@angular/common/testing": ["../../dist/packages/common/testing"]
13+
}
14+
},
15+
"files": [
16+
"index.ts",
17+
"../../../../node_modules/@types/hammerjs/index.d.ts",
18+
"../../../../node_modules/@types/jasmine/index.d.ts",
19+
"../../../../node_modules/zone.js/dist/zone.js.d.ts"
20+
],
21+
"angularCompilerOptions": {
22+
"strictMetadataEmit": true
23+
}
24+
}

packages/platform-browser/animations/tsconfig-build.json

+8-9
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
11
{
2-
"extends": "./tsconfig-build",
2+
"extends": "../tsconfig-build",
33

44
"compilerOptions": {
5-
"outDir": "../../../dist/packages-dist/platform-browser",
5+
"outDir": "../../../dist/packages/platform-browser",
66
"paths": {
7-
"rxjs/*": ["../../../node_modules/rxjs/*"],
8-
"@angular/core": ["../../../dist/packages-dist/core"],
9-
"@angular/core/testing": ["../../../dist/packages-dist/core/testing"],
10-
"@angular/animations": ["../../../dist/packages-dist/animations"],
11-
"@angular/animations/browser": ["../../../dist/packages-dist/animations/browser"],
12-
"@angular/platform-browser": ["../../../dist/packages-dist/platform-browser"]
7+
"rxjs/*": ["../../node_modules/rxjs/*"],
8+
"@angular/core": ["../../dist/packages/core"],
9+
"@angular/core/testing": ["../../dist/packages/core/testing"],
10+
"@angular/animations": ["../../dist/packages/animations"],
11+
"@angular/platform-browser": ["../../dist/packages/platform-browser"]
1312
}
1413
},
1514
"files": [
16-
"animations/public_api.ts",
15+
"public_api.ts",
1716
"../../../node_modules/zone.js/dist/zone.js.d.ts",
1817
"../../system.d.ts"
1918
],

0 commit comments

Comments
 (0)