Skip to content

Commit 8c3ba38

Browse files
crisbetocrisbeto
authored
build: update buildifier and fix failures (angular#18997)
Our version of `@bazel/buildifier` is pretty old. These changes bump to the latest version and fix the new failures that showed up.
1 parent a7ebc7a commit 8c3ba38

File tree

274 files changed

+561
-580
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

274 files changed

+561
-580
lines changed

‎BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//:rollup-globals.bzl", "ROLLUP_GLOBALS")
42
load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
53
load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_ENTRYPOINTS")
64
load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
75
load("//src/material-experimental:config.bzl", "MATERIAL_EXPERIMENTAL_ENTRYPOINTS", "MATERIAL_EXPERIMENTAL_TESTING_ENTRYPOINTS")
86

7+
package(default_visibility = ["//visibility:public"])
8+
99
exports_files([
1010
"LICENSE",
1111
"scss-bundle.config.json",

‎guides/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "markdown_to_html")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
markdown_to_html(
66
name = "guides",
77
srcs = glob(["**/*.md"]),

‎integration/ts-compat/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("@bazel_skylib//rules:write_file.bzl", "write_file")
42
load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_test")
53
load("//integration/ts-compat:import-all-entry-points.bzl", "generate_import_all_entry_points_file")
64

5+
package(default_visibility = ["//visibility:public"])
6+
77
write_file(
88
name = "import-all-entry-points-file",
99
out = "import-all-entry-points.ts",

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"@angular/platform-server": "^9.1.0",
7575
"@angular/router": "^9.1.0",
7676
"@bazel/bazelisk": "^1.3.0",
77-
"@bazel/buildifier": "^0.29.0",
77+
"@bazel/buildifier": "^2.2.1",
7878
"@bazel/ibazel": "^0.12.3",
7979
"@bazel/jasmine": "^1.5.0",
8080
"@bazel/karma": "^1.5.0",

‎src/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("@npm_bazel_typescript//:index.bzl", "ts_config")
42
load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
53
load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
64
load("//tools/dgeni:index.bzl", "dgeni_api_docs")
75

6+
package(default_visibility = ["//visibility:public"])
7+
88
cdkApiEntryPoints = CDK_ENTRYPOINTS
99

1010
materialApiEntryPoints = MATERIAL_ENTRYPOINTS + MATERIAL_TESTING_ENTRYPOINTS

‎src/cdk-experimental/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_TARGETS")
42
load("//tools:defaults.bzl", "ng_package", "ts_library")
53

4+
package(default_visibility = ["//visibility:public"])
5+
66
ts_library(
77
name = "cdk-experimental",
88
srcs = glob(

‎src/cdk-experimental/column-resize/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ng_module")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ng_module(
66
name = "column-resize",
77
srcs = glob(

‎src/cdk-experimental/dialog/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite", "sass_binary")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ng_module(
66
name = "dialog",
77
srcs = glob(

‎src/cdk-experimental/popover-edit/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ng_module(
66
name = "popover-edit",
77
srcs = glob(

‎src/cdk-experimental/scrolling/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
42
load("//tools:defaults.bzl", "ng_e2e_test_library", "ng_module", "ng_test_library", "ng_web_test_suite")
53

4+
package(default_visibility = ["//visibility:public"])
5+
66
ng_module(
77
name = "scrolling",
88
srcs = glob(

‎src/cdk/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS", "CDK_ENTRYPOINTS_WITH_STYLES", "CDK_SCSS_LIBS", "CDK_TARGETS")
42
load("//tools:defaults.bzl", "ng_package", "ts_library")
53

4+
package(default_visibility = ["//visibility:public"])
5+
66
ts_library(
77
name = "cdk",
88
srcs = glob(

‎src/cdk/a11y/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -10,6 +8,8 @@ load(
108
"sass_library",
119
)
1210

11+
package(default_visibility = ["//visibility:public"])
12+
1313
ng_module(
1414
name = "a11y",
1515
srcs = glob(

‎src/cdk/accordion/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "accordion",
1313
srcs = glob(

‎src/cdk/bidi/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "bidi",
1313
srcs = glob(

‎src/cdk/clipboard/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "markdown_to_html", "ng_module", "ng_test_library", "ng_web_test_suite")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ng_module(
66
name = "clipboard",
77
srcs = glob(

‎src/cdk/coercion/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ts_library")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ts_library(
66
name = "coercion",
77
srcs = glob(

‎src/cdk/collections/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "collections",
1313
srcs = glob(

‎src/cdk/drag-drop/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "drag-drop",
1313
srcs = glob(

‎src/cdk/keycodes/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "karma_web_test_suite", "markdown_to_html", "ng_module", "ts_library")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
# We need to use "ng_module" here since we want metadata to be generated for keycode
66
# constants. This is necessary because some of these constants are statically used in
77
# component/directive metadata (e.g. chips) and NGC needs to be able to evaluate these

‎src/cdk/layout/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "layout",
1313
srcs = glob(

‎src/cdk/observers/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "observers",
1313
srcs = glob(

‎src/cdk/overlay/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
42
load(
53
"//tools:defaults.bzl",
@@ -12,6 +10,8 @@ load(
1210
"sass_library",
1311
)
1412

13+
package(default_visibility = ["//visibility:public"])
14+
1515
ng_module(
1616
name = "overlay",
1717
srcs = glob(

‎src/cdk/platform/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "markdown_to_html", "ng_module")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ng_module(
66
name = "platform",
77
srcs = glob(

‎src/cdk/portal/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "portal",
1313
srcs = glob(

‎src/cdk/schematics/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
42
load("//:packages.bzl", "VERSION_PLACEHOLDER_REPLACEMENTS")
53
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
64

5+
package(default_visibility = ["//visibility:public"])
6+
77
filegroup(
88
name = "schematics_assets",
99
srcs = glob([

‎src/cdk/schematics/testing/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ts_library")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ts_library(
66
name = "testing",
77
srcs = glob(["**/*.ts"]),

‎src/cdk/schematics/update-tool/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ts_library")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ts_library(
66
name = "update-tool",
77
srcs = glob(["**/*.ts"]),

‎src/cdk/scrolling/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -9,6 +7,8 @@ load(
97
"sass_binary",
108
)
119

10+
package(default_visibility = ["//visibility:public"])
11+
1212
ng_module(
1313
name = "scrolling",
1414
srcs = glob(

‎src/cdk/stepper/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "markdown_to_html", "ng_module")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ng_module(
66
name = "stepper",
77
srcs = glob(

‎src/cdk/table/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load(
42
"//tools:defaults.bzl",
53
"markdown_to_html",
@@ -8,6 +6,8 @@ load(
86
"ng_web_test_suite",
97
)
108

9+
package(default_visibility = ["//visibility:public"])
10+
1111
ng_module(
1212
name = "table",
1313
srcs = glob(

‎src/cdk/testing/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//src/e2e-app:test_suite.bzl", "e2e_test_suite")
42
load("//tools:defaults.bzl", "markdown_to_html", "ng_web_test_suite", "ts_library")
53

4+
package(default_visibility = ["//visibility:public"])
5+
66
ts_library(
77
name = "testing",
88
srcs = glob(

‎src/cdk/testing/private/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ts_library")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
ts_library(
66
name = "private",
77
srcs = glob(

‎src/cdk/testing/private/e2e/BUILD.bazel

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package(default_visibility = ["//visibility:public"])
2-
31
load("//tools:defaults.bzl", "ng_e2e_test_library")
42

3+
package(default_visibility = ["//visibility:public"])
4+
55
exports_files(["tsconfig-e2e.json"])
66

77
ng_e2e_test_library(

0 commit comments

Comments
 (0)