Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 1c0da2e

Browse files
author
Jean Ducrot
committed
fix(a11y): CR tweaks
1 parent 1c30ecd commit 1c0da2e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

README.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ We thank you for all your contributions over the years and hope you've enjoyed u
88
### UI Bootstrap - For Interfolio Devs
99
Here are the steps you need to take to modify this library:
1010

11-
1 Clone the Interfolio angular-ui-bootstrap repo
12-
2 Install local packages `npm install`
13-
3 Install grunt if you don't already have it `npm i -g grunt-cli`
14-
4 CD into the MC directory of the FE you're working with
15-
5 Remove the local angular-ui-bootstrap directory `rm -rf node_modules/angular-ui-bootstrap`
16-
6 Create a symlink to your local angular-ui-bootstrap `ln -s ~/Interfolio/angular-ui-bootstrap node_modules/angular-ui-bootstrap`
17-
7 Go back to the angular-ui-bootstrap repo,
18-
8 To compile JS you will need to run `grunt build`
19-
8 To compile HTML you will need to run `grunt before-test build` and recompile your FE as templates get cached
20-
10 To run the build once you are done making all your changes, just use the default task `grunt`. This will run all the UTs and all the build process.
21-
12 You will need to create a tarball of the project before deploying it to GemFury.
11+
1. Clone the Interfolio angular-ui-bootstrap repo
12+
1. Install local packages `npm install`
13+
1. Install grunt if you don't already have it `npm i -g grunt-cli`
14+
1. CD into the MC directory of the FE you're working with
15+
1. Remove the local angular-ui-bootstrap directory `rm -rf node_modules/angular-ui-bootstrap`
16+
1. Create a symlink to your local angular-ui-bootstrap `ln -s ~/Interfolio/angular-ui-bootstrap node_modules/angular-ui-bootstrap`
17+
1. Go back to the angular-ui-bootstrap repo,
18+
1. To compile JS you will need to run `grunt build`
19+
1. To compile HTML you will need to run `grunt before-test build` and recompile your FE as templates get cached
20+
1. To run the build once you are done making all your changes, just use the default task `grunt`. This will run all the UTs and all the build process.
21+
1. You will need to create a tarball of the project before deploying it to GemFury.

template/datepicker/datepicker.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<div
2121
class="sr-only-liveregion"
2222
role="region"
23-
id="{{::uniqueId}}-liveregion"
23+
ng-attr-id="{{::uniqueId}}-liveregion"
2424
aria-live="assertive"
2525
aria-atomic="true"
2626
></div>

0 commit comments

Comments
 (0)