build: migrate all cross-package targets to use first-party links

Instead of e.g. depending on `src/cdk/testing`, we should use the
first-party linked package so that npm-module imports like
`@angular/cdk` still work. This is the new approach for `rules_js`. It's
notably slower, but with the simplicity gained, it's an acceptable
trade-off we are taking.

Author: devversion

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -2,19 +2,19 @@
 # Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-1406867100
-integration/package.json=122088
+integration/package.json=-620011313
 package.json=1314863161
 patches/@angular__compiler-cli.patch=-65319555
-pnpm-lock.yaml=-577830100
+pnpm-lock.yaml=-2045227594
 pnpm-workspace.yaml=334858811
-src/cdk-experimental/package.json=2063150503
+src/cdk-experimental/package.json=237487315
 src/cdk/package.json=-908433069
-src/components-examples/package.json=560048349
+src/components-examples/package.json=-2087309525
 src/dev-app/package.json=624475908
 src/e2e-app/package.json=-1971485006
 src/google-maps/package.json=-886415500
 src/material-date-fns-adapter/package.json=-332076964
-src/material-experimental/package.json=592784609
+src/material-experimental/package.json=-1707816737
 src/material-luxon-adapter/package.json=-199007660
 src/material-moment-adapter/package.json=-1407689629
 src/material/package.json=-1237533685

pnpm-lock.yaml

@@ -2,7 +2,7 @@ load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_TARGETS")
 load("//tools:defaults.bzl", "ng_package")
 load("//tools:defaults2.bzl", "ts_project")
 load("//tools/bazel:legacy_target.bzl", "get_legacy_label")
-load("@npm2//defs:bzl", "npm_link_all_packages")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
 
 package(default_visibility = ["//visibility:public"])
 

src/cdk-experimental/BUILD.bazel

@@ -12,12 +12,7 @@ ng_project(
         "//:node_modules/@angular/common",
         "//:node_modules/@angular/core",
         "//:node_modules/rxjs",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
         "//src/cdk-experimental/popover-edit",
-        "//src/cdk/bidi",
-        "//src/cdk/coercion",
-        "//src/cdk/keycodes",
-        "//src/cdk/overlay",
-        "//src/cdk/portal",
-        "//src/cdk/table",
     ],
 )

src/cdk-experimental/column-resize/BUILD.bazel

@@ -13,10 +13,7 @@ ng_project(
         "//:node_modules/@angular/common",
         "//:node_modules/@angular/core",
         "//src:dev_mode_types",
-        "//src/cdk/a11y",
-        "//src/cdk/bidi",
-        "//src/cdk/collections",
-        "//src/cdk/overlay",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 
@@ -31,8 +28,7 @@ ts_project(
         ":combobox",
         "//:node_modules/@angular/core",
         "//:node_modules/@angular/platform-browser",
-        "//src/cdk/keycodes",
-        "//src/cdk/testing/private",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 

src/cdk-experimental/combobox/BUILD.bazel

@@ -10,8 +10,7 @@ ng_project(
     ),
     deps = [
         "//:node_modules/@angular/core",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
         "//src/cdk-experimental/ui-patterns",
-        "//src/cdk/a11y",
-        "//src/cdk/bidi",
     ],
 )

src/cdk-experimental/listbox/BUILD.bazel

@@ -15,6 +15,9 @@
     "@angular/cdk": "0.0.0-PLACEHOLDER",
     "@angular/core": "0.0.0-NG"
   },
+  "devDependencies": {
+    "@angular/cdk": "workspace:*"
+  },
   "dependencies": {
     "tslib": "^2.3.0"
   },

src/cdk-experimental/package.json

@@ -14,12 +14,7 @@ ng_project(
         "//:node_modules/@angular/core",
         "//:node_modules/@angular/forms",
         "//:node_modules/rxjs",
-        "//src/cdk/a11y",
-        "//src/cdk/bidi",
-        "//src/cdk/keycodes",
-        "//src/cdk/overlay",
-        "//src/cdk/portal",
-        "//src/cdk/scrolling",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 
@@ -36,12 +31,7 @@ ts_project(
         "//:node_modules/@angular/core",
         "//:node_modules/@angular/forms",
         "//:node_modules/rxjs",
-        "//src/cdk/bidi",
-        "//src/cdk/collections",
-        "//src/cdk/keycodes",
-        "//src/cdk/overlay",
-        "//src/cdk/table",
-        "//src/cdk/testing/private",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 

src/cdk-experimental/popover-edit/BUILD.bazel

@@ -14,9 +14,7 @@ ng_project(
         "//:node_modules/@angular/core",
         "//:node_modules/rxjs",
         "//src:dev_mode_types",
-        "//src/cdk/coercion",
-        "//src/cdk/collections",
-        "//src/cdk/scrolling",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 
@@ -30,7 +28,7 @@ ts_project(
     deps = [
         ":scrolling",
         "//:node_modules/@angular/core",
-        "//src/cdk/scrolling",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 

src/cdk-experimental/scrolling/BUILD.bazel

@@ -15,9 +15,7 @@ ng_project(
         "//:node_modules/@angular/forms",
         "//:node_modules/rxjs",
         "//src:dev_mode_types",
-        "//src/cdk/coercion",
-        "//src/cdk/collections",
-        "//src/cdk/table",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 
@@ -32,7 +30,7 @@ ts_project(
         ":selection",
         "//:node_modules/@angular/common",
         "//:node_modules/@angular/core",
-        "//src/cdk/table",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
         "//src/cdk/testing/private",
     ],
 )

src/cdk-experimental/selection/BUILD.bazel

@@ -16,10 +16,7 @@ ng_project(
         "//:node_modules/@angular/common",
         "//:node_modules/@angular/core",
         "//:node_modules/rxjs",
-        "//src/cdk/a11y",
-        "//src/cdk/bidi",
-        "//src/cdk/platform",
-        "//src/cdk/table",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 
@@ -34,9 +31,7 @@ ts_project(
         ":table-scroll-container",
         "//:node_modules/@angular/core",
         "//:node_modules/rxjs",
-        "//src/cdk/collections",
-        "//src/cdk/platform",
-        "//src/cdk/table",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 

src/cdk-experimental/table-scroll-container/BUILD.bazel

@@ -27,8 +27,7 @@ ts_project(
     deps = [
         ":listbox",
         "//:node_modules/@angular/core",
-        "//src/cdk/keycodes",
-        "//src/cdk/testing/private",
+        "//src/cdk-experimental:node_modules/@angular/cdk",
     ],
 )
 

src/cdk-experimental/ui-patterns/listbox/BUILD.bazel

@@ -24,6 +24,7 @@ CDK_ENTRYPOINTS = [
     "text-field",
     "tree",
     "testing",
+    "testing/private",
     "testing/testbed",
     "testing/selenium-webdriver",
     "private",

src/cdk/config.bzl

@@ -1,6 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
-load("//tools:defaults.bzl", "jasmine_node_test")
-load("//tools:defaults2.bzl", "npm_package", "ts_project")
+load("//tools:defaults2.bzl", "jasmine_test", "npm_package", "ts_project")
 load("@aspect_rules_ts//ts:defs.bzl", rules_js_tsconfig = "ts_config")
 
 package(default_visibility = ["//visibility:public"])
@@ -91,10 +90,10 @@ ts_project(
     ],
 )
 
-jasmine_node_test(
+jasmine_test(
     name = "unit_tests",
-    srcs = [":unit_test_sources_legacy"],
     data = [
         ":schematics_assets",
+        ":unit_test_sources",
     ],
 )

src/cdk/schematics/BUILD.bazel

@@ -4,7 +4,6 @@ package(default_visibility = ["//visibility:public"])
 
 ts_project(
     name = "private",
-    testonly = True,
     srcs = glob(
         ["**/*.ts"],
         exclude = ["**/*.spec.ts"],
@@ -15,3 +14,8 @@ ts_project(
         "//src/cdk/testing/testbed",
     ],
 )
+
+filegroup(
+    name = "source-files",
+    srcs = glob(["**/*.ts"]),
+)

src/cdk/testing/private/BUILD.bazel

@@ -4,9 +4,12 @@ load("//tools/package-docs-content:index.bzl", "package_docs_content")
 load(":config.bzl", "ALL_EXAMPLES")
 load("//tools:defaults2.bzl", "ng_project")
 load("//tools/bazel:legacy_target.bzl", "get_legacy_label")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
 
 package(default_visibility = ["//visibility:public"])
 
+npm_link_all_packages()
+
 ng_project(
     name = "components-examples",
     srcs = glob(
@@ -15,6 +18,7 @@ ng_project(
     ) + [":example-module.ts"],
     deps = [
         "//:node_modules/@angular/core",
+        "//src/components-examples:node_modules/@angular/cdk",
     ] + ALL_EXAMPLES,
 )
 
@@ -59,12 +63,16 @@ package_docs_content(
 
 ng_package(
     name = "npm_package",
+    package_name = "@angular/components-examples",
     srcs = ["package.json"],
     # this is a workaround to store a tree artifact in the ng_package.
     # ng_package does not properly handle tree artifacts currently so we escalate to nested_packages
     nested_packages = [":docs-content"],
     tags = ["docs-package"],
-    deps = [":components-examples_legacy"] + [get_legacy_label(t) for t in ALL_EXAMPLES],
+    deps = [
+        ":components-examples_legacy",
+        "//src/components-examples/private:private_legacy",
+    ] + [get_legacy_label(t) for t in ALL_EXAMPLES],
 )
 
 genrule(

src/components-examples/BUILD.bazel

@@ -12,10 +12,9 @@ ng_project(
     deps = [
         "//:node_modules/@angular/core",
         "//:node_modules/@angular/forms",
-        "//src/cdk-experimental/listbox",
-        "//src/material/checkbox",
-        "//src/material/form-field",
-        "//src/material/select",
+        "//src/components-examples:node_modules/@angular/cdk",
+        "//src/components-examples:node_modules/@angular/cdk-experimental",
+        "//src/components-examples:node_modules/@angular/material",
     ],
 )
 

src/components-examples/cdk-experimental/listbox/BUILD.bazel

@@ -13,9 +13,8 @@ ng_project(
         "//:node_modules/@angular/core",
         "//:node_modules/@angular/forms",
         "//:node_modules/rxjs",
-        "//src/cdk-experimental/popover-edit",
-        "//src/cdk/collections",
-        "//src/cdk/table",
+        "//src/components-examples:node_modules/@angular/cdk",
+        "//src/components-examples:node_modules/@angular/cdk-experimental",
     ],
 )
 

src/components-examples/cdk-experimental/popover-edit/BUILD.bazel

@@ -13,10 +13,9 @@ ng_project(
         "//:node_modules/@angular/common",
         "//:node_modules/@angular/core",
         "//:node_modules/@angular/forms",
-        "//src/cdk-experimental/selection",
-        "//src/cdk/collections",
-        "//src/cdk/table",
-        "//src/material/checkbox",
+        "//src/components-examples:node_modules/@angular/cdk",
+        "//src/components-examples:node_modules/@angular/cdk-experimental",
+        "//src/components-examples:node_modules/@angular/material",
     ],
 )