Skip to content

Docs site dialog example plunker is broken #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KroneCorylus opened this issue Apr 4, 2017 · 4 comments
Closed

Docs site dialog example plunker is broken #3899

KroneCorylus opened this issue Apr 4, 2017 · 4 comments
Labels
docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@KroneCorylus
Copy link

Bug, feature request, or proposal:

The Dialog Component in the plunker Demo throws exeption: "The selector "dialog-overview-example-dialog" did not match any elements".

What is the expected behavior?

App work just fine but throws exception.

What are the steps to reproduce?

Go to Documentarion about Dialog Component and click on Edit on Plunker

What is the use-case or motivation for changing an existing behavior?

Because it confuses beginners like me

Is there anything else we should know?

Fix:
change

bootstrap: [DialogResultExample, DialogResultExampleDialog],

for

bootstrap: [DialogResultExample],
entryComponents: [DialogResultExampleDialog],

in main.ts file

@M-a-c
Copy link
Contributor

M-a-c commented Apr 4, 2017

Sort of related to #2934 (multi file demos don't list other files), multi component(selector) demos are broken on plunkr.

@jelbourn jelbourn changed the title The selector did not match any elements Docs site dialog example plunker is broken Apr 11, 2017
@jelbourn jelbourn added docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Apr 11, 2017
@ericgundrum
Copy link

@kronetorres, thanks for the fix. This seems relevant to any project using MdDialog, more than just the plunker example.

@ghost
Copy link

ghost commented Feb 12, 2018

@kronetorres @jelbourn I guess this issue can be closed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants